From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id BE3A93858289 for ; Mon, 10 Oct 2022 21:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE3A93858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pj1-x102d.google.com with SMTP id d7-20020a17090a2a4700b0020d268b1f02so4773979pjg.1 for ; Mon, 10 Oct 2022 14:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=3396ArfzrgAX5pR5Q23QBkPtzOyvOrCRjta97g0Nmg0=; b=nubL1szq6otVgpE/KB4ctBjjU6OgGsicx+JKkRPmCsUbpTXsiSm8SvuIPpaJ/AaO1P CNT9yffa7OlggifF+P4Sxr8yjFaZCLlSkjVf00XDe+KunZaOh2muYy5bI9I56JkuJ6UV bgSL/Ra4Td03YJ5xz/oBPtOu+DOG3O/4saDHVci4yEg3gXanLpQkFNgPsO10arPdPAYY V3OZFCE1eMzijP8sWnJDWlbMr/J0GlOCUmxvH0JQHJrIP6gDHJtDALkIOfCZVvXQf4iz DYAN0ic9DwHDLbB8gSNAlNQS0pPKSvijSKtC4M6/5hjhmahHtNZgUR5QDPmJ6MLCMw9i DFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3396ArfzrgAX5pR5Q23QBkPtzOyvOrCRjta97g0Nmg0=; b=1QGIEeuYf5SwdlSSAcOZ1nDkLikERL3JliGKoYU3AWDszxRkiO3xqOLfhFfsqakAlo uE3i6p8lxCQ2S33EhGF3QldODbsYwj5YKlGYsRR5Szt4x65V8lmIjLmgCddUrqkn7VS0 RZkOND1vbsagXHGbLsfL0g8+tyeLc7yYYcxATxHrzwp0essYzRERC+9m61MYoaFT8goD tleaBp0PnTp2MFDXVU7+VKpu4mTK3M7pb/YwPlzC3KOp51R1uZeb/2BW3s5zK9l8FoIn 6ge1D3Rn0DCAtr+a4jfUsb/Tv6r/n49mArYKOFprHShhPTXFg472Js66YbdEQxIbYWiI uzGw== X-Gm-Message-State: ACrzQf1jaU//0PnhsRWPikzP7IbEyFrC2p+gFbGDhYnYHyDkaWdjE0wq ymonuxwmLz0krzdRhtGBGCbLNdeGPKnbGm4s87FwurpkzR6jow== X-Google-Smtp-Source: AMsMyM4T8Gt1fqtemtPWJYXMfEM37pjXgoR5iwe3cE6x4XTa8hjSFrx+mMxlKQKe3fVNHxAdEU+8CeO4+fl4xvVlLbw= X-Received: by 2002:a17:902:70c4:b0:17c:f9fe:3200 with SMTP id l4-20020a17090270c400b0017cf9fe3200mr21210749plt.1.1665438401164; Mon, 10 Oct 2022 14:46:41 -0700 (PDT) MIME-Version: 1.0 From: Ian Lance Taylor Date: Mon, 10 Oct 2022 14:46:29 -0700 Message-ID: Subject: Go patch committed: Treat S("") as a string constant To: gcc-patches , gofrontend-dev Content-Type: multipart/mixed; boundary="0000000000004c39d305eab518ce" X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004c39d305eab518ce Content-Type: text/plain; charset="UTF-8" This Go frontend patch treats S("") as a string constant. The compiler neglected to notice that a conversion from a string constant to a string type was a valid string constant. I didn't add a test case because this only caused a compiler failure when compiling without optimization, which is not the normal case, and is not a case that we test. This fixes https://go.dev/issue/56113. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian --0000000000004c39d305eab518ce Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l93b0i8q0 MjliMGZlMzkzODU5NzI5MjE1YjBkYjVkMjhmMmZhZWEzMGM2ZWMzMgpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCAxYzI0 NjYwOTBmMS4uNWI5NWIzOGE1NDEgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotMTY0ZjJhZWIx ZGVlYzRjMTFlNTViOGJmYjE1MmZmN2ZmNGMxZGQ0YworNmMxODgxMDg4NThlM2FlOGM4ZWE4ZTRj YzU1NDI3ZDhjZjAxYmJjOAogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvZ2NjL2dvL2dvZnJvbnRlbmQvZXhwcmVz c2lvbnMuY2MgYi9nY2MvZ28vZ29mcm9udGVuZC9leHByZXNzaW9ucy5jYwppbmRleCAyNDdhZTFi YmEzNC4uNzE4MzhiMTQ2MjkgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Np b25zLmNjCisrKyBiL2djYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCkBAIC00MDkyLDYg KzQwOTIsOSBAQCBUeXBlX2NvbnZlcnNpb25fZXhwcmVzc2lvbjo6ZG9fbnVtZXJpY19jb25zdGFu dF92YWx1ZSgKIGJvb2wKIFR5cGVfY29udmVyc2lvbl9leHByZXNzaW9uOjpkb19zdHJpbmdfY29u c3RhbnRfdmFsdWUoc3RkOjpzdHJpbmcqIHZhbCkgY29uc3QKIHsKKyAgaWYgKHRoaXMtPnR5cGVf LT5pc19zdHJpbmdfdHlwZSgpICYmIHRoaXMtPmV4cHJfLT50eXBlKCktPmlzX3N0cmluZ190eXBl KCkpCisgICAgcmV0dXJuIHRoaXMtPmV4cHJfLT5zdHJpbmdfY29uc3RhbnRfdmFsdWUodmFsKTsK KwogICBpZiAodGhpcy0+dHlwZV8tPmlzX3N0cmluZ190eXBlKCkKICAgICAgICYmIHRoaXMtPmV4 cHJfLT50eXBlKCktPmludGVnZXJfdHlwZSgpICE9IE5VTEwpCiAgICAgewo= --0000000000004c39d305eab518ce--