From: Ian Lance Taylor <iant@golang.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, gofrontend-dev@googlegroups.com
Subject: Re: libgo patch committed: Update to 1.11 release
Date: Wed, 03 Oct 2018 22:04:00 -0000 [thread overview]
Message-ID: <CAOyqgcWEYGoQ=Ei32c+72f6DJ6H0C70yGeSha0H656K8V8UiUA@mail.gmail.com> (raw)
In-Reply-To: <CAOyqgcUVj67GJqgENAX24vugw7z-2j3gwdzEE+3XYmQeJq+-gQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Mon, Oct 1, 2018 at 5:06 PM, Ian Lance Taylor <iant@golang.org> wrote:
> On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> Compared with my patch, there are some new failures:
>
> Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp
> to set goarch to amd64p32 when appropriate.
This is that patch. I figured out how to run x32 binaries on my
system. With this patch, everything passes except some code using
getpwuid_r, which also fails in plain C so I'm not going to worry
about it. That said, I do not see some of the failures you mentioned.
In any case, this patch does pass bootstrap and testing on
x86_64-pc-linux-gnu both with and without -mx32. Committed to
mainline.
Ian
2018-10-03 Ian Lance Taylor <iant@google.com>
* go.test/go-test.exp (go-set-goarch): Use amd64p32 on x32.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 390 bytes --]
Index: go.test/go-test.exp
===================================================================
--- go.test/go-test.exp (revision 264816)
+++ go.test/go-test.exp (working copy)
@@ -203,6 +203,8 @@
"x86_64-*-*" {
if [check_effective_target_ia32] {
set goarch "386"
+ } elseif [check_effective_target_x32] {
+ set goarch "amd64p32"
} else {
set goarch "amd64"
}
next prev parent reply other threads:[~2018-10-03 21:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:49 Ian Lance Taylor
2018-09-25 7:06 ` Andreas Schwab
2018-09-25 7:57 ` Andreas Schwab
2018-09-25 9:05 ` Andreas Schwab
2018-09-25 14:39 ` Ian Lance Taylor
2018-09-25 13:10 ` Rainer Orth
2018-09-25 13:34 ` Rainer Orth
2018-09-26 5:04 ` Ian Lance Taylor
2018-09-26 8:55 ` Rainer Orth
2018-09-26 7:57 ` Andreas Schwab
2018-09-26 8:59 ` Rainer Orth
2018-09-26 12:54 ` Ian Lance Taylor
2018-09-26 11:12 ` Andreas Schwab
2018-09-26 12:49 ` Ian Lance Taylor
2018-10-01 20:18 ` Ian Lance Taylor
2018-09-26 14:52 ` H.J. Lu
2018-09-26 15:16 ` H.J. Lu
2018-10-01 20:28 ` Ian Lance Taylor
2018-10-01 20:59 ` H.J. Lu
2018-10-02 0:06 ` H.J. Lu
2018-10-02 0:59 ` Ian Lance Taylor
2018-10-02 2:37 ` H.J. Lu
2018-10-02 4:09 ` Ian Lance Taylor
2018-10-03 14:09 ` H.J. Lu
2018-10-03 22:04 ` Ian Lance Taylor [this message]
2018-09-28 14:28 ` Rainer Orth
2018-10-02 17:13 ` Ian Lance Taylor
2018-10-04 12:05 ` Rainer Orth
2018-09-26 7:58 Uros Bizjak
2018-09-26 15:22 ` Ian Lance Taylor
2018-09-27 20:26 ` Uros Bizjak
2018-09-28 7:13 ` Uros Bizjak
2018-10-02 15:13 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcWEYGoQ=Ei32c+72f6DJ6H0C70yGeSha0H656K8V8UiUA@mail.gmail.com' \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).