From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 187673858403 for ; Sat, 30 Jul 2022 17:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 187673858403 Received: by mail-pj1-x1029.google.com with SMTP id o5-20020a17090a3d4500b001ef76490983so8064193pjf.2 for ; Sat, 30 Jul 2022 10:35:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=7HjaGRwWM+Sad+8kZ+NEuBnba3t3B8U/NoMjJApf6BQ=; b=kkf2o+iA+n64C+RS7Vw05OcklZuusiyyf0flLYNeS/JDHH60ai3YaGI9eqzWdDKPMc SG4SjEQC8IdFCtK+RsknhenIpLZ9N8GoEovdf1wMfJ2Bg8PQjhpdTquMPh1fa0uE9a85 Ad8Igw3toOoSD5Tz5qh22JERs0NTfrntFZzASdbHJlQzzbD/9bxv6fV4oeFy+8X/JOgN 6Nra5bNBvnxEQJQV+XLqLXN1NPd3Wa8+tz1wmPyFXN//0QjxJ7ij61Y/xjH0dJYFsOFs LLtljanvBbYL1C7j13QlKYs/5U/NEWSt6vkl2UnSBFMmAlKgsnsmMt2g1isJlYQXTw2g conQ== X-Gm-Message-State: ACgBeo02/OBImzQZmyxJaiKdzD6aeHpAQHKr72MJVPGeV5cNVKN9Qbyg Lwz9RCdD71IrFBJkS3Af2Yuo+rfbSDfKI9V7ROnW8g== X-Google-Smtp-Source: AA6agR6VcepKY+JExLMh4oqr5Ji20JMuD5LmNqmhjTkxdX6OtnM/oanG504qzDoOHYTfiWWSZORIhwtV7DsqvxeqjXQ= X-Received: by 2002:a17:903:260b:b0:16e:d654:6c41 with SMTP id jd11-20020a170903260b00b0016ed6546c41mr1959578plb.29.1659202550807; Sat, 30 Jul 2022 10:35:50 -0700 (PDT) MIME-Version: 1.0 References: <20220728181422.6959-1-soeren@soeren-tempel.net> In-Reply-To: <20220728181422.6959-1-soeren@soeren-tempel.net> From: Ian Lance Taylor Date: Sat, 30 Jul 2022 10:35:39 -0700 Message-ID: Subject: Re: [PATCH] libgo: Explicitly define SYS_timer_settime for 32-bit musl targets To: soeren@soeren-tempel.net Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="000000000000a6f36705e50932e1" X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jul 2022 17:35:53 -0000 --000000000000a6f36705e50932e1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2022 at 11:15 AM wrote: > > From: S=C3=B6ren Tempel > > On 32-bit systems, musl only defines SYS_timer_settime32 not > SYS_timer_settime. This causes the following compilation error: > > os_linux.go:251:30: error: reference to undefined name '_SYS_= timer_settime' > 251 | return int32(syscall(_SYS_timer_settime, uint= ptr(timerid), uintptr(flags), uintptr(unsafe.Pointer(new)), uintptr(unsafe.= Pointer(old)), 0, 0)) > | ^ > > This commit fixes this error by "aliasing" SYS_timer_settime to > SYS_timer_settime32 if the latter is defined. This is also what > musl does internally [1]. Committed a slight variant of this, as appended. Ian --000000000000a6f36705e50932e1 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l686cfie0 ZjQwNjg2YjAxYmRhYmJhMDUxZTNiMjIxNjViYjU3NmU0NWZmY2E3NApkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCAyZjJm YWZkZTFmMS4uY2E3OTcwNDVkNjYgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotYTYyZjIwYWU3 OGRkZDQxYmU2ODJkZGU4Y2FiMDc1Y2E0ZjVkYmIyYQorZDUzZThhMGU5NGUzNGRjNjA5ZTM0ZGQ1 ZTQwNGRlYmRhMjY0MGNmYgogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vc3lzaW5mby5jIGIvbGliZ28v c3lzaW5mby5jCmluZGV4IGZjMDIxMDk5MmZhLi4xODBmNWMzMWQ3NCAxMDA2NDQKLS0tIGEvbGli Z28vc3lzaW5mby5jCisrKyBiL2xpYmdvL3N5c2luZm8uYwpAQCAtMzU0LDYgKzM1NCwxMSBAQCBl bnVtIHsKIH07CiAjZW5kaWYKIAorI2lmICFkZWZpbmVkKFNZU190aW1lcl9zZXR0aW1lKSAmJiBk ZWZpbmVkKFNZU190aW1lcl9zZXR0aW1lMzIpCisvLyBtdXNsIGRlZmluZXMgU1lTX3RpbWVyX3Nl dHRpbTMyIG9uIDMyLWJpdCBzeXN0ZW1zLgorI2RlZmluZSBTWVNfdGltZXJfc2V0dGltZSBTWVNf dGltZXJfc2V0dGltZTMyCisjZW5kaWYKKwogI2lmIGRlZmluZWQoSEFWRV9MT0ZGX1QpCiAvLyBs b2ZmX3QgY2FuIGJlIGRlZmluZWQgYXMgYSBtYWNybzsgZm9yIC1mZ28tZHVtcC1zcGVjIG1ha2Ug c3VyZSB3ZQogLy8gc2VlIGEgdHlwZWRlZi4K --000000000000a6f36705e50932e1--