From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8757 invoked by alias); 27 Jun 2017 21:51:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8737 invoked by uid 89); 27 Jun 2017 21:51:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1226 X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 21:51:56 +0000 Received: by mail-oi0-f49.google.com with SMTP id c189so28079741oia.2 for ; Tue, 27 Jun 2017 14:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KrDe9/whoa7J0DxQcA2LCX5NFPW89gtuQXjk48RKiYY=; b=dnQJ2Wyu3tvjRTU7hLRcd0CMoiYKf6OihviwlHDFhdMvnm5utqlrGYulx/NFNtLNvN 7ZhmoJ+UynasUifoDjzHTRrypxMTq6+nLEvrPcVmWCLhZ2iaP7Go5OMH67aMJ8Als8iY iLqMiTx/6oBdzx+sDBuL1dEnV7GgzXhgG0vt96hgRobNLuneTIrviZw1qJMLCwJuBH3H tq64d+Ulm0XKtJgxYq5W2e6QiqK6ymk778SGVbo1Yx7vvRlT6dNMnQi7NJ82TpSSjfYQ asvnHrF2p+IEbaZXQpKgfzIv+G6ETLNL9mWZLi2v/kv5BL+pziRCFUZtivJE97H/43kz PXkw== X-Gm-Message-State: AKS2vOws8wRM5FvTAAMWhZoyS+uQ6+RqojZQdrHscrEbGNE3Pnb5QBf9 esIOHh6AfJl8AQCtzn6uGAxSGhfyd1l8 X-Received: by 10.202.72.202 with SMTP id v193mr4216253oia.83.1498600314759; Tue, 27 Jun 2017 14:51:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.189.11 with HTTP; Tue, 27 Jun 2017 14:51:54 -0700 (PDT) In-Reply-To: <0f1319c4-e896-ae22-3a5d-c563a5292d8c@linux.vnet.ibm.com> References: <0f1319c4-e896-ae22-3a5d-c563a5292d8c@linux.vnet.ibm.com> From: Ian Lance Taylor Date: Tue, 27 Jun 2017 21:51:00 -0000 Message-ID: Subject: Re: [gofrontend-dev] [PATCH, go]: S/390: Fix generation of PtraceRegs To: Andreas Krebbel Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg02094.txt.bz2 On Tue, Jun 27, 2017 at 12:52 AM, Andreas Krebbel wrote: > > go bootstrap fails on s390x starting with r249472. With including the ptrace header the s390 special > code in mksysinfo.sh isn't used anymore: > > if test "$regs" = ""; then > # s390 > regs=`grep '^type __user_regs_struct struct' gen-sysinfo.go || true` > if test "$regs" != ""; then > # Substructures of __user_regs_struct on s390 > upcase_fields "__user_psw_struct" "PtracePsw" >> ${OUT} || true > upcase_fields "__user_fpregs_struct" "PtraceFpregs" >> ${OUT} || true > upcase_fields "__user_per_struct" "PtracePer" >> ${OUT} || true > fi > fi > > Instead we fall through to the code with the generic handling which appears to work fine. The only > difference is that the former code used to uppercase the initial letters of the struct member while > the generic handler doesn't. The only user however appear to be syscall_linux_s390(x).go. > > The attached patch removes the mksysino.sh S/390 specific handling and adjusts the > syscall_linux_s390* file accordingly. > > This fixes the bootstrap on s390x. Thanks for sending this. Committed to mainline. Ian