From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id ACF653858C83 for ; Wed, 15 Mar 2023 21:57:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACF653858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pj1-x1029.google.com with SMTP id j3-20020a17090adc8300b0023d09aea4a6so3359803pjv.5 for ; Wed, 15 Mar 2023 14:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; t=1678917478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cJHIaUkDysp00hy/HjBs150UREv6uBhpShqzZXJHsZw=; b=WQ/rvMOMwAZyLUW8iTXhEXB8XLuFL/RzVS9bMgvZ6DqL3fvf5fIHwASbFL7v+r8kiY g8wyxJqaIEJvAe1UAAuK7Tql6080tcEBBa0OUzzRlonsxYSq+hWCkcdN7SPgned0BeJh K84EUBOVsdW0XsJv/QZeq7kyLAfwjdprngANtSviDrWr0xvBOIQjpm6ml8hXFtTJe6bV eAmwIk+2CeofeYODhwDcHxYDM5Z9BkgqdNBueWhuys1fAU0XiY933Ve19fuZThHxXwCT BeMU5pS2Y5lFN5aKHvvujUE+/XHBb349Yo6d4HgL8HceQu7bx3U3oqQdVk6Y5BcS2x9d oGKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678917478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cJHIaUkDysp00hy/HjBs150UREv6uBhpShqzZXJHsZw=; b=RIyhlgCM4Ma5O0en9kyDmUrxyEdEePqWCOhlJMHb93DnUr1gioPdQqbEHq4X9yncMn KlejOFGyXSAOHxNTubxC+B8V78aqfWh00VrEYB57kUniqxM6uGXCGX4PeeNHvDOGG6+b bSvmh9NbDuagB9yS75/iPHQFLhA3DmNNHsW7u0xCm+U4RLDZavYKN1zS3SvXZR4J1+Wq HQrWgxkwducr5zD8W67ktk2dz4RpNxJvPDLzZIOo4OOkXtRrjitLOpw+0/WsEgggcXPi EJJ0tepJ621RtHd96Y0rvJrU8dF6MoFDo9aDKvhTE3j+oTk42kC/Qaz7QV0yuaySGtPD Ntzg== X-Gm-Message-State: AO0yUKUMb0R3vo7yP7IVA6rsv8RS+7LxQZaM+pCNWANSyacJIUfWjDSp Hz8Q3NTqTYJlUCCgI282MeKi2A21DTgKTHDVvURAPw== X-Google-Smtp-Source: AK7set9qCBAx/n9DDv1NnomOo7/c2CDPkj2Qtic9scEQj/P8GttlKgvi64Y5oVRGhU8vDi2RvOy9Iuuu5aWdxhDLKVs= X-Received: by 2002:a17:90b:34e:b0:237:9ca5:4d5d with SMTP id fh14-20020a17090b034e00b002379ca54d5dmr444548pjb.6.1678917478530; Wed, 15 Mar 2023 14:57:58 -0700 (PDT) MIME-Version: 1.0 References: <952ba6f7c288d4198f99437672278473d5bb88f7.camel@gmail.com> In-Reply-To: <952ba6f7c288d4198f99437672278473d5bb88f7.camel@gmail.com> From: Ian Lance Taylor Date: Wed, 15 Mar 2023 14:57:47 -0700 Message-ID: Subject: Re: Now gcc-13: [Fwd: [PATCH] gcc-12: Re-enable split-stack support for GNU/Hurd.] To: svante.signell@gmail.com, thomas@schwinge.name Cc: gcc-patches , Debian Bug Tracking System , Matthias Klose Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 15, 2023 at 9:14=E2=80=AFAM Svante Signell wrote: > > Package: gcc-snapshot > Version: 1:20230315-1 > Severity: important > Tags: patch > User: debian-hurd@lists.debian.org > Usertags: hurd > Affects: gcc-snapshot > X-Debbugs-CC: debian-hurd@lists.debian.org > > Hello, seems like the patch gcc_config_gnu.h.diff, in debian gcc-12 named= : > pr104290-followup.diff was lost (again). > > How can this patch ever become upstreamed?? > > It seems like sending to gcc-patches is not enough. Create a regression b= ug? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104290 is already reported= as a > regression, it has to be updated to cover upstream releases of gcc-13 now= . > > For gcc-12 Debian has been carrying it as: > pr104290-followup.diff > > Submitting this problem as new bug to Debian/gcc-13/gcc-snapshot! > > Thanks! > > > > ---------- Forwarded message ---------- > From: Svante Signell > To: gcc-patches > Cc: Ian Lance Taylor , Matthias Klose > Bcc: > Date: Wed, 23 Feb 2022 11:13:50 +0100 > Subject: [PATCH] gcc-12: Re-enable split-stack support for GNU/Hurd. > Hello, > > In line of porting the latest build of libgo/go with gcc-12 to GNU/Hurd, = support > of split-stack was found to be removed. > > After patching the files in libgo the build of gotools fails: > go1: error: '-fsplit-stack' currently only supported on GNU/Linux > go1: error: '-fsplit-stack' is not supported by this compiler configurati= on > > The attached patch defines OPTION_GLIBC_P(opts) and OPTION_GLIBC that was= lost > in config/gnu.h, needed to enable split-stack support for GNU/Hurd. > > This problem happened with the latest commit as discussed in the mail thr= ead > starting with https://gcc.gnu.org/pipermail/gcc-patches/2022-January/5889= 73.html > . > > The file first doing this check is: (first error: ..) > src/gcc/common/config/i386/i386-common.cc > in function: > static bool ix86_supports_split_stack (bool report, > struct gcc_options *opts ATTRIBUTE_UNUSED) > > and secondly in:src/gcc/opts.cc: (second error: ...) > in function: > void > finish_options (struct gcc_options *opts, struct gcc_options *opts_set, > location_t loc) > > The checking logic is in function ix86_supports_split_stack(): > #if defined(TARGET_THREAD_SPLIT_STACK_OFFSET) && defined(OPTION_GLIBC_P) > if (!OPTION_GLIBC_P (opts)) > #endif > { > if (report) > error ("%<-fsplit-stack%> currently only supported on GNU/Linux")= ; > return false; > } > > bool ret =3D true; > > In case of GNU/Hurd TARGET_THREAD_SPLIT_STACK_OFFSET is defined as well a= s > OPTION_GLIBC_P but OPTION_GLIBC_P(opts) is needed to. The attached patch = to > src/gcc/config/gnu.h creates that definition. For GNU/Hurd, gnu.h is incl= uded in > the configure stage: > Configuring stage 1 in ./gcc > ... > Using the following target machine macro files: > ... > ../../src/gcc/config/gnu.h > > For a longer history about this bug see: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104290 > > Additionally, I would propose the text in gcc/common/config/i386/i386-com= mon.cc > to change from: > error ("%<-fsplit-stack%> currently only supported on GNU/Linux"); > to: > error ("%<-fsplit-stack%> currently only supported on GLIBC-based systems= "); If GNU/Hurd requires glibc, then I think it would be simpler to define OPTION_GLIBC and OPTION_GLIBC_P as true. Adding Thomas Schwinge as the GNU/Hurd maintainer. Ian