From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id A7F4C3858D1E for ; Wed, 30 Nov 2022 20:22:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7F4C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pf1-x42a.google.com with SMTP id q12so13806156pfn.10 for ; Wed, 30 Nov 2022 12:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hvVonD75E6dnvcBW5wEaw8omhGCbZZy+IXjuqGbvsQE=; b=JOaNq6DsfP02H4SXpNu9Ma5ZUr6QuNYX+uZCXX4OZabAqkkIAyGe29yefDJ9s8s926 6aG8HvQKL5nV4kxxYHVISmPMyp1NVcMM/GSP6+jzdK3RqgZD3/ffMcXeZHa16FxJNgwU UuEeKehRtGumYzuNBD1nSgKQbu8W9HfzYmqMGzJAk717WHgvwulC6totDJsHU8sigAdX tkNI+l0vL5znLEpkohyP+6j0lpnHgt4IX7DPsMkyWx2o7VifurQc0HnagXN8+zxeI1zs MdBWgHOyGLcujsNlxYT3UPnMrySvyXGPeibgUWePeVrQpQx36P4FnHmn7Tk0VugpVMKc qodA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hvVonD75E6dnvcBW5wEaw8omhGCbZZy+IXjuqGbvsQE=; b=fDDPotzvYuV5LJJozZk+vuqLGXy6aFr9MbRpACbSIx1hy4kQyDma9BU6MhaIizn2uG 3JEeeYA04RzW3fOkRx53XV8hmW5Q3GD11d241bnyHqgdwEf+wlL/eLWYdC+XGeeNBkW6 ozpH7eRCr0swrNZUpSXjBR6qemM5lccn9w8FnBMvRVSv/O6MPWRbt2kAuQM6ucKiFvPN lP4QZo4t3GsYlLFYHg0R1AA0Lwmlc2C+oiG0y24PBxX+zCIrq3ZaiuQXJkKLgb7JLX8L 1DDlVP4MbIf851xiWe/upJoFXR1HiqSLT7HrVQb4S0NNH59I4I3NID9BYZrjE5PFUABp URMw== X-Gm-Message-State: ANoB5plVZBhMUG/CT4koLpQLnsjv4R9IlkLTX9rPI811zETZ7n2EdUoF bwP33tUukx2EuCYHj2EhuoCrcD0/SR8rE/fPIPmsAw== X-Google-Smtp-Source: AA0mqf7FGRR35RvnmpADrmX2fADaw0C3j0/pMnQA5OyhpO3JT1996ug/lRd0WR2I64k5KKC5J0Uzx8Fv14Na8eYTgGA= X-Received: by 2002:a63:5517:0:b0:42f:e191:2d35 with SMTP id j23-20020a635517000000b0042fe1912d35mr56817586pgb.1.1669839722504; Wed, 30 Nov 2022 12:22:02 -0800 (PST) MIME-Version: 1.0 References: <20221129174331.3124-1-soeren@soeren-tempel.net> <20221129175453.3644-1-soeren@soeren-tempel.net> In-Reply-To: From: Ian Lance Taylor Date: Wed, 30 Nov 2022 12:21:51 -0800 Message-ID: Subject: Re: [PATCH v2] libgo: Don't rely on GNU-specific strerror_r variant on Linux To: soeren@soeren-tempel.net Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="000000000000809e1705eeb5db6e" X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000809e1705eeb5db6e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 29, 2022 at 4:10 PM Ian Lance Taylor wrote: > > On Tue, Nov 29, 2022 at 9:54 AM wrote: > > > > From: S=C3=B6ren Tempel > > > > On glibc, there are two versions of strerror_r: An XSI-compliant and a > > GNU-specific version. The latter is only available on glibc. In order > > to avoid duplicating the post-processing code of error messages, this > > commit provides a separate strerror_go symbol which always refers to th= e > > XSI-compliant version of strerror_r (even on glibc) by selectively > > undefining the corresponding feature test macro. > > > > Previously, gofrontend assumed that the GNU-specific version of > > strerror_r was always available on Linux (which isn't the case when > > using a musl as a libc, for example). This commit thereby improves > > compatibility with Linux systems that are not using glibc. > > > > Tested on x86_64 Alpine Linux Edge and Arch Linux (glibc 2.36). > > Thanks. I committed a version of this, as attached. I've committed this follow-on patch for Hurd. Ian --000000000000809e1705eeb5db6e Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lb43g4wm0 OTE2MDdlYmE4ZmU0OWMwNjQxOTIxMjJlYzYwYTNlMDNkZDhmMjUxNQpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCA5ODRk ODMyNDAwNC4uYTI2Zjc3OTU1N2QgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotZmVmNmFhM2Mx Njc4Y2RiZTdkY2E0NTRiMmNlYmIzNjlkOGJhODFiZgorMWM1YmZkNTcxMzFiNjhiOTFkODQwMGJi MDE3ZjM1ZDQxNmY3YWE3YgogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vcnVudGltZS9nby1zdHJlcnJv ci5jIGIvbGliZ28vcnVudGltZS9nby1zdHJlcnJvci5jCmluZGV4IDEzZDFkOTFkZjg0Li44ZmY1 ZmZiZGZlYyAxMDA2NDQKLS0tIGEvbGliZ28vcnVudGltZS9nby1zdHJlcnJvci5jCisrKyBiL2xp YmdvL3J1bnRpbWUvZ28tc3RyZXJyb3IuYwpAQCAtMTIsNyArMTIsNyBAQAogICAgZXhpc3RzIHRv IHNlbGVjdGl2ZWx5IHVuZGVmaW5lIGl0IGFuZCBwcm92aWRlcyBhbiBhbGlhcyB0byB0aGUKICAg IFhTSS1jb21wbGlhbnQgdmVyc2lvbiBvZiBzdHJlcnJvcl9yKDMpLiAgKi8KIAotI2lmZGVmIF9f bGludXhfXworI2lmIGRlZmluZWQoX19saW51eF9fKSB8fCBkZWZpbmVkKF9fZ251X2h1cmRfXykK IAogLyogRm9yY2Ugc2VsZWN0aW9uIG9mIFhTSS1jb21wbGlhbnQgc3RyZXJyb3JfciBieSBnbGli Yy4gICovCiAjdW5kZWYgWE9QRU5fU09VUkNFCkBAIC0yMSw3ICsyMSw3IEBACiAjZGVmaW5lIF9Q T1NJWF9DX1NPVVJDRSAyMDAxMTJMCiAjdW5kZWYgX0dOVV9TT1VSQ0UKIAotI2VuZGlmIC8qIF9f bGludXhfXyAqLworI2VuZGlmIC8qIGRlZmluZWQoX19saW51eF9fKSB8fCBkZWZpbmVkKF9fZ251 X2h1cmRfXykgKi8KIAogI2luY2x1ZGUgPHN0cmluZy5oPgogCg== --000000000000809e1705eeb5db6e--