From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 3E6393858421 for ; Wed, 21 Dec 2022 03:35:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E6393858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pg1-x530.google.com with SMTP id 82so9650523pgc.0 for ; Tue, 20 Dec 2022 19:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0/7VL9dXC6LESu83XBvWAIBS7+4EQD3qzhjSm6vwxao=; b=p8Ga0cqPJO1tXilgDrIZIfwLYzxwVSc6Cqg4fXsiyVOuMIP+c3zVBWW/i4aJVGamT+ kfPKvp3hdh7Nq+4ANqYSq32p1IPXFv2okZZhJeFoLtUXbFHIgjR2neDtDAkVFTACJ+nD 0DO4t1vCkoMWYiGRI/OnxtK+lTVF0WmUvtQ+8HVzpgaUGQEhG7poUB5XlbYAkFFdA4Q4 QIOcp8a2OUbl0EXvVTGVUeezP7Qo1IgvjlTKh8V1K/kvCNozh0bV8zaFaoerXkA6TGLa Omw68Q1hJJPN/J1CNWYvJx/ktETZTZoEFreDDs25IhOtZtxg3WC3XmmSd3Bm52Ws50wv OSgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0/7VL9dXC6LESu83XBvWAIBS7+4EQD3qzhjSm6vwxao=; b=Uho5q924b8tZc09U23w2vNJHnTjTGG6ThPN570kusyCmBGQz492z/6fpJenCKMxBX9 Mujv6XGca5VKHG/ZMRBHO1PQ8bE/nZwAePxvwMprtTark1hJfUEqah463p+hlPPpz4Zp adpJZ0l8h46cFXWI4DbikYhNzdqZIQDEsWGBIuOfBTrkXzo5OL0tNoc6X/kGK+JtlK9k is2CNgl7+jT6QdLZROvxNxvAnMxy5DK0cfXIo6T2Q+Odw54tPVEgNHwsPrWUPZGHxRJZ i5Fi6XeN18IlNvF/14Sx7CT+1pSFWgqg5dicdVo8eyJD1TSS0O5//TNOrPl+4q2lNgNM t+XA== X-Gm-Message-State: ANoB5pmT64Ml63U5LzXMcYCWDoGudIwEsbeW9WpaNoy9ni2WOe9OWXpO tHl8vs/26x4c+5t6ZuWI4rQAifeiSLkn6PRjQZBw3rz6mzIm3A== X-Google-Smtp-Source: AA0mqf7LTYBxMMjfQgskkRlAiTiaGTHXm+o/uCovquFPGzXYTreeD9Vc58TcKVl6NrFE2tNlk/qUexbsocfpU2J6O1M= X-Received: by 2002:a63:1c22:0:b0:478:c543:89d3 with SMTP id c34-20020a631c22000000b00478c54389d3mr16806198pgc.184.1671593718921; Tue, 20 Dec 2022 19:35:18 -0800 (PST) MIME-Version: 1.0 References: <20221219165922.25443-1-soeren@soeren-tempel.net> In-Reply-To: <20221219165922.25443-1-soeren@soeren-tempel.net> From: Ian Lance Taylor Date: Tue, 20 Dec 2022 19:35:07 -0800 Message-ID: Subject: Re: [PATCH] libgo: check if -lucontext is required for {make,set,get}context To: soeren@soeren-tempel.net Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="000000000000d3ae1305f04e3d67" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d3ae1305f04e3d67 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 19, 2022 at 8:59 AM wrote: > > From: S=C3=B6ren Tempel > > This patch is similar to the existing check for librt. If libucontext > is installed and libucontext.a provides the aforementioned symbols, then > it is added to $LIBS. If not, no error is emitted. We could, > alternatively, also check libc.a for these symbols and thus prefer libc > over libucontext if both are installed and provide the symbols. If > deemed desirable, this could be achieved by changing the invocation > to AC_SEARCH_LIBS([makecontext], [c ucontext]). > > This version of this patch has been tested on x86_64 Alpine Linux Edge > (libucontext 1.2 + musl 1.2.3) and Arch Linux (glibc 2.36). On the > latter, the check is a no-op and $LIBS is not modified. Thanks. I don't see a reason to check for all the functions. Committed like so after testing on x86_64-pc-linux-gnu with glibc. Ian --000000000000d3ae1305f04e3d67 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbx3q7250 ZTFlODEwZTJmMWQ0ZjZjNDUwMjE3NDFjYjNmOGQ3ZjJiZTE1OTI2ZApkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCBkOGM0 ZTAyZDZlNi4uZDEyM2M3NDZmYjIgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotOTkwNjg2MWRj ODZjMTczM2JiMzA0ZDNkNDViMTUzNGFkYjMyNzEyYworZWNjMmEyZTcwZTQ0ZmE3NmE3NWIxMmQw ODkzYmMxNzAyYjcyYTFiNAogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vY29uZmlndXJlIGIvbGliZ28v Y29uZmlndXJlCmluZGV4IDQ2MGZkYWQ3MGE4Li5hNjA3ZGJmZjY4ZSAxMDA3NTUKLS0tIGEvbGli Z28vY29uZmlndXJlCisrKyBiL2xpYmdvL2NvbmZpZ3VyZQpAQCAtMTQ4MTgsNiArMTQ4MTgsNjMg QEAgZmkKIAogCiAKK3sgJGFzX2VjaG8gIiRhc19tZToke2FzX2xpbmVuby0kTElORU5PfTogY2hl Y2tpbmcgZm9yIGxpYnJhcnkgY29udGFpbmluZyBtYWtlY29udGV4dCIgPiY1CiskYXNfZWNob19u ICJjaGVja2luZyBmb3IgbGlicmFyeSBjb250YWluaW5nIG1ha2Vjb250ZXh0Li4uICIgPiY2OyB9 CitpZiAke2FjX2N2X3NlYXJjaF9tYWtlY29udGV4dCs6fSBmYWxzZTsgdGhlbiA6CisgICRhc19l Y2hvX24gIihjYWNoZWQpICIgPiY2CitlbHNlCisgIGFjX2Z1bmNfc2VhcmNoX3NhdmVfTElCUz0k TElCUworY2F0IGNvbmZkZWZzLmggLSA8PF9BQ0VPRiA+Y29uZnRlc3QuJGFjX2V4dAorLyogZW5k IGNvbmZkZWZzLmguICAqLworCisvKiBPdmVycmlkZSBhbnkgR0NDIGludGVybmFsIHByb3RvdHlw ZSB0byBhdm9pZCBhbiBlcnJvci4KKyAgIFVzZSBjaGFyIGJlY2F1c2UgaW50IG1pZ2h0IG1hdGNo IHRoZSByZXR1cm4gdHlwZSBvZiBhIEdDQworICAgYnVpbHRpbiBhbmQgdGhlbiBpdHMgYXJndW1l bnQgcHJvdG90eXBlIHdvdWxkIHN0aWxsIGFwcGx5LiAgKi8KKyNpZmRlZiBfX2NwbHVzcGx1cwor ZXh0ZXJuICJDIgorI2VuZGlmCitjaGFyIG1ha2Vjb250ZXh0ICgpOworaW50CittYWluICgpCit7 CityZXR1cm4gbWFrZWNvbnRleHQgKCk7CisgIDsKKyAgcmV0dXJuIDA7Cit9CitfQUNFT0YKK2Zv ciBhY19saWIgaW4gJycgdWNvbnRleHQ7IGRvCisgIGlmIHRlc3QgLXogIiRhY19saWIiOyB0aGVu CisgICAgYWNfcmVzPSJub25lIHJlcXVpcmVkIgorICBlbHNlCisgICAgYWNfcmVzPS1sJGFjX2xp YgorICAgIExJQlM9Ii1sJGFjX2xpYiAgJGFjX2Z1bmNfc2VhcmNoX3NhdmVfTElCUyIKKyAgZmkK KyAgaWYgYWNfZm5fY190cnlfbGluayAiJExJTkVOTyI7IHRoZW4gOgorICBhY19jdl9zZWFyY2hf bWFrZWNvbnRleHQ9JGFjX3JlcworZmkKK3JtIC1mIGNvcmUgY29uZnRlc3QuZXJyIGNvbmZ0ZXN0 LiRhY19vYmpleHQgXAorICAgIGNvbmZ0ZXN0JGFjX2V4ZWV4dAorICBpZiAke2FjX2N2X3NlYXJj aF9tYWtlY29udGV4dCs6fSBmYWxzZTsgdGhlbiA6CisgIGJyZWFrCitmaQorZG9uZQoraWYgJHth Y19jdl9zZWFyY2hfbWFrZWNvbnRleHQrOn0gZmFsc2U7IHRoZW4gOgorCitlbHNlCisgIGFjX2N2 X3NlYXJjaF9tYWtlY29udGV4dD1ubworZmkKK3JtIGNvbmZ0ZXN0LiRhY19leHQKK0xJQlM9JGFj X2Z1bmNfc2VhcmNoX3NhdmVfTElCUworZmkKK3sgJGFzX2VjaG8gIiRhc19tZToke2FzX2xpbmVu by0kTElORU5PfTogcmVzdWx0OiAkYWNfY3Zfc2VhcmNoX21ha2Vjb250ZXh0IiA+JjUKKyRhc19l Y2hvICIkYWNfY3Zfc2VhcmNoX21ha2Vjb250ZXh0IiA+JjY7IH0KK2FjX3Jlcz0kYWNfY3Zfc2Vh cmNoX21ha2Vjb250ZXh0CitpZiB0ZXN0ICIkYWNfcmVzIiAhPSBubzsgdGhlbiA6CisgIHRlc3Qg IiRhY19yZXMiID0gIm5vbmUgcmVxdWlyZWQiIHx8IExJQlM9IiRhY19yZXMgJExJQlMiCisKK2Zp CisKKwogeyAkYXNfZWNobyAiJGFzX21lOiR7YXNfbGluZW5vLSRMSU5FTk99OiBjaGVja2luZyBm b3IgbGlicmFyeSBjb250YWluaW5nIHNjaGVkX3lpZWxkIiA+JjUKICRhc19lY2hvX24gImNoZWNr aW5nIGZvciBsaWJyYXJ5IGNvbnRhaW5pbmcgc2NoZWRfeWllbGQuLi4gIiA+JjY7IH0KIGlmICR7 YWNfY3Zfc2VhcmNoX3NjaGVkX3lpZWxkKzp9IGZhbHNlOyB0aGVuIDoKZGlmZiAtLWdpdCBhL2xp YmdvL2NvbmZpZ3VyZS5hYyBiL2xpYmdvL2NvbmZpZ3VyZS5hYwppbmRleCAwOTU1NGEzN2EyMy4u YTU5YWEwOTFkMWQgMTAwNjQ0Ci0tLSBhL2xpYmdvL2NvbmZpZ3VyZS5hYworKysgYi9saWJnby9j b25maWd1cmUuYWMKQEAgLTU3MCw2ICs1NzAsOSBAQCBQVEhSRUFEX0xJQlM9CiBBQ19DSEVDS19M SUIoW3B0aHJlYWRdLCBbcHRocmVhZF9jcmVhdGVdLCBQVEhSRUFEX0xJQlM9LWxwdGhyZWFkKQog QUNfU1VCU1QoUFRIUkVBRF9MSUJTKQogCitkbmwgVGVzdCBpZiAtbHVjb250ZXh0IGlzIHJlcXVp cmVkIGZvciBtYWtlY29udGV4dC4KK0FDX1NFQVJDSF9MSUJTKFttYWtlY29udGV4dF0sIFt1Y29u dGV4dF0pCisKIGRubCBUZXN0IGlmIC1scnQgaXMgcmVxdWlyZWQgZm9yIHNjaGVkX3lpZWxkIG9y IG5hbm9zbGVlcCBvciBjbG9ja19nZXR0aW1lLgogQUNfU0VBUkNIX0xJQlMoW3NjaGVkX3lpZWxk XSwgW3J0XSkKIEFDX1NFQVJDSF9MSUJTKFtuYW5vc2xlZXBdLCBbcnRdKQo= --000000000000d3ae1305f04e3d67--