From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20827 invoked by alias); 2 Oct 2018 16:46:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20736 invoked by uid 89); 2 Oct 2018 16:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=vol, Rainer, rainer, Orth X-HELO: mail-lf1-f41.google.com Received: from mail-lf1-f41.google.com (HELO mail-lf1-f41.google.com) (209.85.167.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Oct 2018 16:45:59 +0000 Received: by mail-lf1-f41.google.com with SMTP id a82-v6so1946052lfa.4 for ; Tue, 02 Oct 2018 09:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TeaGafV0xtutQTVRvWqg4QL6VDyMB7b+fj/xo3eHFpM=; b=PGWvtuCWqW53sAjtlySojkTi7zj7uJhXP5tk9bEx/MJnP5iaaZvwgadKMDTG25iZC9 QK9cpdLyWl0d6Ax1zvMzjv4SaBknno29xGCpZ7iOaiUYxz6YK/aNmAGZ5QmYQT1BDol4 Dg/Ls6cGT9INLusHefi5DKwW5oO7VPwD+oYJ3U2amcwb7mq2QV7N5Ty5kiAT/0lK15Qy geYdOiPDO8tPyI8W9aCb8Jzxq87llpgBIrwFTxrVf+MwEomB+XM33kW+4is4p+5KTAFQ HauS9Y9soZ9WePiam2PXx06L7uEbdsDD7P6CaoTd315QJUjdDq9Zh6NVHTeqKl+DOS/r G2mA== MIME-Version: 1.0 Received: by 2002:ab3:5609:0:0:0:0:0 with HTTP; Tue, 2 Oct 2018 09:45:56 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Tue, 02 Oct 2018 17:13:00 -0000 Message-ID: Subject: Re: libgo patch committed: Update to 1.11 release To: Rainer Orth Cc: gcc-patches , gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="000000000000e87344057741a745" X-SW-Source: 2018-10/txt/msg00137.txt.bz2 --000000000000e87344057741a745 Content-Type: text/plain; charset="UTF-8" Content-length: 1839 On Fri, Sep 28, 2018 at 7:22 AM, Rainer Orth wrote: > >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more relevant directories. This >> update required some minor patches to the gotools directory and the Go >> testsuite, also included here. Bootstrapped and ran Go testsuite on >> x86_64-pc-linux-gnu. Committed to mainline. > > I just found another issue: unlike Solaris 11, Solaris 10 lacks memmem, > breaking the build: > > /vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c: In function 'Index': > /vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:96:6: error: implicit declaration of function 'memmem'; did you mean 'memset'? [-Werror=implicit-function-declaration] > 96 | p = memmem(a.__values, a.__count, b.__values, b.__count); > | ^~~~~~ > | memset > /vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:96:4: error: assignment to 'const byte *' {aka 'const unsigned char *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > 96 | p = memmem(a.__values, a.__count, b.__values, b.__count); > | ^ > /vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c: In function 'IndexString': > /vol/gcc/src/hg/trunk/local/libgo/go/internal/bytealg/bytealg.c:111:4: error: assignment to 'const byte *' {aka 'const unsigned char *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > 111 | p = memmem(a.str, a.len, b.str, b.len); > | ^ Thanks for the note. This patch should fix the problem. Bootstrapped and ran Go tests on x86_64-pc-linux-gnu, both normally and pretending that the system had no memmem. Committed to mainline. Ian --000000000000e87344057741a745 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jmryfny60 Content-length: 2705 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyNjQ3OTMpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTA5OGUzNmY0ZGRmY2Y1MGFlYjM0 NTA5YjVmMjViODZkNzA1MDc0OWMKK2JkZTVhYzkwZTBiNGVmZGYzZTlhNGQ3 MmFmNGViMjMyNTA2MDg2MTEKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGxpYmdvL2NvbmZpZ3VyZS5hYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBsaWJnby9jb25maWd1cmUuYWMJKHJldmlzaW9uIDI2NDc3MikK KysrIGxpYmdvL2NvbmZpZ3VyZS5hYwkod29ya2luZyBjb3B5KQpAQCAtNTQ0 LDcgKzU0NCw3IEBAIEFDX0NIRUNLX0hFQURFUlMoW2xpbnV4L2ZpbHRlci5o IGxpbnV4L2kKIAogQU1fQ09ORElUSU9OQUwoSEFWRV9TWVNfTU1BTl9ILCB0 ZXN0ICIkYWNfY3ZfaGVhZGVyX3N5c19tbWFuX2giID0geWVzKQogCi1BQ19D SEVDS19GVU5DUyhzdHJlcnJvcl9yIHN0cnNpZ25hbCB3YWl0NCBtaW5jb3Jl IHNldGVudiB1bnNldGVudiBkbF9pdGVyYXRlX3BoZHIpCitBQ19DSEVDS19G VU5DUyhzdHJlcnJvcl9yIHN0cnNpZ25hbCB3YWl0NCBtaW5jb3JlIHNldGVu diB1bnNldGVudiBkbF9pdGVyYXRlX3BoZHIgbWVtbWVtKQogQU1fQ09ORElU SU9OQUwoSEFWRV9TVFJFUlJPUl9SLCB0ZXN0ICIkYWNfY3ZfZnVuY19zdHJl cnJvcl9yIiA9IHllcykKIEFNX0NPTkRJVElPTkFMKEhBVkVfV0FJVDQsIHRl c3QgIiRhY19jdl9mdW5jX3dhaXQ0IiA9IHllcykKIApJbmRleDogbGliZ28v Z28vaW50ZXJuYWwvYnl0ZWFsZy9ieXRlYWxnLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gbGliZ28vZ28vaW50ZXJuYWwvYnl0ZWFsZy9ieXRlYWxn LmMJKHJldmlzaW9uIDI2NDY0OCkKKysrIGxpYmdvL2dvL2ludGVybmFsL2J5 dGVhbGcvYnl0ZWFsZy5jCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw2ICsxMCwz MyBAQAogI2luY2x1ZGUgInJ1bnRpbWUuaCIKICNpbmNsdWRlICJhcnJheS5o IgogCisjaWZuZGVmIEhBVkVfTUVNTUVNCisKKyNkZWZpbmUgbWVtbWVtIGdv TWVtbWVtCisKK3N0YXRpYyBjb25zdCB2b2lkICpnb01lbW1lbShjb25zdCB2 b2lkICppbiwgc2l6ZV90IGlubCwgY29uc3Qgdm9pZCAqcywgc2l6ZV90IHNs KSB7CisJY29uc3QgY2hhciAqcDsKKwljaGFyIGZpcnN0OworCWNvbnN0IGNo YXIgKnN0b3A7CisKKwlpZiAoc2wgPT0gMCkgeworCQlyZXR1cm4gaW47CisJ fQorCWlmIChpbmwgPCBzbCkgeworCQlyZXR1cm4gbmlsOworCX0KKwlmaXJz dCA9ICooY29uc3QgY2hhciAqKShzKTsKKwlzdG9wID0gKGNvbnN0IGNoYXIg KikoaW4pICsgKGlubCAtIHNsKTsKKwlmb3IgKHAgPSAoY29uc3QgY2hhciAq KShpbik7IHAgPD0gc3RvcDsgcCsrKSB7CisJCWlmICgqcCA9PSBmaXJzdCAm JiBfX2J1aWx0aW5fbWVtY21wKHAgKyAxLCAoY29uc3QgY2hhciAqKShzKSAr IDEsIHNsIC0gMSkgPT0gMCkgeworCQkJcmV0dXJuIChjb25zdCB2b2lkICop KHApOworCQl9CisJfQorCXJldHVybiBuaWw7Cit9CisKKyNlbmRpZgorCiBp bnRnbyBDb21wYXJlKHN0cnVjdCBfX2dvX29wZW5fYXJyYXksIHN0cnVjdCBf X2dvX29wZW5fYXJyYXkpCiAgIF9fYXNtX18oR09TWU1fUFJFRklYICJpbnRl cm5hbF9ieXRlYWxnLkNvbXBhcmUiKQogICBfX2F0dHJpYnV0ZV9fKChub19z cGxpdF9zdGFjaykpOwo= --000000000000e87344057741a745--