From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by sourceware.org (Postfix) with ESMTPS id 7F92B3858C50 for ; Thu, 30 May 2024 16:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F92B3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F92B3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717087961; cv=none; b=hNpGo1dYmXJF4iCB6DM27p+S4Uo4MVt4j8jgcgFtlE4lxmrk7PV9FsypZdqofgFm4OlFXWd3sF+coTeKatPK8Pzg4KMuBEYdnSqEHHvP/xacODhdDx6Gtu/JOkxM14mmr0Dgzxk8Kk0wztoVdh4A4fJnX4o2oC4HQP0a7ImWgnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717087961; c=relaxed/simple; bh=9acRA6qxYjGEGuNvzCTyAbkArR9Fm8zs2zaS2/t2x8s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Whx6lZBRYcVYFPYkTrMABSCJC8IrTnEMlZvec8iQC1yN2VwU3mATVdGgORZZROfdO1V0pE/OpoN056MMsO/hyOTyz7+huLZw9qPN4GeNeM45FphetRHb+fxFXAIx24A2l1Ryn2AC6ayQYaxvy5LS9M1jqRzUXW48camZcyX0fV0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-627f46fbe14so9840577b3.2 for ; Thu, 30 May 2024 09:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20230601.gappssmtp.com; s=20230601; t=1717087952; x=1717692752; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f/z19yFbBjWtl05x5bJcaw85cF5F/oLGAE3P+M1brjw=; b=rbcXh4kzDSLyG4NenERHSIH+CyctNvSJAfoRv/f523m6JYpKiGjpVcx71IqNDwAyk4 kR6BDEEBM25W3qUIQNUsUSr8bBSxr3S93wx/w5k5Zv1Zt6sONy4i1BrRnnTCFUVIkuYs wlEAxp5in563a7zWQ8r4/yFJjgUSMqbp7LyCBthQIT8A8i9hWzWjQycBaIlzbJy3QVVU aIVbHy+oXpAHur6oswK/DLCbIztMr5vraYrEkx6Sf6VkZYIIAy3y2usPfyZTJzx6JzRl fLyH0/PYtHW6oGOZhlEhapYJQ9dmIN8zdznpTFhEhc9jDEgTZQ+JMBcPJm5elARaLkqw xK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717087952; x=1717692752; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f/z19yFbBjWtl05x5bJcaw85cF5F/oLGAE3P+M1brjw=; b=ptsFaDujDDiBQLzjxhonE4l7OixibXoBbkVw+qv8lgXjgIDlOeHON6rkUXLK5JP1o+ g+VD+P2KcwmYMh9tQHR6Wq8EHvPOlWrlO4eTrcmfxMcajyZRIzev1/m9nNA0Ko2iwbpV v6lmmH4UV+eMbUJd8dwp0c533m7P2TaE/pEsqNvv3sr+8Tjnm/O0AvyfFVSAdmAr4ENL T7GDToMCnAbFSYXMTnzAATpgaoJVjOTOnusg0+CP3Ga2zOXLvg85k4cQyMMFuNNDA2b1 g4kff91U0+ptbWj/QODnfbfChpDhuaQEa3TfciVXjHgswSSIbyzoJOF8fxKrmkjTqnNg i+jQ== X-Gm-Message-State: AOJu0YxO8Z44F/zUGTgT8mQJmaU05vqbz9kMKq5WPsK1DyzPV0X2cqvE wanqdcSGJH2po1lbx8cgl+v+TM2c7qTi12+wzyKBWruEXupdCgHIgMyL4X3Bu+xkl127JdaegbU XypsxM1ytQKEr+etVc0xWtHvubnHzG++V1amnxA== X-Google-Smtp-Source: AGHT+IGtfeYXI2LQXZpAI7icxxHZq5GlbZ2ItO3B8XXNBk0Ym/kZpW3XhjhDff4NxerJ2PSPYfTYmxBS1xUKHleTYzE= X-Received: by 2002:a25:b1a4:0:b0:df7:8ba2:b776 with SMTP id 3f1490d57ef6-dfa5a693345mr2892959276.43.1717087952273; Thu, 30 May 2024 09:52:32 -0700 (PDT) MIME-Version: 1.0 References: <19e3b3b2380619067fd6f7cfa21588bb8a9fada1.camel@tugraz.at> <360e96dfe2b76eea91dc494431bcd57341e16c97.camel@tugraz.at> In-Reply-To: <360e96dfe2b76eea91dc494431bcd57341e16c97.camel@tugraz.at> From: Ian Lance Taylor Date: Thu, 30 May 2024 09:52:20 -0700 Message-ID: Subject: Re: [C PATCH, v2]: allow aliasing of compatible types derived from enumeral types [PR115157] To: Martin Uecker Cc: gcc-patches@gcc.gnu.org, Joseph Myers , Richard Biener , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 30, 2024 at 12:48=E2=80=AFAM Martin Uecker w= rote: > > > Hi Ian, > > can you give me a green light for the go changes. The C FE > changes were approved. > > The only change with respect to the last version are > the removal of the unneeded null check for the > main variant (as discussed) and that I also removed the > > container->decls_seen.add (TREE_TYPE (decl)); > > and the corresponding check, because I think it is > redundant if we also test for the main variant. > (it wasn't with TYPE_CANONICAL because this was > only added conditionally). > > The other code in the file only checks for added > declarations not types, so should not depend on this. Apologies. I thought that I had already said that the Go changes are fine if the libgo tests still pass. Anyhow, that is the case: if the tests pass, the change is fine. Thanks. Ian