From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10306 invoked by alias); 1 Dec 2015 04:46:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10289 invoked by uid 89); 1 Dec 2015 04:46:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f182.google.com Received: from mail-ig0-f182.google.com (HELO mail-ig0-f182.google.com) (209.85.213.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 01 Dec 2015 04:46:02 +0000 Received: by igcto18 with SMTP id to18so87922424igc.0 for ; Mon, 30 Nov 2015 20:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=fYJ8h8CJ+PchB3INuuVlIzxzqx+Cw122+W0Ls9x1KmU=; b=bx2ioVgLHiibqSO7qkTEB3PTxxZ+ZUU8Om9gtkR3dySn8/1TpqQnQhCLui3X9mCYd1 nyPvIjf5vegu0eeSlkatGzDb17DLhYzBmZMgbhbFvkfiAfXiTEdkz4PZ0eLPZLsRtp2+ brKGcbD3dQtBIAtNbmLamUiq+nZ86uOUkHxR8xZL1ucgOBCXD5k1A744t1tH+9Z6qiAm IzoWmNMzs4AJIiiLRglL66MigbEn9V8e901lGLg3/iF/wqIvqzO9BMNxf1NBx5j0ekap OWaCFi9BfA7YbTFnCTcOIrQhGoFrUlmeMHHRDobknA2lGmJbEZ8dao72EBfml80hWAcY QGsw== X-Gm-Message-State: ALoCoQlzL1IqcK6v2YQII6SxLZ05G9tq5G5wHfR9dwo4tNDqfkk0P4hiiQPClJxUoU2Pmky6FGoh MIME-Version: 1.0 X-Received: by 10.50.73.228 with SMTP id o4mr25298528igv.37.1448945160820; Mon, 30 Nov 2015 20:46:00 -0800 (PST) Received: by 10.107.162.70 with HTTP; Mon, 30 Nov 2015 20:46:00 -0800 (PST) Date: Tue, 01 Dec 2015 04:46:00 -0000 Message-ID: Subject: Go patch committed: Don't set TYPE_STRING_FLAG on a type variant From: Ian Lance Taylor To: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary=089e013a25489c62150525ced5dd X-SW-Source: 2015-12/txt/msg00003.txt.bz2 --089e013a25489c62150525ced5dd Content-Type: text/plain; charset=UTF-8 Content-length: 551 PR 68477 observes that gccgo crashes when using -flto1 because a type variant has TYPE_STRING_FLAG set. So, don't do that. TYPE_STRING_FLAG doesn't really do anything, as far as I can tell, since all the relevant tests in dwarf2out.c also test isfortran(). But, it seems like the right thing to do. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 2015-11-30 Ian Lance Taylor PR go/68477 * go-gcc.cc (Gcc_backend::string_constant_expression): Don't set TYPE_STRING_FLAG on a variant type. --089e013a25489c62150525ced5dd Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ihmwivee0 Content-length: 810 SW5kZXg6IGdjYy9nby9nby1nY2MuY2MKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZ2NjL2dvL2dvLWdjYy5jYwkocmV2aXNpb24gMjMwNzU5KQorKysg Z2NjL2dvL2dvLWdjYy5jYwkod29ya2luZyBjb3B5KQpAQCAtMTI3OSw3ICsx Mjc5LDYgQEAgR2NjX2JhY2tlbmQ6OnN0cmluZ19jb25zdGFudF9leHByZXNz aW9uKAogICB0cmVlIGNvbnN0X2NoYXJfdHlwZSA9IGJ1aWxkX3F1YWxpZmll ZF90eXBlKHVuc2lnbmVkX2NoYXJfdHlwZV9ub2RlLAogCQkJCQkgICAgICBU WVBFX1FVQUxfQ09OU1QpOwogICB0cmVlIHN0cmluZ190eXBlID0gYnVpbGRf YXJyYXlfdHlwZShjb25zdF9jaGFyX3R5cGUsIGluZGV4X3R5cGUpOwotICBz dHJpbmdfdHlwZSA9IGJ1aWxkX3ZhcmlhbnRfdHlwZV9jb3B5KHN0cmluZ190 eXBlKTsKICAgVFlQRV9TVFJJTkdfRkxBRyhzdHJpbmdfdHlwZSkgPSAxOwog ICB0cmVlIHN0cmluZ192YWwgPSBidWlsZF9zdHJpbmcodmFsLmxlbmd0aCgp LCB2YWwuZGF0YSgpKTsKICAgVFJFRV9UWVBFKHN0cmluZ192YWwpID0gc3Ry aW5nX3R5cGU7Cg== --089e013a25489c62150525ced5dd--