From: Ian Lance Taylor <iant@golang.org>
To: "REIX, Tony" <tony.reix@atos.net>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"dje.gcc@gmail.com" <dje.gcc@gmail.com>
Subject: Re: [PATCH,AIX] Manage .go_export section for AIX
Date: Fri, 28 Jul 2017 00:16:00 -0000 [thread overview]
Message-ID: <CAOyqgcXKW0-S+m=QTqFkKKzW13KiYWTaj1dHb4nva3BBAemM5g@mail.gmail.com> (raw)
In-Reply-To: <B37989F2852398498001550C29155BE51789E7DA@FRCRPVV9EX4MSX.ww931.my-it-solutions.net>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On Wed, Jul 26, 2017 at 3:09 AM, REIX, Tony <tony.reix@atos.net> wrote:
> Description:
> * This patch manages the .go_export section as an EXCLUDE section on AIX.
>
> Tests:
> * Fedora25/x86_64 + GCC trunk : Configure/Build: SUCCESS
> - build made by means of gmake.
>
> ChangeLog:
> * go-backend.c (go_write_export_data): Use EXCLUDE section for AIX.
Thanks. Testing _AIX here is clearly wrong, as we need to test for a
target property, not a host property. I committed this patch as
appended.
Ian
2017-07-27 Tony Reix <tony.reix@atos.net>
* go-backend.c (go_write_export_data): Use EXCLUDE section for
AIX.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 790 bytes --]
Index: go-backend.c
===================================================================
--- go-backend.c (revision 250406)
+++ go-backend.c (working copy)
@@ -45,6 +45,10 @@ along with GCC; see the file COPYING3.
#define GO_EXPORT_SECTION_NAME ".go_export"
#endif
+#ifndef TARGET_AIX
+#define TARGET_AIX 0
+#endif
+
/* This file holds all the cases where the Go frontend needs
information from gcc's backend. */
@@ -101,7 +105,9 @@ go_write_export_data (const char *bytes,
if (sec == NULL)
{
gcc_assert (targetm_common.have_named_sections);
- sec = get_section (GO_EXPORT_SECTION_NAME, SECTION_DEBUG, NULL);
+ sec = get_section (GO_EXPORT_SECTION_NAME,
+ TARGET_AIX ? SECTION_EXCLUDE : SECTION_DEBUG,
+ NULL);
}
switch_to_section (sec);
prev parent reply other threads:[~2017-07-28 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 10:09 REIX, Tony
2017-07-28 0:16 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcXKW0-S+m=QTqFkKKzW13KiYWTaj1dHb4nva3BBAemM5g@mail.gmail.com' \
--to=iant@golang.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tony.reix@atos.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).