From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by sourceware.org (Postfix) with ESMTPS id 25A1A3973060 for ; Fri, 11 Dec 2020 17:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25A1A3973060 Received: by mail-ej1-x641.google.com with SMTP id w1so8867585ejf.11 for ; Fri, 11 Dec 2020 09:58:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V6bXALZDbERN5gMA3UVZPDO8f8iptl9EQz+9dxIuARE=; b=U1setstS+3Y/pnvBLGQvgE0Hf7ZEpQEnXaPtu1fzG2IEyctMoc/P0RO0Jq/KWPdrEP 2bZbWGDlH+BAgx3wf0QlvO7zLrDtXfMWO2SlOMTW50m+EmtsZCyGuLlV9sZsiGsX7+Jz v1wDctVTTFNhJrrqK97dmFoPZ1pkso6pjnvzswN3YVcQF+s9OfQW7kzIUhy5HBP13Pov PuNajPo984MJpA6J4raYJ8OCtcI31p4k04X3I0g3i1kDAsDPDzya/EuJ/szuzT3KKxb9 aIouZizFfNWvT83QQ2HLhMxv/aOgMzygh+A9BWSU9PeNBfv8LunXMvBHX1e392EmQRr1 zkSg== X-Gm-Message-State: AOAM530a2sYTuWx1Em1REKpR1cUr4FDk3+Yo7mF3z5BTGe702sTiaS8P P/tpvLU0WuBQx3u7kkk+EcwW5yVVrUzI02WlG7sbBFi3pXk= X-Google-Smtp-Source: ABdhPJzvinrMOhKKrPN43pcb7L6H9QzBSlcxZZzYQ/sAOyOKtfQqCJx8NI0iQ6lvOj9I6SWtTPOzDu8lcriFrncwvuA= X-Received: by 2002:a17:906:7687:: with SMTP id o7mr12146211ejm.209.1607709501242; Fri, 11 Dec 2020 09:58:21 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ian Lance Taylor Date: Fri, 11 Dec 2020 09:58:10 -0800 Message-ID: Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation To: "CHIGOT, CLEMENT" Cc: "gcc-patches@gcc.gnu.org" , David Edelsohn , gofrontend-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2020 17:58:23 -0000 On Thu, Dec 10, 2020 at 9:09 PM Ian Lance Taylor wrote: > > On Tue, Dec 8, 2020 at 5:15 AM CHIGOT, CLEMENT = wrote: > > > > Any news about this bug ? It's not urgent even if it's breaking gcc bui= lds with Go language, but I just want to know if you need any inputs/help f= rom me. > > I sent https://golang.org/cl/277232 to fix this problem. Should be fixed now. Ian > > ________________________________ > > From: CHIGOT, CLEMENT > > Sent: Wednesday, December 2, 2020 5:14 PM > > To: Ian Lance Taylor > > Cc: gcc-patches@gcc.gnu.org ; David Edelsohn <= dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during st= abstrings generation > > > > Hi Ian, > > > > Here is the test case. > > If you're compiling with -gstabs you should have a line looking like: > > .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]g= o.bug1.Extension{asn1:"set"}}:G(0,7)=3DxsStructType:",32,0,0,0 > > > > As you can see the " around for "set" aren't escaped. > > I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le= and I don't think it's a ppc-only bug. > > > > Cl=C3=A9ment > > ________________________________ > > From: Ian Lance Taylor > > Sent: Wednesday, December 2, 2020 4:55 PM > > To: CHIGOT, CLEMENT > > Cc: gcc-patches@gcc.gnu.org ; David Edelsohn <= dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during st= abstrings generation > > > > Caution! External email. Do not open attachments or click links, unless= this email comes from a known sender and you know the content is safe. > > > > On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT wrote: > > > > > > Since the new gccgo mangling scheme, libgo compilation is broken on A= IX (or in Linux with -gstabs) because of a type symbol having a " in its na= me. I've made a patch (see attachment) in order to fix stabstring generatio= n, because, IMO, it should be handled anyway. > > > However, it happens only once in the whole libgo so I don't know if t= his " is intended or not. The problematic type is there: https://eur01.safe= links.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Fgolang%2Fgo%= 2Fblob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=3D04%7C01%= 7Cclement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7= c7412cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d= 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= amp;sdata=3DaB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved= =3D0. Other similar types don't trigger the bug though. > > > > > > I've a minimal test which might can be added if you wish, in Golang t= ests or in Gcc Go tests or in both ? > > > > > > If the patch is okay, could you please apply it for me ? > > > > Could you show me the small test case? I don't think I understand the > > problem. In DWARF I don't see any symbol names with quotation marks. > > I'm not yet sure that your patch is the right fix. Thanks. > > > > Ian