From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 1EB86385741F for ; Fri, 28 Oct 2022 00:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EB86385741F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pf1-x42b.google.com with SMTP id y13so3394981pfp.7 for ; Thu, 27 Oct 2022 17:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RsLFxiffcDnlaD9Bv4MLOyWpy6uwbMzHxBXz2e/hE8w=; b=Pqrjf0P14ntDWPL22pdkI5Udr4o972FMb0gZSer5a4WPR/uSPr93SoP6865JUoQyV8 OqckowxeEHue4cWsZtlbKbIsMONqJqJRfwpuPyYtLdOirAYQWOvyrU1rFHGGgwdqy/de /zZTZVlE6fXHvKQSuwsn14VJ9ZQ0aJUc9p4hPrgXUwi7fw9+EswU9jvZIcuhkNMZmM1F OsALB5eLy4hBfouyrYVs9KvnMRcwliRFzSO4gOjsmiA8Mg4eUbmW/lw2/QQaqVnho9TJ WyKRlNT3UP/dCIJxWd2S8+ceK0/e4FJiHkUt6lAiSvA2L94qrEF55mUI60W1AT6/Bwu8 Hd+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RsLFxiffcDnlaD9Bv4MLOyWpy6uwbMzHxBXz2e/hE8w=; b=hkQC6PFqnRUfbSEgffnrVpJV7ZoOZKEhUeCpIdvMJYbhJDhCv8c8EHbEcPnEUEMBEx fwFY+CCJ9c+LXjJ4kJbg+sHkL0HAke9RpesWCK8m9xCnTojfM6rIu4hJO6MDb4/2PPUV EGk6lkYwKsfzaTFUnrYppP07Dl3wZAAfTsL7ab8q+/B42nPGDJBMRD1Ca5fkaojjoIwX nx7rAiTqKrNXagcFZHuX2xGq4xt6v2fUG3GryU+fuk1n2u+AHIW6Xna90Jcyew76pDg4 vng+N97XpkOz4wVIelk+ryl4wWQ718N5m0hGPUGLR2agA0ENd5P3uYfZ/WG4l+N1l1Wb gVfg== X-Gm-Message-State: ACrzQf2B2IO+2Ir/XUOyPUFixRhHvpb1i4jktsib7Tuo/gWO7LIkjLR7 h4kHxVjIRS9DvfXKINNQ9bGQIDSNeQBA+N2kpLXJxg== X-Google-Smtp-Source: AMsMyM5Kgr3jrv/siwVIgjycDBQeHdogVSlhgOQkAPvK1joxjYHHMt2iL/jWHh6H3MtZujqJTlakBpNDKNqBdR9Qkx0= X-Received: by 2002:a63:8841:0:b0:461:24b7:a621 with SMTP id l62-20020a638841000000b0046124b7a621mr45024751pgd.277.1666916010770; Thu, 27 Oct 2022 17:13:30 -0700 (PDT) MIME-Version: 1.0 References: <20220929144912.21826-1-soeren@soeren-tempel.net> <2T94HQTK7FOFK.2UPCTYUHVIT0G@8pit.net> In-Reply-To: <2T94HQTK7FOFK.2UPCTYUHVIT0G@8pit.net> From: Ian Lance Taylor Date: Thu, 27 Oct 2022 17:13:18 -0700 Message-ID: Subject: Re: [PATCH] libgo: use _off_t for mmap offset argument To: =?UTF-8?Q?S=C3=B6ren_Tempel?= Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="000000000000b1c3f005ec0d2010" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b1c3f005ec0d2010 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2022 at 6:45 AM S=C3=B6ren Tempel wrote: > > PING. > > soeren@soeren-tempel.net wrote: > > From: S=C3=B6ren Tempel > > > > On glibc-based systems, off_t is a 32-bit type on 32-bit systems and a > > 64-bit type on 64-bit systems by default. However, on systems using mus= l > > libc off_t is unconditionally a 64-bit type. As such, it is insufficien= t > > to use a uintptr type for the mmap offset parameter. > > > > Presently, the (incorrect) mmap declaration causes a libgo run-time > > failure on 32-bit musl systems (fatal error: runtime: cannot allocate > > memory). This commit fixes this run-time error. > > > > Signed-off-by: S=C3=B6ren Tempel > > --- > > This implements what has been proposed by Ian in a GitHub comment > > https://github.com/golang/go/issues/51280#issuecomment-1046322011 > > > > I don't have access to a 32-bit glibc system to test this on but > > this does seem to work fine on 32-bit and 64-bit musl systems. Thanks. Committed as follows using _libgo_off_t_type to avoid the confusion between off_t and off64_t. Sorry for the delay. Ian --000000000000b1c3f005ec0d2010 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9rqqj4x0 MTFhNWZjMGM3NmFlZGIxMDBiNWQ3ZWNjN2RkNGJlZDMzZDg1MGJiOApkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCA1Yjk1 YjM4YTU0MS4uN2U1MzFjM2Y5MGIgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotNmMxODgxMDg4 NThlM2FlOGM4ZWE4ZTRjYzU1NDI3ZDhjZjAxYmJjOAorNWU2NThmNDY1OWM1NTEzMzBlYTY4ZjU2 NjdlNGY5NTFiMjE4ZjMyZAogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vZ28vcnVudGltZS9tZW1fZ2Nj Z28uZ28gYi9saWJnby9nby9ydW50aW1lL21lbV9nY2Nnby5nbwppbmRleCBmYTMzODlkODU3ZS4u MWU4NGY0ZjVjNTYgMTAwNjQ0Ci0tLSBhL2xpYmdvL2dvL3J1bnRpbWUvbWVtX2djY2dvLmdvCisr KyBiL2xpYmdvL2dvL3J1bnRpbWUvbWVtX2djY2dvLmdvCkBAIC0xNSw3ICsxNSw3IEBAIGltcG9y dCAoCiAvL2dvOmxpbmtuYW1lIHN5c0ZyZWUKIAogLy9leHRlcm4gbW1hcAotZnVuYyBzeXNNbWFw KGFkZHIgdW5zYWZlLlBvaW50ZXIsIG4gdWludHB0ciwgcHJvdCwgZmxhZ3MsIGZkIGludDMyLCBv ZmYgdWludHB0cikgdW5zYWZlLlBvaW50ZXIKK2Z1bmMgc3lzTW1hcChhZGRyIHVuc2FmZS5Qb2lu dGVyLCBuIHVpbnRwdHIsIHByb3QsIGZsYWdzLCBmZCBpbnQzMiwgb2ZmIF9saWJnb19vZmZfdF90 eXBlKSB1bnNhZmUuUG9pbnRlcgogCiAvL2V4dGVybiBtdW5tYXAKIGZ1bmMgbXVubWFwKGFkZHIg dW5zYWZlLlBvaW50ZXIsIGxlbmd0aCB1aW50cHRyKSBpbnQzMgpAQCAtMzgsNyArMzgsNyBAQCBm dW5jIGluaXQoKSB7CiB9CiAKIGZ1bmMgbW1hcChhZGRyIHVuc2FmZS5Qb2ludGVyLCBuIHVpbnRw dHIsIHByb3QsIGZsYWdzLCBmZCBpbnQzMiwgb2ZmIHVpbnRwdHIpICh1bnNhZmUuUG9pbnRlciwg aW50KSB7Ci0JcCA6PSBzeXNNbWFwKGFkZHIsIG4sIHByb3QsIGZsYWdzLCBmZCwgb2ZmKQorCXAg Oj0gc3lzTW1hcChhZGRyLCBuLCBwcm90LCBmbGFncywgZmQsIF9saWJnb19vZmZfdF90eXBlKG9m ZikpCiAJaWYgdWludHB0cihwKSA9PSBfTUFQX0ZBSUxFRCB7CiAJCXJldHVybiBuaWwsIGVycm5v KCkKIAl9CkBAIC00Nyw2ICs0Nyw3IEBAIGZ1bmMgbW1hcChhZGRyIHVuc2FmZS5Qb2ludGVyLCBu IHVpbnRwdHIsIHByb3QsIGZsYWdzLCBmZCBpbnQzMiwgb2ZmIHVpbnRwdHIpICh1CiAKIC8vIERv bid0IHNwbGl0IHRoZSBzdGFjayBhcyB0aGlzIG1ldGhvZCBtYXkgYmUgaW52b2tlZCB3aXRob3V0 IGEgdmFsaWQgRywgd2hpY2gKIC8vIHByZXZlbnRzIHVzIGZyb20gYWxsb2NhdGluZyBtb3JlIHN0 YWNrLgorLy8KIC8vZ286bm9zcGxpdAogZnVuYyBzeXNBbGxvYyhuIHVpbnRwdHIsIHN5c1N0YXQg KnN5c01lbVN0YXQpIHVuc2FmZS5Qb2ludGVyIHsKIAlwLCBlcnIgOj0gbW1hcChuaWwsIG4sIF9Q Uk9UX1JFQUR8X1BST1RfV1JJVEUsIF9NQVBfQU5PTnxfTUFQX1BSSVZBVEUsIG1tYXBGRCwgMCkK QEAgLTE2NSw2ICsxNjYsNyBAQCBmdW5jIHN5c0h1Z2VQYWdlKHYgdW5zYWZlLlBvaW50ZXIsIG4g dWludHB0cikgewogCiAvLyBEb24ndCBzcGxpdCB0aGUgc3RhY2sgYXMgdGhpcyBmdW5jdGlvbiBt YXkgYmUgaW52b2tlZCB3aXRob3V0IGEgdmFsaWQgRywKIC8vIHdoaWNoIHByZXZlbnRzIHVzIGZy b20gYWxsb2NhdGluZyBtb3JlIHN0YWNrLgorLy8KIC8vZ286bm9zcGxpdAogZnVuYyBzeXNGcmVl KHYgdW5zYWZlLlBvaW50ZXIsIG4gdWludHB0ciwgc3lzU3RhdCAqc3lzTWVtU3RhdCkgewogCXN5 c1N0YXQuYWRkKC1pbnQ2NChuKSkK --000000000000b1c3f005ec0d2010--