From: Ian Taylor <iant@golang.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Joern Rennecke <joern.rennecke@embecosm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work)
Date: Fri, 31 Oct 2014 00:44:00 -0000 [thread overview]
Message-ID: <CAOyqgcXYYL=W56rz9uFuYbZrzh3Z2ipP6CLUf-MTDGzvzVPZsA@mail.gmail.com> (raw)
In-Reply-To: <20141030191457.GG28215@lug-owl.de>
On Thu, Oct 30, 2014 at 12:14 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Thu, 2014-10-30 08:08:51 -0700, Ian Taylor <iant@golang.org> wrote:
>> On Thu, Oct 30, 2014 at 6:19 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> >
>> > This updates contrib/config-list.mk to build Go for all but
>> > known-non-working targets. A comment to configure{.ac,} is also added.
>>
>> > diff --git a/contrib/config-list.mk b/contrib/config-list.mk
>> > index 94884d9..16900e1 100644
>> > --- a/contrib/config-list.mk
>> > +++ b/contrib/config-list.mk
>> > @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS
>> >
>> > $(LIST): make-log-dir
>> > -mkdir $@
>> > - (cd $@ && \
>> > - ../../gcc/configure \
>> > - --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
>> > - --enable-werror-always ${host_options} --enable-languages=all,ada,go) \
>> > - > log/$@-config.out 2>&1
>> > + ( \
>> > + cd $@ && \
>> > + echo $@ && \
>> > + TGT=`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && \
>> > + TGT=`../../gcc/config.sub $$TGT` && \
>>
>> This isn't necessary. The OPT bits will be matched by the * at the
>> end of the cases anyhow. You can just write
>> case $@ in
>>
>> This is OK with that change.
>
> Not exactly: My intention was to keep the triplet matches as they show
> up in configure.ac . However, the target list in config-list.mk uses
> (almost exclusively) shorthands for all the targets, so these need to
> be expand (--> config.sub); that however won't really fly with the
> OPTs in there.
Oh, right, sorry.
The original patch is OK.
Thanks.
Ian
next prev parent reply other threads:[~2014-10-31 0:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 6:30 Patch RFA: Top-level configure patch: disable go on systems where it doesn't work Ian Taylor
2014-10-23 15:31 ` Pedro Alves
2014-10-23 15:35 ` Ian Taylor
2014-10-23 15:41 ` Pedro Alves
2014-10-23 18:27 ` Ian Taylor
2014-10-23 18:17 ` Jeff Law
2014-10-27 15:07 ` Jan-Benedict Glaw
2014-10-27 15:20 ` Ian Taylor
2014-10-27 16:03 ` Jan-Benedict Glaw
2014-10-27 16:57 ` Ian Taylor
2014-10-30 14:15 ` [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work) Jan-Benedict Glaw
2014-10-30 15:20 ` Ian Taylor
2014-10-30 19:43 ` Jan-Benedict Glaw
2014-10-31 0:44 ` Ian Taylor [this message]
2014-10-31 11:07 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcXYYL=W56rz9uFuYbZrzh3Z2ipP6CLUf-MTDGzvzVPZsA@mail.gmail.com' \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jbglaw@lug-owl.de \
--cc=joern.rennecke@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).