From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28392 invoked by alias); 31 Oct 2014 00:10:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28377 invoked by uid 89); 31 Oct 2014 00:10:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f43.google.com Received: from mail-yh0-f43.google.com (HELO mail-yh0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 31 Oct 2014 00:10:40 +0000 Received: by mail-yh0-f43.google.com with SMTP id z6so2182884yhz.30 for ; Thu, 30 Oct 2014 17:10:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9ymo6ijjg3V22XczpC45vyurb+YKJq4+bcbyisAHFRc=; b=RfxRuX1yJlkZOLnQMSju4rNfpecbcNvQQOA4pcHzWA6MgNCglIcLVngAezm4glSyFY zjcSbEkotQ3glRIKrdv0kuodO0sk56kJCxuptV5hXbzp0/kN9v51eCq8rT1wLekgpyRq S1hE/GIf1VivE2Xo5AHtVaoCMprYjsfs3qoXYw815r6kaiaF2MSnE9/hmiCtZByoRoo3 mgdLtSflA366GtHoKdtNxv0yBMMKR43ssVLswJDP2PXU57Lmy38VNsUEuWExraMt62bk yZPIeffSUE0SLS8Iu0azxXDHnS0FUrLN3YCpuBlj4JQrw/T+pbLduQ7chHpCLJ6PKc3h FIHg== X-Gm-Message-State: ALoCoQnjvXUPr74jElw1XJGfcCjJNTgEACVuL9hFaxUC846XGwdiaYoUXG7eHMOFkhLip5ZnC0Mm MIME-Version: 1.0 X-Received: by 10.170.161.10 with SMTP id c10mr20948860ykd.9.1414714238288; Thu, 30 Oct 2014 17:10:38 -0700 (PDT) Received: by 10.170.233.132 with HTTP; Thu, 30 Oct 2014 17:10:38 -0700 (PDT) In-Reply-To: <20141030191457.GG28215@lug-owl.de> References: <20141027150658.GZ28215@lug-owl.de> <20141027160244.GA28215@lug-owl.de> <20141030131947.GF28215@lug-owl.de> <20141030191457.GG28215@lug-owl.de> Date: Fri, 31 Oct 2014 00:44:00 -0000 Message-ID: Subject: Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work) From: Ian Taylor To: Jan-Benedict Glaw Cc: Joern Rennecke , gcc-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-10/txt/msg03243.txt.bz2 On Thu, Oct 30, 2014 at 12:14 PM, Jan-Benedict Glaw wrote: > On Thu, 2014-10-30 08:08:51 -0700, Ian Taylor wrote: >> On Thu, Oct 30, 2014 at 6:19 AM, Jan-Benedict Glaw wrote: >> > >> > This updates contrib/config-list.mk to build Go for all but >> > known-non-working targets. A comment to configure{.ac,} is also added. >> >> > diff --git a/contrib/config-list.mk b/contrib/config-list.mk >> > index 94884d9..16900e1 100644 >> > --- a/contrib/config-list.mk >> > +++ b/contrib/config-list.mk >> > @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS >> > >> > $(LIST): make-log-dir >> > -mkdir $@ >> > - (cd $@ && \ >> > - ../../gcc/configure \ >> > - --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \ >> > - --enable-werror-always ${host_options} --enable-languages=all,ada,go) \ >> > - > log/$@-config.out 2>&1 >> > + ( \ >> > + cd $@ && \ >> > + echo $@ && \ >> > + TGT=`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && \ >> > + TGT=`../../gcc/config.sub $$TGT` && \ >> >> This isn't necessary. The OPT bits will be matched by the * at the >> end of the cases anyhow. You can just write >> case $@ in >> >> This is OK with that change. > > Not exactly: My intention was to keep the triplet matches as they show > up in configure.ac . However, the target list in config-list.mk uses > (almost exclusively) shorthands for all the targets, so these need to > be expand (--> config.sub); that however won't really fly with the > OPTs in there. Oh, right, sorry. The original patch is OK. Thanks. Ian