* Go patch committed: Type check parameters in sink function declaration
@ 2015-08-25 8:14 Ian Lance Taylor
0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2015-08-25 8:14 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
This patch by Chris Manghane fixes the Go frontend to type check
function parameters in a sink function declaration, as in func _(int).
This fixes https://golang.org/issue/11535 . Bootstrapped and ran Go
testsuite on x86_64-unknown-linux-gnu. Committed to mainline.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1430 bytes --]
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 227039)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-cc7303c97b232ea979cab950d95aaf76c4e0f5b5
+81810917af7ba19e1f9f8efc8b1989f7d6419d30
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: gcc/go/gofrontend/parse.cc
===================================================================
--- gcc/go/gofrontend/parse.cc (revision 226846)
+++ gcc/go/gofrontend/parse.cc (working copy)
@@ -2305,8 +2305,20 @@ Parse::function_decl(bool saw_nointerfac
if (!this->peek_token()->is_op(OPERATOR_LCURLY))
{
- if (named_object == NULL && !Gogo::is_sink_name(name))
+ if (named_object == NULL)
{
+ // Function declarations with the blank identifier as a name are
+ // mostly ignored since they cannot be called. We make an object
+ // for this declaration for type-checking purposes.
+ if (Gogo::is_sink_name(name))
+ {
+ static int count;
+ char buf[30];
+ snprintf(buf, sizeof buf, ".$sinkfndecl%d", count);
+ ++count;
+ name = std::string(buf);
+ }
+
if (fntype == NULL
|| (expected_receiver && rec == NULL))
this->gogo_->add_erroneous_name(name);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-25 3:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-25 8:14 Go patch committed: Type check parameters in sink function declaration Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).