From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by sourceware.org (Postfix) with ESMTPS id EA55B3861883 for ; Thu, 30 Nov 2023 21:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA55B3861883 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA55B3861883 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701379523; cv=none; b=OCuQOLNLgW3GzxkWzN7vNRs35/y4wORrH6yAbNFOwPT0jfPTldZD3JDhXy+6E2yJF4Rk0NpkoDcduKKtpKjsEXfU5AntyUPSJWdOOBlkJuFUIwtvJrjvstR+0Leb43YKW0LMWxV96q6GRUY1EoqIc9zrYvGdTD2705lPpZR5Z/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701379523; c=relaxed/simple; bh=FmKI3QfD+ysInHBcujFsxvAxRWvdU4c3GtSLNa6OYzs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=L2cPuy7X9ZTEsieji/Z0F/PtULpgwzrjcAZfzp5evIHd9SB1I1tljJKht2v1oeY2kwv2pVt+MwaG+7KpoyrjK++2X/0PPvLfklc2C3rFOQVJ/DJ5g+23LyCYdvfk170gX8CtrqgdnWZv4IJtii+1kdDF7ltn+idn/beKNIrdX/4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5d3644ca426so11067437b3.1 for ; Thu, 30 Nov 2023 13:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20230601.gappssmtp.com; s=20230601; t=1701379521; x=1701984321; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4SOGwOqqBv+ewzLWCTTWT2RTDiks7DRITA8X8BpuvCM=; b=W1kHFtt9FGWhtqj7QmVVOt78OyTgg6Q3emIQlt5cJtXnCewebo1AtO3Z5yTLTqIPSj kaL7dlIpLDivVmzCdjQ1EkAlfJQDjBxhbcX0ahSlvRjUYi3NNF2gly4cpjCSkuZ6d4DJ urMS+7ponhPuInTlPeSGfD2K+V7z09/WI1cFCwziRI3lvPu2w354RaebLy/OynSCM3uw XZ08AQ1p9dCj6E6SNTJEnxq2YkkqPVm8UsKxFhOizSTte6lHGFINuGMLxRWnFEvyRz7M 9YKbAV54wXQYk+KZl65oFDTNQsa40xfFVwBQJvVugBDTbf/bDTsh2uaSrRdNHuI/nGPj MiLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701379521; x=1701984321; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4SOGwOqqBv+ewzLWCTTWT2RTDiks7DRITA8X8BpuvCM=; b=I6sR8qfnZ2H8SqDmDQ+taRrQBfHXmDFjpTUOghYl2oCfipKLzjoMfnoTyqdnT/FYjb eWz+vSyaB3qrB2aZct3ewBwe7qYr/d1qKPQzYk+/+V2XvBW8GDgQcqhMKQbVgtzZabAp cK75RI59ASuEnBg6r5IOhQku1LjZ8C0kUWIFBMsoZpihQLe24PihGrUkDWTOXjvkDKIa 5MavzW6IwHyn64APPWwCkzcz63IpbqqqFff8+3G9ivaqTBaNcuxULy7Qz6q/hbITALYJ iFX8vbi8B3f0skTs8qziBPH7qNgZDkfdFSg9VVxX3rVt2H+7EWK6XsA8zMd9rcv77zDf BTCw== X-Gm-Message-State: AOJu0YyaYCG2CaGXFDLSuH7k0QrrkefO44C0AonfLpQwnnOsDFek5gAo d/BY8u6y/fquh0H9VQp2J3KiMvgWaA6ABjV1XuBD1g== X-Google-Smtp-Source: AGHT+IHTe2AEDEsThfzxFhE7yDPSejB+ubIzO+L3ENKpbrvDf2SqZyte9KaUvxoHTXY93q+FqUqJby78RWvvGAK8fJ4= X-Received: by 2002:a5b:78f:0:b0:d81:504f:f879 with SMTP id b15-20020a5b078f000000b00d81504ff879mr21428257ybq.28.1701379521251; Thu, 30 Nov 2023 13:25:21 -0800 (PST) MIME-Version: 1.0 References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com> In-Reply-To: From: Ian Lance Taylor Date: Thu, 30 Nov 2023 13:25:10 -0800 Message-ID: Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] To: Iain Sandoe Cc: FX Coudert , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 30, 2023 at 11:58=E2=80=AFAM Ian Lance Taylor = wrote: > > On Thu, Nov 30, 2023 at 11:56=E2=80=AFAM Iain Sandoe = wrote: > > > > > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote: > > > > > > On Sun, Oct 22, 2023 at 2:18=E2=80=AFPM FX Coudert wrote: > > >> > > >> Thanks a lot Alexandre for the review! > > > > > > This patch changed the files lingo/configure.ac and libgo/configure. > > > Those files live in an upstream repository and should be changed ther= e > > > and then merged into the GCC repo, as described in libgo/README.gcc. > > > This is not a big deal, and I can take care of changing the upstream > > > repository. But I don't understand the changes in libgo. As far as = I > > > can tell, all they do is add an automake conditional that is never > > > used. Is there any reason for that? > > > > It=E2=80=99s not used (yet) because we do not build libgo on Darwin, if= /when we > > do it would be used in the same way as for the other runtimes. > > > > > Should I just revert the changes to libgo? > > > > That is also fine (because we do not yet build it on Darwin), it seems = unlikely > > we=E2=80=99d forget to re-add it. > > Thanks, I'll make the change upstream. Now done. Ian