From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63277 invoked by alias); 16 Jun 2017 00:12:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63248 invoked by uid 89); 16 Jun 2017 00:12:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f48.google.com Received: from mail-oi0-f48.google.com (HELO mail-oi0-f48.google.com) (209.85.218.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 00:12:45 +0000 Received: by mail-oi0-f48.google.com with SMTP id s3so16356109oia.0 for ; Thu, 15 Jun 2017 17:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yoPVbRf14p00gKGiuDwlr6ehGre+bnD1wHTP7/t3BK8=; b=NeR4QX4iVgAPhlKKP0r7i97ILAM6GG1b+lFNB4VXjH5r8LSacIaKBBD/C3iikh8ao9 dqILgpygnClcHKag2PV0Tnm915CW5ich2/taRROzPkWmnfhZKx53/MPgEfKvRju/stvD VDU2S0o7U5utORGMkB2HO+vnYqQPxz5Ymjm2HYORJFB8V74vOixsTan7uHcxOGkkAgxH IX/o5rCyBRxjkMqhaDQf8g+vfjk8y6sGkBAUNdZ+pVUlSwpRG3PcSkK3ZKmKLUWeAfpc f3TkqKO6xcTSDeAFghgx1YMK7YEEmrZJMetmP3mSt/6dYzW2q+TCFjm042M/bBGedMfq 2hgA== X-Gm-Message-State: AKS2vOzhJxIrgwpgq19lMStAJ7PCeaMZfySBD5NSXtclnO93bDSlhOiT 5j8XI5ubTZQcgWjZvEOWbkTGrD8ZnkVN X-Received: by 10.202.225.9 with SMTP id y9mr4077950oig.32.1497571968164; Thu, 15 Jun 2017 17:12:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.227.10 with HTTP; Thu, 15 Jun 2017 17:12:47 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Fri, 16 Jun 2017 00:12:00 -0000 Message-ID: Subject: Re: Top-level patch committed: Add check-gotools to check-go To: Rainer Orth Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg01154.txt.bz2 On Thu, Jun 15, 2017 at 2:00 PM, Rainer Orth wrote: > >> I've committed this patch to the top level Makefile.def so that `make >> check-go` will run `make check-gotools`. Bootstrapped and ran Go >> testsuite on x86_64-pc-linux-gnu. Committed to mainline. >> >> This patch may cause new test failures on other systems. Please let >> me know about them. I don't anticipate anything in particular, but, >> who knows. > > the gotools test results came up empty on *-*-solaris2.12 with /bin/ksh. > In the make check-gotools output I found > > (cd check-go-dir/src/cmd/go && /var/gcc/regression/trunk/12-gcc/build/gotools/go test -test.short -test.v) >& cmd_go-testlog || true > /bin/ksh: line 3: cmd_go-testlog: bad file unit number > > If one uses the portable form of I/O redirection here, the test works on > Solaris, too. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2017-06-15 Rainer Orth > > * Makefile.am (check-go-tool): Don't use >& for I/O redirection. > * Makefile.in: Regenerate. Whoops. This is OK. You can go ahead and commit--unlike the go/gofrontend and libgo directories, this directory lives entirely in the GCC tree. Thanks. Ian