From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fencepost.gnu.org (fencepost.gnu.org [IPv6:2001:470:142:3::e]) by sourceware.org (Postfix) with ESMTPS id CB8573857039 for ; Mon, 21 Dec 2020 04:17:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CB8573857039 Received: from eggs.gnu.org ([2001:470:142:3::10]:38756) by fencepost.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1krCdH-0002E8-3o for gcc-patches@gnu.org; Sun, 20 Dec 2020 23:17:15 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:43795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krCdE-0005ck-TK for gcc-patches@gnu.org; Sun, 20 Dec 2020 23:17:14 -0500 Received: by mail-ed1-x531.google.com with SMTP id y24so7645014edt.10 for ; Sun, 20 Dec 2020 20:17:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A57wcNO8OUQQnoRUIgMy8ywlCuW1G+1pFBVNSYsNL+A=; b=MdcEA6KUf8hhd/qGphbiL6Zv/qRbPi0IbwjhpL8eqdr5QUVgHyAzjOTiAuut3OdSfm UeuvFaCi6k9jp0rbXQpJFMumqSuItamgFitpVivttI7mqTUdgC8cS5OZjOUxfeCAMA8Q kbg3qf4QgZBqit05NjTfIK4EmDjhPDdOIxX8gBjWS3ulbjrG9FKRL6NULVV8euH9dpbE n0uQ7WEZn9vZFNfY/93PeF1iw5io1dAR3L3ClESi9ke6sPSjtR41RykjIgDc3F3RSqpZ Wo+ONHNlotU32S8c9oLDcHPiDUQNOUItIXLQyT6ek4ntCIcv/sy/m9Dfpko5Eq1qb0c7 +1Pw== X-Gm-Message-State: AOAM530roXlnec4VhZhXMzjhh9JPG7WK4PWVDmMhJEyFdqstHaET6vCz W7DMyisXfU21IHQOWfJ/0peVegeapIvbhaYWm7Uv+A== X-Google-Smtp-Source: ABdhPJxtZ+CyeFV8zrLxXKnfhY1smqQ5uQgGRjuieph8hL1oaBSk7mHzZapam962FV+N2apE+sV7/WBwAz7/FiSYqow= X-Received: by 2002:aa7:c558:: with SMTP id s24mr14580236edr.257.1608524229232; Sun, 20 Dec 2020 20:17:09 -0800 (PST) MIME-Version: 1.0 References: <52818e83-3ff8-31b3-f444-eb21e3931a82@gmail.com> <2913efa6-53ed-d5c1-fa04-7d14539dfbd9@gmail.com> <4b48e0a9-cac4-9df1-8cbe-ce499284f8b0@gmail.com> <3ea15d6f-20d1-69e5-aecf-003f51a385ff@gmail.com> <27545742-2549-e0eb-63ce-42f019f4e7ec@gmail.com> <66609706-24ae-b4c0-87f6-67a7907140bd@gmail.com> In-Reply-To: <66609706-24ae-b4c0-87f6-67a7907140bd@gmail.com> From: Ian Lance Taylor Date: Sun, 20 Dec 2020 20:16:58 -0800 Message-ID: Subject: Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types To: Nikhil Benesch Cc: Rainer Orth , gcc-patches , gofrontend-dev Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=iant@golang.org; helo=mail-ed1-x531.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 04:17:17 -0000 On Thu, Dec 17, 2020 at 10:22 AM Nikhil Benesch wrote: > > On 12/17/20 1:05 PM, Ian Lance Taylor wrote: > > Thanks for looking into this. I've gotten confused now, though. > > Which patch fixes the problem on Solaris? Thanks. > > > > Ian > > The patch I submitted upstream is all that is needed to fix the > compilation failures on Solaris: > > https://go-review.googlesource.com/c/gofrontend/+/278672 > > That is the same patch as "solaris-godump.patch" in this thread. > > That patch does not fix the fishiness around dummy types that you > pointed out earlier. That is what the other patch was trying (but > failing) to address. But we don't need to fix that fishiness to fix > Solaris. The code in mk[r]sysinfo.sh that is getting confused by the > u?pad128_t dummy type turns out to be unnecessary. So the patch I sent > upstream just removes that code. Thanks. Committed to mainline. Ian