From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id CC8893858D37 for ; Wed, 28 Jun 2023 11:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC8893858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4021451a4a4so17314781cf.0 for ; Wed, 28 Jun 2023 04:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687950917; x=1690542917; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=q6lbXPbmTcGaZOMP0smhluu1MHt7x70jgOrGWtH71eI=; b=LORT6lvlfxc6Gs6Y9ASlNLMs6rr2LPHX6vhvLiecx12oqxIurXvLCpFs2qgslEzrax h2GAqr+sKbSA3RXuD2REtwLYEw1fBNoRnk4LjrCBBuOm7OqjJ6rDnFxpskDvhOFd1Br1 0C2rzu3yxDePmddHle02sal2bw1ErOvm1kBiSuUP8i07Ikqzj0E8Nbzsulb/RR6ci2Oy WViV+CLou3cU7ce9mathr3OzQn2kwYMRjCnDfBL+K23CtCAm8G1oKct6Ipl5/if/bSE2 4uaJVUNxOFw4JTtWhmj0YpaS7avFgMAXv/K08rkWOD/DJ931tQ4Lkl0JBki2AuxFQRTE N6XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687950917; x=1690542917; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=q6lbXPbmTcGaZOMP0smhluu1MHt7x70jgOrGWtH71eI=; b=hw+G7fPjeUsqqTUMOJpDE4aPQUtP/C63GbYCHX20531YCjE5FYzB29kLS67YmUp4fc nNkjOfqrJLEgyqShdFUjtXH0CbRUvp8x1HPxEHNl3+AAGGlq/3JvY+o6uxgcH9KMBnIN xFea+xAQE5YmKG07mJkjoCOyKaeYDygdgLtoWz4bnxoncrVoU/BtgVKl1dnwY5FGVz+E HLeJDxhuWZh8hg2kR5cdMHSVnaJmrVeKlKOn0bud+tDPCtULhbxSvk0I4zUofSyOq5/k itC1OfBZWxvke6bdWvovEznCKjSQ9NzYgM7j5il+nOfsJvap1o3NdxLFf6J4os/UYI5o sesw== X-Gm-Message-State: AC+VfDyeHjFhc9b3yNRD9M3mPvF43mFVIg3ZhyS+YWlYwW23BO0ZdiWu jXqa1pmUpJ1a/cotVYJLfrI0O//vE4LdeZDNyQqu1td4JmE= X-Google-Smtp-Source: ACHHUZ4sem4nay+28x0o1haDWmJbYLuEJtKrF8H/CXyTFL4UXdMBqANeFU/IXGPjqaX4U96kN4kuoJ8ufsMauLvQRIY= X-Received: by 2002:ac8:5c12:0:b0:3ef:4a9b:5dca with SMTP id i18-20020ac85c12000000b003ef4a9b5dcamr42309082qti.29.1687950917540; Wed, 28 Jun 2023 04:15:17 -0700 (PDT) MIME-Version: 1.0 From: Julian Waters Date: Wed, 28 Jun 2023 19:14:37 +0800 Message-ID: Subject: Re: [PATCH] Basic asm blocks should always be volatile To: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000d69dbc05ff2eb287" X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d69dbc05ff2eb287 Content-Type: text/plain; charset="UTF-8" Hi all, I've revised the change to be much neater >From 480954bc7d2b24e5d19a98260a2be0b49e112c42 Mon Sep 17 00:00:00 2001 From: TheShermanTanker Date: Wed, 28 Jun 2023 19:11:34 +0800 Subject: [PATCH] asm not using extended syntax should always be volatile --- gcc/cp/parser.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index a6341b9..2d5d494 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -22355,7 +22355,7 @@ cp_parser_asm_definition (cp_parser* parser) /* Create the ASM_EXPR. */ if (parser->in_function_body) { - asm_stmt = finish_asm_stmt (asm_loc, volatile_p, string, outputs, + asm_stmt = finish_asm_stmt (asm_loc, !extended_p || volatile_p, string, outputs, inputs, clobbers, labels, inline_p); /* If the extended syntax was not used, mark the ASM_EXPR. */ if (!extended_p) -- 2.35.1.windows.2 --000000000000d69dbc05ff2eb287--