From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7F9BA3858D37 for ; Wed, 17 Aug 2022 10:29:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F9BA3858D37 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-624-rtg9R7_UNtSfH0OuJZ69_w-1; Wed, 17 Aug 2022 06:29:47 -0400 X-MC-Unique: rtg9R7_UNtSfH0OuJZ69_w-1 Received: by mail-oo1-f70.google.com with SMTP id b19-20020a4a3413000000b00448add2bb38so5614785ooa.11 for ; Wed, 17 Aug 2022 03:29:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=bqs6z4YBH5G86MnkImn0nEgYzd+hpvOcRfSb8vHuGPA=; b=1Fnw71sxY2Uk2X006qVDxNZHHgsMGoXNABbFiaTQqhmj/pTdSMrQ6i9kvHML9CSaOZ eDY1QRdfU4EtuWxWB63BbR2Un/Nb/E9dolKJimC80o8uEZG1rMSx10l28OcMwbJZYnSl GWy2XK5I4tMgm3cSzLHvTyB7v5yNz2HUE59W5khag+wtap/dzOM+zmWZ7c3GTVaL8KIl GFueS6YnnXWkhJ6foSOd++uD2I38bHvfCL15+98vm16hzXPXv2D6Uq/XoFryHAconbRn sCTz+FLtFxKIseoEicQpFLadtF3+pL0XzapMcNrNte1MLqmx4V5BdSeZknl+WEqSu3o7 H5pg== X-Gm-Message-State: ACgBeo2UkXasqEnQLzmhze7NVzWn8Yve3A1diZFwdoBu6BfWcNdP+tlk bs35XZYhC7Wek7K9mqz8dwPJYXkSEaJcETU3ZkZl6vnipX9shupyzsF1ayubdvV1K6J7QYGF+Nl 67xesav9HULbOwvAjKMMbhWwjwc9rMYO6iA== X-Received: by 2002:a05:6808:1a0d:b0:343:41aa:4c93 with SMTP id bk13-20020a0568081a0d00b0034341aa4c93mr1159102oib.188.1660732187256; Wed, 17 Aug 2022 03:29:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR6CQku9YE5UpWMkyUWCZ3BHSc3Z9dmPXBgHZoe7ihQiX5EuWcIdfySLDvHquvs86++hh4NPTICiM8OeshNBc6A= X-Received: by 2002:a05:6808:1a0d:b0:343:41aa:4c93 with SMTP id bk13-20020a0568081a0d00b0034341aa4c93mr1159094oib.188.1660732187028; Wed, 17 Aug 2022 03:29:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ulrich Drepper Date: Wed, 17 Aug 2022 12:29:36 +0200 Message-ID: Subject: Re: add more C++ name hints To: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 10:29:50 -0000 Any comment on this? These changes are low-risk so the only real objection I can see is that people don't deem these messages useful in the first place. I would hope, though, that some editors/IDEs provide one-click solutions to add the #includes. On Fri, Aug 5, 2022 at 9:35 PM Ulrich Drepper wrote: > How about adding a few more names from the std namespace to get > appropriate hints? This patch compiles and the appropriate messages are > printed. Is there a problem with just adding more or even at some point > all the symbols of the standard library? > > gcc/ChangeLog: > > * cp/name-lookup.cc (get_std_name_hint): Add more symbols from the > , , and headers. >