From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id 7679B3858D1E for ; Wed, 24 Jan 2024 05:57:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7679B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7679B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706075876; cv=none; b=S71HCnVXs0+4qac3Q9vZ5CTldLuy3mKn2bCFnkp4xXWLRNzWnLH/ngmN3blZgR4MpayK6CcX/RR3c1cP87VBEGyerzZ6B3eMVSUT8BzB0fG+DspMsRh9HyTEZHb3jpJRs6sjKi2g3TbnQhA3/kNvj/r2CNMCUuHZZWFUYQ5garg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706075876; c=relaxed/simple; bh=QF9+PWf9PestEiHSo7x/MM0vlty9XU3jTvktLdd3W3s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=RTXdv21LYa/MPYkRNGS2dXbLfxkx8ImaqtBjHCLzS5z9SNaQ5VPebjpJRVPCrSjwXWKzffpkH36rzaI8cE7gTxRVtCwgBdArGRoImUmARLab0hnHxxJtJYnhGTpoGHz721OziHRto1gnmAcHqRfZtuPTZ7pIlKLvcIWYWF/E9S0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-dc22ade26d8so3949164276.1 for ; Tue, 23 Jan 2024 21:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706075873; x=1706680673; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=zQxUu9oIaIKpKUpW5MuoWE8+uKkWiv1csfUaEZ4n5tM=; b=A9yVd/s4t/P/Q/wsS3Vvh811XxtFb9Vn+XiDu9LFJZcDjkB10dFd4qec5UIxhskXOU m7V6rfbleSIowI/S8p8o7NEieGhtIePigEtZLznVDICUiO7ER9/VzQQBYHCZeZmruqlP 3WQaze7XCg+NAx15yCM4WlZsqdXbt4zKNdgaPYOyYTl4QcLAnAbXlWYMm3WoRP1m5LYV tDLISZrcpv9JjBgANL3doRCxmybpKaite6d4EeHb+epWZl/5TX2NXzSUDBYN5yO3WaFx FGCzZ1G465ij0jTeEVFFsbI/uxaGweD3MNWAiQ0VNlrSJ1tmK1kd8A1tTwgbChUJH0MH 79JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706075873; x=1706680673; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zQxUu9oIaIKpKUpW5MuoWE8+uKkWiv1csfUaEZ4n5tM=; b=fYj1KJmGCMky72gMocGyHgxO+QJ5WNKQIW6F9N/OzSg3f2FPqizUCikcjtd/Ge8zRS k0zR46vywr1ybSHcSfhE4R47o0VZ203Cje56n/rw+YkosD+iByg8L/wEUy6R++f/fh0W 4Hoj1c2UX3Ld/snrpwUn24YyTZh4KuAL1xad9E788bzG/u1tH7F1nu4xHgznsyhjt9AB lfCOZ+cOJbROjfYThi5+HCuEZmBCcxdEGYlfWUjFl6p/hrfju/FpvFEKqf7GIkxLK/RC n0LtNJr8uHdJfbg2mjoRAc00e/5/ZN8OslstcOO/Wz1TP9DABGNoS2J1kmJJsVKPAO4C Dqsw== X-Gm-Message-State: AOJu0YyAai3O6Gv+BbwKGqZffJnmhUiEHzfXSjn1iZYy83MlByLq/flT pUYnT9Wqv7e8bJu4OSbeuf++TqnqEejL2uItbcskBqUwAckzfHLTdeZY4jyegit32XuxFOlSLtD DaYk/bqgNC+D465z7IHhMTqOw2HTJMRLgVS5V5g== X-Google-Smtp-Source: AGHT+IF/2HmQbizJ966nQcJTQwrC8e+S+y7Gmbh9GmtjW7I98K7WdCDlrrREKUjpLs8nRibVPfWaOhs2OatWU7+2U50= X-Received: by 2002:a25:ce0e:0:b0:dbe:9509:141c with SMTP id x14-20020a25ce0e000000b00dbe9509141cmr189573ybe.30.1706075873517; Tue, 23 Jan 2024 21:57:53 -0800 (PST) MIME-Version: 1.0 From: Jasmine Tang Date: Tue, 23 Jan 2024 21:57:41 -0800 Message-ID: Subject: [patch] PR 81271: gcc/cp/lex.c:116: wrong condition ? To: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="00000000000066eab7060faabe52" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_KAM_HTML_FONT_INVALID,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000066eab7060faabe52 Content-Type: multipart/alternative; boundary="00000000000066eab5060faabe50" --00000000000066eab5060faabe50 Content-Type: text/plain; charset="UTF-8" Change the style from & to && to reflect boolean result with boolean operation (instead of bitwise operation) David Binderman 2017-07-01 13:24:44 UTC trunk/gcc/cp/lex.c:116]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses. Source code is gcc_checking_assert (!IDENTIFIER_KIND_BIT_2 (id) & !IDENTIFIER_KIND_BIT_1 (id) & !IDENTIFIER_KIND_BIT_0 (id)); Maybe better code gcc_checking_assert (!IDENTIFIER_KIND_BIT_2 (id) && !IDENTIFIER_KIND_BIT_1 (id) && !IDENTIFIER_KIND_BIT_0 (id)); --00000000000066eab5060faabe50-- --00000000000066eab7060faabe52 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-compiler-warning-Boolean-result-is-used-in-bitwi.patch" Content-Disposition: attachment; filename="0001-Fix-compiler-warning-Boolean-result-is-used-in-bitwi.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lrrdfpun0 RnJvbSAxMGI1MDFmZmE4YTExYzdmMTBmZDZlNmFiNWQ5YTg3NmEzMjFmZTEz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKYXNtaW5lIDx0YW5n aG9jbGU0NTZAZ21haWwuY29tPgpEYXRlOiBUdWUsIDIzIEphbiAyMDI0IDIx OjE4OjEzIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGNvbXBpbGVyIHdh cm5pbmc6IEJvb2xlYW4gcmVzdWx0IGlzIHVzZWQgaW4gYml0d2lzZQogb3Bl cmF0aW9uCgotLS0KIGdjYy9jcC9sZXguY2MgfCA0ICsrLS0KIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvZ2NjL2NwL2xleC5jYyBiL2djYy9jcC9sZXguY2MKaW5kZXgg MTExMGRiN2Y4ZDAuLjhkOTRhZTFlN2IxIDEwMDY0NAotLS0gYS9nY2MvY3Av bGV4LmNjCisrKyBiL2djYy9jcC9sZXguY2MKQEAgLTEzNiw4ICsxMzYsOCBA QCB2b2lkCiBzZXRfaWRlbnRpZmllcl9raW5kICh0cmVlIGlkLCBjcF9pZGVu dGlmaWVyX2tpbmQga2luZCkKIHsKICAgZ2NjX2NoZWNraW5nX2Fzc2VydCAo IUlERU5USUZJRVJfS0lORF9CSVRfMiAoaWQpCi0JCSAgICAgICAmICFJREVO VElGSUVSX0tJTkRfQklUXzEgKGlkKQotCQkgICAgICAgJiAhSURFTlRJRklF Ul9LSU5EX0JJVF8wIChpZCkpOworCQkgICAgICAgJiYgIUlERU5USUZJRVJf S0lORF9CSVRfMSAoaWQpCisJCSAgICAgICAmJiAhSURFTlRJRklFUl9LSU5E X0JJVF8wIChpZCkpOwogICBJREVOVElGSUVSX0tJTkRfQklUXzIgKGlkKSB8 PSAoa2luZCA+PiAyKSAmIDE7CiAgIElERU5USUZJRVJfS0lORF9CSVRfMSAo aWQpIHw9IChraW5kID4+IDEpICYgMTsKICAgSURFTlRJRklFUl9LSU5EX0JJ VF8wIChpZCkgfD0gKGtpbmQgPj4gMCkgJiAxOwotLSAKMi4zNC4xCgo= --00000000000066eab7060faabe52--