From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id C80453858C52 for ; Sun, 3 Apr 2022 14:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C80453858C52 Received: by mail-wm1-x32f.google.com with SMTP id r11-20020a1c440b000000b0038ccb70e239so559175wma.3 for ; Sun, 03 Apr 2022 07:42:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=j8GbKUmM8x/OdnOYx30wApWQKMAYLx1Z1kO3SJ0ZKfo=; b=Bo114sq8+n81V6zJGbXErPjGMAhaUjRLtbLhnrVtP77gBMUU7mGkg1rKu9ria7nKk8 Ql8wcbvQMrwtiIxAHm1kGIPKFNYTlmG2+TyoaC1NItA1ZFhrlOLPRU1yz7wp+6HAmd/b ZbOpo5iTVHCMriFJhtuV3XXTatfwrEBK34926I4JWq50guZGpPtkcV4Q3U7mJP0iUTwQ qntjyElfsA9xw0BjasUaPitCKbQoozxMMlxSoxAidxPR+SVAKQhE36lZB8CqeCknXQbr 5Tt8cCHOftrv/49U0/A/FBgOtQhS5lvTEvMX1hjDBZrNoFNDV6ThYYvXlJ9AAHnDAreG M4vg== X-Gm-Message-State: AOAM531Gf6yRDtM9b9GrjzyMXgedvzTN6F3nQP+AX9CQqktth8BPgya/ LXWUvhxG533SFACzWjVjap3Z8JUslRgVJqNQgEsGf+GwN7c= X-Google-Smtp-Source: ABdhPJyO64AB5Mc/Ahr6mqPOxCsVpY6xjNRsM7nfqAM3POum9bjuNcbG8CFW+mWBV1oUC1zzH86rv9Tg3BMn0c4fyHI= X-Received: by 2002:a1c:7308:0:b0:38c:7b63:e385 with SMTP id d8-20020a1c7308000000b0038c7b63e385mr15887916wmb.116.1648996921043; Sun, 03 Apr 2022 07:42:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mohamed Atef Date: Sun, 3 Apr 2022 16:41:49 +0200 Message-ID: Subject: Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions To: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2022 14:42:07 -0000 Hi, I'd like to ping this patch. Thanks Mohamed On Sun, Mar 20, 2022 at 11:33 AM Mohamed Atef wrote: > hello, > I know it's too much. > we fixed the functions' names that are not part of the standard form ompd_ > * prefix to gompd_ > Thanks > > > On Wed, Mar 16, 2022 at 5:48 AM Mohamed Atef > wrote: > >> Hi, >> we found some typos in the ChangeLog and some wrong spaces (nightmare) >> in the files. >> So here's the best we can do. >> and please don't be disappointed and trust us we're doing our best. >> I hope you could review it by Sunday night. >> >> Thanks. >> >> >> libgomp/ChangeLog >> >> 2022-03-15 Mohamed Atef >> >> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >> *configure: Regenerate. >> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la. >> >> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK, >> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script, >> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New. >> *Makefile.in: Regenerate. >> *aclocal.m4: Regenerate. >> *env.c: Include ompd-support.h. >> (initialize_env): Call gompd_load. >> *team.c: Include ompd-support.h. >> (gomp_team_start): Call ompd_bp_parallel_begin. >> (gomp_team_end): Call ompd_bp_parallel_end. >> *libgomp.map: Add OMP_5.0.3 symbol versions. >> *libgompd.map: New. >> *omp-tools.h.in: New. >> *ompd-types.h.in: New. >> *ompd-support.h: New. >> *ompd-support.c: New. >> *ompd-helper.h: New. >> *ompd-helper.c: New. >> *ompd-init.c: New. >> *ompd-icv.c: New. >> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h. >> >> >> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef >> wrote: >> >>> >>> >>> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef >>> wrote: >>> >>>> This patch added OMPD support to libgomp, api version funcitos and >>>> global ICVs functions. >>>> I hope you review it as soon as possible, to fix the problems. >>>> I tried as much as I could to follow GNU standards. >>>> We have a seminar at the college next week, so we need this to be >>>> reviewed. >>>> Thanks >>>> >>>> >>>> libgomp/ChangeLog >>>> >>>> 2022-03-15 Mohamed Atef >>>> >>>> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>> *configure: Regenerate. >>>> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la >>>> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK, >>>> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script, >>>> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New. >>>> *Makefile.in: Regenerate. >>>> *aclocal.m4: Regenerate. >>>> *env.c: Include ompd-support.h. >>>> (initialize_env): Call gompd_load. >>>> *team.c: Include ompd-support.h. >>>> (gomp_team_start): Call ompd_bp_parallel_begin. >>>> (gomp_team_end): Call ompd_bp_parallel_end. >>>> *libgomp.map: Add OMP_5.0.3 symbol versions. >>>> *libgompd.map: New. >>>> *omp-tools.h.in: New. >>>> *ompd-types.h.in: New. >>>> *ompd-support.h: New. >>>> *ompd-support.c: New. >>>> *ompd-helper.h: New. >>>> *ompd-helper.c: New. >>>> *ompd-init.c: New. >>>> *ompd-icv.c: New. >>>> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h. >>>> >>>