From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id AD86E3858D32 for ; Sun, 15 May 2022 14:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD86E3858D32 Received: by mail-wm1-x32d.google.com with SMTP id q20so7377976wmq.1 for ; Sun, 15 May 2022 07:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cak9gADrrzlDiztxPUSDpQiHW3K02zEmF+iQKw8jKLQ=; b=EvAxMLyMlx+oGXOZZxf6Eck7g90EWsK0rlYT5qBInIF8f6KC60Su/bJRtw8x680529 LXDwFFg89P8jSf9XB7TSUvSRUpMA6PBA0Oqom1monZtYmqfnyKoAo2qVa19+BLI8fgxf mCnsbuLnOtLqfuC5goeAkUjsd0zT7P5md3TLuD0IfQE8Z+kdnoR9RORin3SenxvjLwBP ZQ9qOgp2eiCd6KdXrOkihwKZl0wz6tiaK88g1Bl5A5JgEvI97zSGHdR70+NNZl6nUb5b lxkOBqqXpoP30BvADLP9LYf+O+dhj2fwt1MHUAOK+1cd/KBD5AXVtr2QEdGhQm7TTuei rA4g== X-Gm-Message-State: AOAM531q/MSoDbCsiDNJIQXOpT6Ai6dLuRSHQWDbvLJwrCDDTNmsiluK U3UuQM4lxZH29kyezCQcH9XU1tTBz6MKuReNl4Y= X-Google-Smtp-Source: ABdhPJxvDKdwoBkdQyG11ZPr08n2zdyDY1NsQHqdIkifKcL2HqalZTV2Wj/eNSVVD6/PYDfr98/XNBeMmTDfbIVViP4= X-Received: by 2002:a05:600c:3595:b0:394:8343:a66d with SMTP id p21-20020a05600c359500b003948343a66dmr23590334wmq.49.1652625377199; Sun, 15 May 2022 07:36:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mohamed Atef Date: Sun, 15 May 2022 16:36:06 +0200 Message-ID: Subject: Re: libgompd: ADD OMPD support and global ICV functions To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2022 14:36:20 -0000 =D9=81=D9=8A =D8=A7=D9=84=D8=A3=D8=AD=D8=AF=D8=8C =D9=A1=D9=A5 =D9=85=D8=A7= =D9=8A=D9=88=D8=8C =D9=A2=D9=A0=D9=A2=D9=A2 =D9=A4:=D9=A1=D9=A8 =D9=85 Moha= med Atef =D9=83=D8=AA=D8=A8: > Ping > > =D9=81=D9=8A =D8=A7=D9=84=D8=AC=D9=85=D8=B9=D8=A9=D8=8C =D9=A1=D9=A3 =D9= =85=D8=A7=D9=8A=D9=88=D8=8C =D9=A2=D9=A0=D9=A2=D9=A2 =D9=A9:=D9=A1=D9=A9 = =D9=85 Mohamed Atef > =D9=83=D8=AA=D8=A8: > >> Hello Jakub, >> I am sorry, but should #ifdef __ELF__ put and separate file and also >> the actual functions (e.g. extern ompd_dll_location_valid (void)) >> I mean both in the same files or the functions should be in the >> omp-tools.h but with #ifndef __ELF__ >> >> >> Mohamed >> > I am pinging this not the patch. Thanks. > >> On Fri, May 13, 2022 at 8:27 PM Jakub Jelinek wrote: >> >>> On Fri, May 13, 2022 at 08:22:41PM +0200, Mohamed Atef wrote: >>> > > As I've tried to explain, this #ifdef __ELF__ doesn't belong >>> > > to the public header, which should contain just >>> > > extern void ompd_dll_locations_valid (void) __GOMPD_NOTHROW; >>> > > The #define should be in some internal header that is included >>> > > after the public one. >>> > > >>> > I will put the #define in ompd-support.h is that okay? >>> > And i will put ompd_bp_* labels there too. >>> >>> Ok. >>> >>> Jakub >>> >>>