Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

[Mohamed Atef <mohamedatef1698@gmail.com>]

Hi,
This is the second time i ping this patch.
I just remind you of it.

Mohamed

في الأحد، ٣ أبريل، ٢٠٢٢ ٤:٤١ م Mohamed Atef <mohamedatef1698@gmail.com> كتب:

> Hi,
>   I'd like to ping this patch.
> Thanks
>
> Mohamed
>
> On Sun, Mar 20, 2022 at 11:33 AM Mohamed Atef <mohamedatef1698@gmail.com>
> wrote:
>
>> hello,
>>    I know it's too much.
>> we fixed the functions' names that are not part of the standard form
>> ompd_ * prefix to gompd_
>> Thanks
>>
>>
>> On Wed, Mar 16, 2022 at 5:48 AM Mohamed Atef <mohamedatef1698@gmail.com>
>> wrote:
>>
>>> Hi,
>>>    we found some typos in the ChangeLog and some wrong spaces
>>> (nightmare) in the files.
>>> So here's the best we can do.
>>> and please don't be disappointed and trust us we're doing our best.
>>> I hope you could review it by Sunday night.
>>>
>>> Thanks.
>>>
>>>
>>> libgomp/ChangeLog
>>>
>>> 2022-03-15  Mohamed Atef  <mohamedatef1698@gmail.com>
>>>
>>> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>> *configure: Regenerate.
>>> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la.
>>> <http://libgompd.la>
>>> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK,
>>> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script,
>>> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New.
>>> *Makefile.in: Regenerate.
>>> *aclocal.m4: Regenerate.
>>> *env.c: Include ompd-support.h.
>>> (initialize_env): Call gompd_load.
>>> *team.c: Include ompd-support.h.
>>> (gomp_team_start): Call ompd_bp_parallel_begin.
>>> (gomp_team_end): Call ompd_bp_parallel_end.
>>> *libgomp.map: Add OMP_5.0.3 symbol versions.
>>> *libgompd.map: New.
>>> *omp-tools.h.in: New.
>>> *ompd-types.h.in: New.
>>> *ompd-support.h: New.
>>> *ompd-support.c: New.
>>> *ompd-helper.h: New.
>>> *ompd-helper.c: New.
>>> *ompd-init.c: New.
>>> *ompd-icv.c: New.
>>> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h.
>>>
>>>
>>> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef <mohamedatef1698@gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef <
>>>> mohamedatef1698@gmail.com> wrote:
>>>>
>>>>> This patch added OMPD support to libgomp, api version funcitos and
>>>>> global ICVs functions.
>>>>> I hope you review it as soon as possible, to fix the problems.
>>>>> I tried as much as I could to follow GNU standards.
>>>>> We have a seminar at the college next week, so we need this to be
>>>>> reviewed.
>>>>> Thanks
>>>>>
>>>>>
>>>>> libgomp/ChangeLog
>>>>>
>>>>> 2022-03-15  Mohamed Atef  <mohamedatef1698@gmail.com>
>>>>>
>>>>> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>>>> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>>>> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>>>>> *configure: Regenerate.
>>>>> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la
>>>>> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK,
>>>>> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script,
>>>>> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New.
>>>>> *Makefile.in: Regenerate.
>>>>> *aclocal.m4: Regenerate.
>>>>> *env.c: Include ompd-support.h.
>>>>> (initialize_env): Call gompd_load.
>>>>> *team.c: Include ompd-support.h.
>>>>> (gomp_team_start): Call ompd_bp_parallel_begin.
>>>>> (gomp_team_end): Call ompd_bp_parallel_end.
>>>>> *libgomp.map: Add OMP_5.0.3 symbol versions.
>>>>> *libgompd.map: New.
>>>>> *omp-tools.h.in: New.
>>>>> *ompd-types.h.in: New.
>>>>> *ompd-support.h: New.
>>>>> *ompd-support.c: New.
>>>>> *ompd-helper.h: New.
>>>>> *ompd-helper.c: New.
>>>>> *ompd-init.c: New.
>>>>> *ompd-icv.c: New.
>>>>> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h.
>>>>>
>>>>