From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 95FE93858D1E for ; Sun, 17 Apr 2022 19:16:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95FE93858D1E Received: by mail-wr1-x436.google.com with SMTP id b19so16408230wrh.11 for ; Sun, 17 Apr 2022 12:16:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kQMbVRMf/t33jhaOSnEaVkZgFprPB44+iBSlmWrnsGU=; b=mnI8r4XTwnvxu8oZCB6MyMXycWh/GFQHX0mRqpBdrTMLbx5lArPnkE0XbIF+K6kqOv JB5AxNC28HqO78/omdBx5sYPzA5BSkpE+VDQk4xxT6kVi1JeGetEf4Xaon1pRuK8G3o7 TAQI2nPtBoAwoVWr1rgqT86UPrUXzIcOmkXjD2EevuCxpxYA9GLyN5kWBqs+t0wbgcTo VtrrrWXG+6p3TT9K8349BFyR8cGpF7HIbHjug0PXskvRQTR//hK38uzcZs2YlcrB9sIr l/Bxo6UOBIzm9/s03MaalnFqOZHBj+SRF6VccD6QeUrr+g70ga6ZMqCd3VaCMKS3MOyN YwoA== X-Gm-Message-State: AOAM533I5kYXJkcvjwI/i4CRHfakM3DpJIDMzgunWA2Tdb/Nf5eJGWoE IVcWygENPM6AwsP6m6/iUhm4g7oEKCBt6nPVSvUUdq+h X-Google-Smtp-Source: ABdhPJztBuepgFQ70/eACntwNVmaRq+cQVxxvQRPnSjUmEV1w6OWFJh1trEig7338WlgCduxJ6MIezre4BvWKoS/djc= X-Received: by 2002:a5d:4143:0:b0:207:a9c0:d142 with SMTP id c3-20020a5d4143000000b00207a9c0d142mr6069816wrq.510.1650222980892; Sun, 17 Apr 2022 12:16:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mohamed Atef Date: Sun, 17 Apr 2022 21:16:08 +0200 Message-ID: Subject: Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions To: gcc-patches@gcc.gnu.org, Martin Jambor , Jakub Jelinek X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2022 19:16:25 -0000 Hi, This is the second time i ping this patch. I just remind you of it. Mohamed =D9=81=D9=8A =D8=A7=D9=84=D8=A3=D8=AD=D8=AF=D8=8C =D9=A3 =D8=A3=D8=A8=D8=B1= =D9=8A=D9=84=D8=8C =D9=A2=D9=A0=D9=A2=D9=A2 =D9=A4:=D9=A4=D9=A1 =D9=85 Moha= med Atef =D9=83=D8=AA=D8=A8: > Hi, > I'd like to ping this patch. > Thanks > > Mohamed > > On Sun, Mar 20, 2022 at 11:33 AM Mohamed Atef > wrote: > >> hello, >> I know it's too much. >> we fixed the functions' names that are not part of the standard form >> ompd_ * prefix to gompd_ >> Thanks >> >> >> On Wed, Mar 16, 2022 at 5:48 AM Mohamed Atef >> wrote: >> >>> Hi, >>> we found some typos in the ChangeLog and some wrong spaces >>> (nightmare) in the files. >>> So here's the best we can do. >>> and please don't be disappointed and trust us we're doing our best. >>> I hope you could review it by Sunday night. >>> >>> Thanks. >>> >>> >>> libgomp/ChangeLog >>> >>> 2022-03-15 Mohamed Atef >>> >>> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>> *configure: Regenerate. >>> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la. >>> >>> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK, >>> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script, >>> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New. >>> *Makefile.in: Regenerate. >>> *aclocal.m4: Regenerate. >>> *env.c: Include ompd-support.h. >>> (initialize_env): Call gompd_load. >>> *team.c: Include ompd-support.h. >>> (gomp_team_start): Call ompd_bp_parallel_begin. >>> (gomp_team_end): Call ompd_bp_parallel_end. >>> *libgomp.map: Add OMP_5.0.3 symbol versions. >>> *libgompd.map: New. >>> *omp-tools.h.in: New. >>> *ompd-types.h.in: New. >>> *ompd-support.h: New. >>> *ompd-support.c: New. >>> *ompd-helper.h: New. >>> *ompd-helper.c: New. >>> *ompd-init.c: New. >>> *ompd-icv.c: New. >>> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h. >>> >>> >>> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef >>> wrote: >>> >>>> >>>> >>>> On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef < >>>> mohamedatef1698@gmail.com> wrote: >>>> >>>>> This patch added OMPD support to libgomp, api version funcitos and >>>>> global ICVs functions. >>>>> I hope you review it as soon as possible, to fix the problems. >>>>> I tried as much as I could to follow GNU standards. >>>>> We have a seminar at the college next week, so we need this to be >>>>> reviewed. >>>>> Thanks >>>>> >>>>> >>>>> libgomp/ChangeLog >>>>> >>>>> 2022-03-15 Mohamed Atef >>>>> >>>>> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>>> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>>> *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >>>>> *configure: Regenerate. >>>>> * Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.la >>>>> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK, >>>>> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script, >>>>> libgompd.ver-sun, libgompd.ver, libgompd_version_info): New. >>>>> *Makefile.in: Regenerate. >>>>> *aclocal.m4: Regenerate. >>>>> *env.c: Include ompd-support.h. >>>>> (initialize_env): Call gompd_load. >>>>> *team.c: Include ompd-support.h. >>>>> (gomp_team_start): Call ompd_bp_parallel_begin. >>>>> (gomp_team_end): Call ompd_bp_parallel_end. >>>>> *libgomp.map: Add OMP_5.0.3 symbol versions. >>>>> *libgompd.map: New. >>>>> *omp-tools.h.in: New. >>>>> *ompd-types.h.in: New. >>>>> *ompd-support.h: New. >>>>> *ompd-support.c: New. >>>>> *ompd-helper.h: New. >>>>> *ompd-helper.c: New. >>>>> *ompd-init.c: New. >>>>> *ompd-icv.c: New. >>>>> *configure.ac (AC_CONFIG_FILES): Add omp-tools.h and ompd-types.h. >>>>> >>>>