From: Tim Song <t.canens.cpp@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [committed] libstdc++: P1964R2 Wording for boolean-testable
Date: Mon, 17 Feb 2020 21:27:00 -0000 [thread overview]
Message-ID: <CAPQZVxuQEQ5AmYJXFOFrGj49T6X60phRhLTg2akUF6NiWQ+N5g@mail.gmail.com> (raw)
In-Reply-To: <20200217183352.GA1574923@redhat.com>
On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> This removes the complicated std::boolean concept, as agreed in Prague.
>
> * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn)
> (__adjacent_find_fn): Cast result of predicate to bool.
Um, why? These look fine without the cast. (The WP was doing == false,
which is a different matter.)
> * include/std/concepts (__boolean): Remove.
> (__detail::__boolean_testable_impl, __detail::__boolean_testable):
> Add
> new helper concepts.
> (__detail::__weakly_eq_cmp_with, totally_ordered,
> totally_ordered_with)
> (predicate): Use __boolean_testable instead of boolean.
> * libsupc++/compare (__detail::__partially_ordered, _Synth3way):
> Likewise.
>
> Tested powerpc64le-linux, committed to master.
>
>
next prev parent reply other threads:[~2020-02-17 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 18:34 Jonathan Wakely
2020-02-17 21:27 ` Tim Song [this message]
2020-02-18 13:49 ` Jonathan Wakely
2020-02-19 10:57 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPQZVxuQEQ5AmYJXFOFrGj49T6X60phRhLTg2akUF6NiWQ+N5g@mail.gmail.com \
--to=t.canens.cpp@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).