From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52165 invoked by alias); 17 Feb 2020 21:27:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52146 invoked by uid 89); 17 Feb 2020 21:27:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*c:alternative X-HELO: mail-ot1-f53.google.com Received: from mail-ot1-f53.google.com (HELO mail-ot1-f53.google.com) (209.85.210.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 21:27:28 +0000 Received: by mail-ot1-f53.google.com with SMTP id r27so17458413otc.8; Mon, 17 Feb 2020 13:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NoLvLerwopbngavOkpVdEtQ4+4piwnttGa60DZwUwcM=; b=W0Iw0V3DLartHBZAnGh93OR/hGL1RhwlL2kPGNNpLoxc0ama1QD09RjEw/3Pz8KBN3 p4DL8EwM4wHFDG3QonbnCLP9VaJX89BwZe7r8Vm82sxvwM6U835KKGjmP+owKJL/NS45 bLzsoioUSyvvqZZi+/T9/6ynRvetxy7sGbEZJR12jiOmEUnVh3LHSfSiqw03DrBIbnLZ IK1m90kq92BnTEJ16daVzXZdQoXnKogNqx3mskh3TF+GeHfR/vQO2NsnAdfWIjndxwXk 6Vmv4JJzeD3Fl40e+H23PmcsojYrZl9pdtUetuFdI9hXdR0yg5fSjW3vk4Hm4CMqV/rG f/RQ== MIME-Version: 1.0 References: <20200217183352.GA1574923@redhat.com> In-Reply-To: <20200217183352.GA1574923@redhat.com> From: Tim Song Date: Mon, 17 Feb 2020 21:27:00 -0000 Message-ID: Subject: Re: [committed] libstdc++: P1964R2 Wording for boolean-testable To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00985.txt.bz2 On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: > This removes the complicated std::boolean concept, as agreed in Prague. > > * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) > (__adjacent_find_fn): Cast result of predicate to bool. Um, why? These look fine without the cast. (The WP was doing == false, which is a different matter.) > * include/std/concepts (__boolean): Remove. > (__detail::__boolean_testable_impl, __detail::__boolean_testable): > Add > new helper concepts. > (__detail::__weakly_eq_cmp_with, totally_ordered, > totally_ordered_with) > (predicate): Use __boolean_testable instead of boolean. > * libsupc++/compare (__detail::__partially_ordered, _Synth3way): > Likewise. > > Tested powerpc64le-linux, committed to master. > >