From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id BEF983858D37 for ; Mon, 18 Mar 2024 13:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEF983858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEF983858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710768852; cv=none; b=lxUFmEpt/9UHOYeoXx4mQnPMSR5nDu+c2yORTr9OcG5rmx9l60fn2IUXNGmNfb3UfGeHTG4C9sHikNuiD2fuaUoP8t6wFOlNHQSSumGdkr/iyDttDuGr0C01eQnjDakwmGdWk4YwqUkjIi03HVnM2pf9PKUgUNepnEbieUPP2gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710768852; c=relaxed/simple; bh=VOMerWFx2kIl0vj4ZrX2SCIYhGfnuA2d092PkKKIZf4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ftU4wuMYGN+4Y9DsLwrp1V3LNOshy4tkeqjFDtWRzeDAaOayiWkuYMPotvMmPmFSKfnDanrXOn4y2t8tI9TnUkjnuy0fYs9oUvcajsNSGrQu56YxBOtRHHfHGu/EObNeobQf08O4+wtpdxHvNWO9klfigtrKaqzx3qqHxHRjVP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a46ba938de0so160358266b.3 for ; Mon, 18 Mar 2024 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710768840; x=1711373640; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VOMerWFx2kIl0vj4ZrX2SCIYhGfnuA2d092PkKKIZf4=; b=MM3TFMrSSoF+O4i7wfOPM2dpeJ4qOr7lSCnEntXkSVBdWCqlOCOEzBAcjvBFFvQZZu SHUKXTSx63c+Tw5qDBAcZ9jYpu1mrUD/ZlilZkGu6eLAIuNzQU8cr6+vi1t3RcU9UMA0 HuRPqN9AGMDVMvRvl4D8DmBQKLpYFpAy69/JsWC0EV04YwNC9tcjKbMOd6OUroeygESE z9r54GVX8Qlga8hAb33v7v/XJSBHMUWyFfTN00zDiNmFPxsrJfgQ3LUkiQh2oc1h41IW pdZOxIdGmwUSKs27M0naRHM5IZ+qo77tpHX0CrJkGuAbZY3jS/Y5A0tP9dnoBGoDfdOo Eu3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710768840; x=1711373640; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VOMerWFx2kIl0vj4ZrX2SCIYhGfnuA2d092PkKKIZf4=; b=OUrof6uvDyqNN6Jy+m5m2iABKFNqu5mpQYfj0Vv4zJwbTFsv2rZkbsU8fZi8MMcchm xu901ilkzjckZdk3MZbGKw5hBz4+F1+Th03G8JLEodt4mCpMRpzwV9GhtPgz86B2kbVn c1Rlou+O4TW/+RK+u0IF/Oz3lC4Md9jgCwbqsCBnRTQsGjksCumNDOHdJernl/DnnkcI jNZCQqaDrmTWseX3pWxrgJMhKW/aJxKx1rPXE7PVAFix+tRQBtmP+/ZKql9CzjEOa+h+ P6VhW6jsEc6W8Km7s92S93SwH+N+owiN8lC7Ogo35zJy1T7GE0jdiLo/hKauASqiCjKD cs0g== X-Gm-Message-State: AOJu0YzJCgaL01ARo0qSjNP8SQe1K0x57edfGTayFDjG4rtgEyss8ySk QWZOqD24xlQh5rUCtX8l+UYeKTo0OAT/8FQaZpQzWIHusrKoH+YmwfP2O1HZfMT+Tqarcvuiaft no9zmcpF5ZvSf1SZJtqt/dCBYXA9eBPp1Vex9aw== X-Google-Smtp-Source: AGHT+IEZ+A6nlCo2gTGOwhESIcBkRjtTd3cd0ieptQtVp1LNRMYhgYHyfkEGU0IttcfuM7bdWzF+1jjfd3UX9/vGABQ= X-Received: by 2002:a17:906:24da:b0:a46:b111:858b with SMTP id f26-20020a17090624da00b00a46b111858bmr3421616ejb.47.1710768840461; Mon, 18 Mar 2024 06:34:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Mon, 18 Mar 2024 14:33:50 +0100 Message-ID: Subject: Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target To: Evgeny Karpov Cc: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" , "Richard Earnshaw (lists)" , "Andrew Pinski (QUIC)" , Maxim Kuvyrkov , Radek Barton Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Mar 2024 at 21:48, Evgeny Karpov wrote: > > Monday, March 4, 2024 > Evgeny Karpov wrote: > > > > > Changes from v1 to v2: > > Adjust the target name to aarch64-*-mingw* to exclude the big-endian target > > from support. > > Exclude 64-bit ISA. > > Rename enum calling_abi to aarch64_calling_abi. > > Move AArch64 MS ABI definitions FIXED_REGISTERS, > > CALL_REALLY_USED_REGISTERS, and STATIC_CHAIN_REGNUM from aarch64.h > > to aarch64-abi-ms.h. > > Rename TARGET_ARM64_MS_ABI to TARGET_AARCH64_MS_ABI. > > Exclude TARGET_64BIT from the aarch64 target. > > Exclude HAVE_GAS_WEAK. > > Set HAVE_GAS_ALIGNED_COMM to 1 by default. > > Use a reference from "x86 Windows Options" to "Cygwin and MinGW > > Options". > > Update commit descriptions to follow standard style. > > Rebase from 4th March 2024. > > Hello, > > It looks like the initial feedback has been addressed. I had a look at the v2 series, and besides a minor comment patch #8, ISTM than all the comments your received about v1 have been addressed, indeed. > While unit testing for the x86_64-w64-mingw32 target is still in > progress, the first 4 patches do not obviously change other > targets, including aarch64-linux-gnu. > Could they be merged once stage 1 starts, > or could it be done even now? What would be the benefit of committing only the first 4 patches? (whether now or when stage 1 reopens) Thanks, Christophe > Thanks! > > Regards, > Evgeny >