From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 8532E3858C33 for ; Tue, 9 May 2023 19:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8532E3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bc0ced1d9so9569929a12.0 for ; Tue, 09 May 2023 12:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683659656; x=1686251656; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RgxlEBL/h1yqHS5wGis9a5s2OYNUSmcAPoCOubYgZCU=; b=azo93Oy9PYgpqcmHtAzOXbTzIluu+6CCtc8sEro8Ck/RiBbF1VFXizZto3nlSoFUyK 0bHmVoaLM6qjmQ9x8UP+RWoqpRpflHhb0N4vJ8PF17xN2Y00/UGmKLP5WT2camlSlG9H CqSMXb4w5D3CyoteCO/DEcgU9U+lh6zTJZ2v5LJr2/ybeaXez+/0ExikvafNgjbYsqxn aABN6eqTSPhaJwo9egA0MlqjuNLRwXH+fCTVAtXDygrXSMNyVOuPOw0X/xmdONt78RZ5 ZAmUwlvf4r8aUo918E6YzJwD24SvyTD1a+7GmSKT6QRln5HUVuYwTQlmc5xU9Wna0SGf kvEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683659656; x=1686251656; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RgxlEBL/h1yqHS5wGis9a5s2OYNUSmcAPoCOubYgZCU=; b=hZSr9IzP6mgrBBu98efXazsnyGv85wHgShNBqTVNxfGRKObgD8kOLi60pE/ORly8BZ nT/SCE/HuFWVnf4vmll8hIIYbaxZpXKEUQAVUMMN5pdpT1TbnIMzjKtxb8ATzH/sG4ge 364ds8YspEW8uWNn9Sy1IPIZAHwH9up5orEfM2zddg5YC+3Z65Q3dLYfuENpIfiZ64Qz C7Mjf/7KutB9oC8VM4To+A550OzN/qh54Nd1afr6UF4buNGDJ39VRbN2xCgFeC4aDWRG 7+0C3PxLtR1C7j2tmlhdMw8JPzcB7akko3MXq2naLd5N3VOf+XgNKH08EigozrVWH15n bv+A== X-Gm-Message-State: AC+VfDwvenpwzZFmhmEgmgLl9Pkr4g+1m9+OplLS+91g88cFHWELb1Q7 xB2q9ioLYnX3ViH1VGqeH8UygV6PAMjgeyRxdl6dOA== X-Google-Smtp-Source: ACHHUZ41c1bexaBE2FEvU4TbLSAalbYRTtgCZAwr9oqQmcYxGltbzYK7f7i/N9j1dKeefa/ssrbVLcsjHMXoXMUx+yQ= X-Received: by 2002:a05:6402:b2c:b0:50b:d470:4118 with SMTP id bo12-20020a0564020b2c00b0050bd4704118mr13044338edb.18.1683659656252; Tue, 09 May 2023 12:14:16 -0700 (PDT) MIME-Version: 1.0 References: <20110927172322.GA21068@kam.mff.cuni.cz> <875y99d5rt.fsf@euler.schwinge.homeip.net> <87lehxswug.fsf@euler.schwinge.homeip.net> In-Reply-To: From: Christophe Lyon Date: Tue, 9 May 2023 21:14:07 +0200 Message-ID: Subject: Re: Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS') To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, Richard Biener , Jan Hubicka , Rainer Orth , Mike Stump Content-Type: multipart/alternative; boundary="000000000000bbef6605fb478f3c" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000bbef6605fb478f3c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Thomas, On Tue, 9 May 2023 at 17:17, Christophe Lyon wrote: > Hi! > > On Tue, 9 May 2023 at 11:00, Thomas Schwinge > wrote: > >> Hi Christophe! >> >> On 2023-05-09T09:32:55+0200, Christophe Lyon >> wrote: >> > On Wed, 3 May 2023 at 13:47, Richard Biener via Gcc-patches < >> gcc-patches@gcc.gnu.org> wrote: >> >> On Wed, 3 May 2023, Thomas Schwinge wrote: >> >> > "Let each 'lto_init' determine the default 'LTO_OPTIONS', and >> 'torture-init' the 'LTO_TORTURE_OPTIONS'"? >> > >> > This is causing issues on arm/aarch64, including: >> > >> > ERROR: can't read "LTO_TORTURE_OPTIONS": no such variable >> > in gcc.target/arm/acle/acle.exp: >> > >> > ERROR: torture-init: LTO_TORTURE_OPTIONS is not empty as expected >> > in gcc.target/aarch64/sls-mitigation/sls-mitigation.exp, >> > gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp, >> > gcc.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp, >> > gcc.target/aarch64/torture/aarch64-torture.exp >> > >> > and maybe others >> > >> > Are other targets affected too? >> >> Sorry for that -- it means, the safe-guards I added are working as >> expected. >> >> Please test whether all these issues are gone with the attached >> "Testsuite: Add missing 'torture-init'/'torture-finish' around >> 'LTO_TORTURE_OPTIONS' usage"? >> >> > Your patch seemed reasonable, but it doesn't work :-( > > Well now I get: > ERROR: torture-init: LTO_TORTURE_OPTIONS is not empty as expected > because gcc-dg-runtest itself calls torture-init > > but I'm not sure where LTO_TORTURE_OPTIONS is set > > Just checking, are you able to test your changes on arm (a cross toolchain is OK) ? The problem shows up even if running only acle.exp, so it's quick once you have built the toolchain once. I spent some time looking at it, and the conflict is that the .exp file calls torture-init and gcc-dg-runtest, which in turn calls torture-init again, leading to the error. I haven't checked the details of why there are similar failures on aarch64. Thanks, Christophe > Christophe > > >> Gr=C3=BC=C3=9Fe >> Thomas >> >> >> ----------------- >> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, >> 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: >> Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; >> Registergericht M=C3=BCnchen, HRB 106955 >> > --000000000000bbef6605fb478f3c--