Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

[Christophe Lyon <christophe.lyon@linaro.org>]

Hi!

On Mon, 4 Mar 2024 at 18:44, Evgeny Karpov <Evgeny.Karpov@microsoft.com> wrote:
>
> From: Zac Walker <zacwalker@microsoft.com>
> Date: Fri, 1 Mar 2024 10:49:28 +0100
> Subject: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for
>  AArch64
>
> Define Cygwin and MinGW environment such as types, SEH definitions,
> shared libraries, etc.
>
> gcc/ChangeLog:
>
>         * config.gcc: Add Cygwin and MinGW difinitions.
>         * config/aarch64/aarch64-protos.h
>         (mingw_pe_maybe_record_exported_symbol): Declare functions
>         which are used in Cygwin and MinGW environment.
>         (mingw_pe_section_type_flags): Likewise.
>         (mingw_pe_unique_section): Likewise.
>         (mingw_pe_encode_section_info): Likewise.
>         * config/aarch64/cygming.h: New file.
> ---
>  gcc/config.gcc                      |   4 +
>  gcc/config/aarch64/aarch64-protos.h |   5 +
>  gcc/config/aarch64/cygming.h        | 175 ++++++++++++++++++++++++++++
>  3 files changed, 184 insertions(+)
>  create mode 100644 gcc/config/aarch64/cygming.h
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 3aca257c322..4471599454b 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -1267,7 +1267,11 @@ aarch64*-*-linux*)
>  aarch64-*-mingw*)
>         tm_file="${tm_file} aarch64/aarch64-abi-ms.h"
>         tm_file="${tm_file} aarch64/aarch64-coff.h"
> +       tm_file="${tm_file} aarch64/cygming.h"
> +       tm_file="${tm_file} mingw/mingw32.h"
> +       tm_file="${tm_file} mingw/mingw-stdint.h"
>         tmake_file="${tmake_file} aarch64/t-aarch64"
> +       target_gtfiles="$target_gtfiles \$(srcdir)/config/mingw/winnt.cc"
>         case ${enable_threads} in
>           "" | yes | win32)
>             thread_file='win32'
> diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h
> index bd719b992a5..759e1a0f9da 100644
> --- a/gcc/config/aarch64/aarch64-protos.h
> +++ b/gcc/config/aarch64/aarch64-protos.h
> @@ -1110,6 +1110,11 @@ extern void aarch64_output_patchable_area (unsigned int, bool);
>
>  extern void aarch64_adjust_reg_alloc_order ();
>
> +extern void mingw_pe_maybe_record_exported_symbol (tree, const char *, int);
> +extern unsigned int mingw_pe_section_type_flags (tree, const char *, int);
> +extern void mingw_pe_unique_section (tree, int);
> +extern void mingw_pe_encode_section_info (tree, rtx, int);
> +
>  bool aarch64_optimize_mode_switching (aarch64_mode_entity);
>  void aarch64_restore_za (rtx);
>
> diff --git a/gcc/config/aarch64/cygming.h b/gcc/config/aarch64/cygming.h
> new file mode 100644
> index 00000000000..2f239c42a89
> --- /dev/null
> +++ b/gcc/config/aarch64/cygming.h
> @@ -0,0 +1,175 @@
> +/* Operating system specific defines to be used when targeting GCC for
> +   hosting on Windows32, using a Unix style C library and tools.
> +   Copyright (C) 1995-2024 Free Software Foundation, Inc.
> +
> +This file is part of GCC.
> +
> +GCC is free software; you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation; either version 3, or (at your option)
> +any later version.
> +
> +GCC is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with GCC; see the file COPYING3.  If not see
> +<http://www.gnu.org/licenses/>.  */
> +
> +#ifndef GCC_AARCH64_CYGMING_H
> +#define GCC_AARCH64_CYGMING_H
> +
> +#undef PREFERRED_DEBUGGING_TYPE
> +#define PREFERRED_DEBUGGING_TYPE DINFO_TYPE_NONE
> +
> +#define FASTCALL_PREFIX '@'
> +
> +#define print_reg(rtx, code, file)
> +
> +#define SYMBOL_FLAG_DLLIMPORT 0
> +#define SYMBOL_FLAG_DLLEXPORT 0
> +
> +#define SYMBOL_REF_DLLEXPORT_P(X) \
> +       ((SYMBOL_REF_FLAGS (X) & SYMBOL_FLAG_DLLEXPORT) != 0)
> +
> +/* Disable SEH and declare the required SEH-related macros that are
> +still needed for compilation.  */
> +#undef TARGET_SEH
> +#define TARGET_SEH 0
> +
> +#define SSE_REGNO_P(N) 0
> +#define GENERAL_REGNO_P(N) 0
I think you forgot to add a comment to explain the above two lines.
(it was requested during v1 review)

Thanks,

Christophe

> +#define SEH_MAX_FRAME_SIZE 0
> +
> +#undef DEFAULT_ABI
> +#define DEFAULT_ABI AARCH64_CALLING_ABI_MS
> +
> +#undef TARGET_PECOFF
> +#define TARGET_PECOFF 1
> +
> +#include <stdbool.h>
> +#ifdef __MINGW32__
> +#include <stdio.h>
> +#endif
> +
> +extern void mingw_pe_asm_named_section (const char *, unsigned int, tree);
> +extern void mingw_pe_declare_function_type (FILE *file, const char *name,
> +       int pub);
> +
> +#define TARGET_ASM_NAMED_SECTION  mingw_pe_asm_named_section
> +
> +/* Select attributes for named sections.  */
> +#define TARGET_SECTION_TYPE_FLAGS  mingw_pe_section_type_flags
> +
> +#define TARGET_ASM_UNIQUE_SECTION mingw_pe_unique_section
> +#define TARGET_ENCODE_SECTION_INFO  mingw_pe_encode_section_info
> +
> +/* Declare the type properly for any external libcall.  */
> +#define ASM_OUTPUT_EXTERNAL_LIBCALL(FILE, FUN) \
> +  mingw_pe_declare_function_type (FILE, XSTR (FUN, 0), 1)
> +
> +#define TARGET_OS_CPP_BUILTINS()                                       \
> +  do                                                                   \
> +    {                                                                  \
> +      builtin_define ("__MSVCRT__");                                   \
> +      builtin_define ("__MINGW32__");                                  \
> +      builtin_define ("_WIN32");                                       \
> +      builtin_define_std ("WIN32");                                    \
> +      builtin_define_std ("WINNT");                                    \
> +      builtin_define_with_int_value ("_INTEGRAL_MAX_BITS",             \
> +                               TYPE_PRECISION (intmax_type_node));     \
> +      builtin_define ("__MINGW64__");                                  \
> +      builtin_define_std ("WIN64");                                    \
> +      builtin_define ("_WIN64");                                       \
> +      builtin_define ("__stdcall=__attribute__((__stdcall__))");       \
> +      builtin_define ("__fastcall=__attribute__((__fastcall__))");     \
> +      builtin_define ("__thiscall=__attribute__((__thiscall__))");     \
> +      builtin_define ("__cdecl=__attribute__((__cdecl__))");           \
> +    }                                                                  \
> +  while (0)
> +
> +/* Windows64 continues to use a 32-bit long type.  */
> +#undef LONG_TYPE_SIZE
> +#define LONG_TYPE_SIZE 32
> +
> +#undef DEFAULT_SIGNED_CHAR
> +#define DEFAULT_SIGNED_CHAR 1
> +
> +#undef SIZE_TYPE
> +#undef PTRDIFF_TYPE
> +#define SIZE_TYPE "long long unsigned int"
> +#define PTRDIFF_TYPE "long long int"
> +
> +#undef WCHAR_TYPE_SIZE
> +#undef WCHAR_TYPE
> +#define WCHAR_TYPE_SIZE 16
> +#define WCHAR_TYPE "short unsigned int"
> +
> +#define drectve_section() \
> +  (fprintf (asm_out_file, "\t.section\t.drectve\n"), \
> +   in_section = NULL)
> +
> +
> +/* Enable alias attribute support.  */
> +#ifndef SET_ASM_OP
> +#define SET_ASM_OP "\t.set\t"
> +#endif
> +
> +/* GNU as supports weak symbols on PECOFF.  */
> +#define ASM_WEAKEN_LABEL(FILE, NAME)   \
> +  do                                   \
> +    {                                  \
> +      fputs ("\t.weak\t", (FILE));     \
> +      assemble_name ((FILE), (NAME));  \
> +      fputc ('\n', (FILE));            \
> +    }                                  \
> +  while (0)
> +
> +/* Get tree.cc to declare a target-specific specialization of
> +   merge_decl_attributes.  */
> +#define TARGET_DLLIMPORT_DECL_ATTRIBUTES 1
> +
> +#define ASM_OUTPUT_ADDR_DIFF_ELT(STREAM, BODY, VALUE, REL)             \
> +  do {                                                                 \
> +    switch (GET_MODE (BODY))                                           \
> +      {                                                                        \
> +      case E_QImode:                                                   \
> +       asm_fprintf (STREAM, "\t.byte\t(%LL%d - %LLrtx%d) / 4\n",       \
> +                    VALUE, REL);                                       \
> +       break;                                                          \
> +      case E_HImode:                                                   \
> +       asm_fprintf (STREAM, "\t.2byte\t(%LL%d - %LLrtx%d) / 4\n",      \
> +                    VALUE, REL);                                       \
> +       break;                                                          \
> +      case E_SImode:                                                   \
> +      case E_DImode: /* See comment in aarch64_output_casesi.  */      \
> +       asm_fprintf (STREAM, "\t.word\t(%LL%d - %LLrtx%d) / 4\n",       \
> +                    VALUE, REL);                                       \
> +       break;                                                          \
> +      default:                                                         \
> +       gcc_unreachable ();                                             \
> +      }                                                                        \
> +  } while (0)
> +
> +#define READONLY_DATA_SECTION_ASM_OP "\t.section\t.rdata,\"dr\""
> +
> +#undef  SUBTARGET_OVERRIDE_OPTIONS
> +#define SUBTARGET_OVERRIDE_OPTIONS                     \
> +  do {                                                 \
> +    flag_stack_check = STATIC_BUILTIN_STACK_CHECK;     \
> +  } while (0)
> +
> +
> +#define SUPPORTS_ONE_ONLY 1
> +
> +/* Define this to be nonzero if static stack checking is supported.  */
> +#define STACK_CHECK_STATIC_BUILTIN 1
> +
> +#define HAVE_GAS_ALIGNED_COMM 1
> +
> +#undef MAX_OFILE_ALIGNMENT
> +#define MAX_OFILE_ALIGNMENT (8192 * 8)
> +
> +#endif
> --
> 2.25.1
>