From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id C989C3857721 for ; Tue, 9 May 2023 15:17:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C989C3857721 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-50b9ef67f35so10925210a12.2 for ; Tue, 09 May 2023 08:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683645468; x=1686237468; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bj2dsE3p/0Pc4nk3WLKnf7s5u/ty3poyBIBOTNSU9HQ=; b=BfW9GF8+kSMeh2xvEh53YQw1s6GAy5cEA7H0OUPu/pK8bYep1h+PAfeYAG6cC9CmZi jgdZgYJgdI2ep0iV6qUCwZO6eCLqgsh3Eydegb5MYXCO+kmstTLhzMjcSl1Yo0uWX5sS IEjuRyFx3zU2/Y+R4IRxrbQ5msGx81Xi6U1o9JTSAtEJWw7eGRUVf0NFmvPsO9frmwHe KgamWKWsA8e3RU23vc+Kq0chLqlAgDAYHoDgEmHNxoF6JUwkDPpS+Xj2SCn8a97dn/K3 2axTYS3U9nZA22f/9A2KbzFIdJwj6Mou5tUHouQWzsU2jLaHd+AN27MXDTNqd9OdohKW ZJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645468; x=1686237468; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bj2dsE3p/0Pc4nk3WLKnf7s5u/ty3poyBIBOTNSU9HQ=; b=aD2qKwzddn5m4MPgrz4nPCVFEc8bt27aoe9IL093eh3W1DyunsvshhSMAYVyjRg5WN 1TUTgX8uQ6W8I3EjbjC9eff6/vgyP69Cx5rB1hoIQhvPfAw6iPN6bany+erviSjs+S/b 340OfmfxCWHlba7htLDm9dlDBwMkkKU3M0f2obPFH8FpHYkwOx0cSqquLhDwq1eJ13QH kDTp3XhTZMKt0N/RzEExbvmXOOwotLTfZIvoGINA1o/rnRC0DPW75xK+HY8LbYHHafrD BNcKhW9Eozx/L096NspkgOC+VsjW6CKq4PQhviWFas1VnsvAdvPKSmMgqz+7fxiHqHvs 2xSQ== X-Gm-Message-State: AC+VfDwDeEY1667cqcZNh8sH78Z777N+s9Bd7hmAPpLNuR+bajvC+54N KAQK/guIL68hXTm/l4LG7br5OZnADBrk7ym2zPSDXRQIgaqY9L/kaTht3pBW X-Google-Smtp-Source: ACHHUZ5dQHC+2ACOCsK743+mkDENNWwJaQCTK0PBDIBEP76RbdFG4zab5XGmRpxqSSc1hBe8zpGv0XvbNpHZd2PX1Bg= X-Received: by 2002:a50:ef05:0:b0:50d:682d:d431 with SMTP id m5-20020a50ef05000000b0050d682dd431mr11614951eds.16.1683645468535; Tue, 09 May 2023 08:17:48 -0700 (PDT) MIME-Version: 1.0 References: <20110927172322.GA21068@kam.mff.cuni.cz> <875y99d5rt.fsf@euler.schwinge.homeip.net> <87lehxswug.fsf@euler.schwinge.homeip.net> In-Reply-To: <87lehxswug.fsf@euler.schwinge.homeip.net> From: Christophe Lyon Date: Tue, 9 May 2023 17:17:39 +0200 Message-ID: Subject: Re: Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS') To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, Richard Biener , Jan Hubicka , Rainer Orth , Mike Stump Content-Type: multipart/alternative; boundary="00000000000014885805fb444271" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000014885805fb444271 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! On Tue, 9 May 2023 at 11:00, Thomas Schwinge wrote: > Hi Christophe! > > On 2023-05-09T09:32:55+0200, Christophe Lyon > wrote: > > On Wed, 3 May 2023 at 13:47, Richard Biener via Gcc-patches < > gcc-patches@gcc.gnu.org> wrote: > >> On Wed, 3 May 2023, Thomas Schwinge wrote: > >> > "Let each 'lto_init' determine the default 'LTO_OPTIONS', and > 'torture-init' the 'LTO_TORTURE_OPTIONS'"? > > > > This is causing issues on arm/aarch64, including: > > > > ERROR: can't read "LTO_TORTURE_OPTIONS": no such variable > > in gcc.target/arm/acle/acle.exp: > > > > ERROR: torture-init: LTO_TORTURE_OPTIONS is not empty as expected > > in gcc.target/aarch64/sls-mitigation/sls-mitigation.exp, > > gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp, > > gcc.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp, > > gcc.target/aarch64/torture/aarch64-torture.exp > > > > and maybe others > > > > Are other targets affected too? > > Sorry for that -- it means, the safe-guards I added are working as > expected. > > Please test whether all these issues are gone with the attached > "Testsuite: Add missing 'torture-init'/'torture-finish' around > 'LTO_TORTURE_OPTIONS' usage"? > > Your patch seemed reasonable, but it doesn't work :-( Well now I get: ERROR: torture-init: LTO_TORTURE_OPTIONS is not empty as expected because gcc-dg-runtest itself calls torture-init but I'm not sure where LTO_TORTURE_OPTIONS is set Christophe > Gr=C3=BC=C3=9Fe > Thomas > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955 > --00000000000014885805fb444271--