From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 4ED823858D38 for ; Mon, 20 Nov 2023 10:41:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ED823858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4ED823858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700476871; cv=none; b=kRNb5AxKPJ/Wkpjr7q9uJNhaDyB0zJAXQxHGAEJbykmLu8Fm3H2lL3pSXe0pfWvwFyXJ78TVCu7Bu9sOCv1thGe3foAGE7ydxOeAJS/ChTYCjk3PqKwcz3+He6cY9i3bi3QGPNg8niCDVq9ASH96NKymdCzWcEEmTJ/TYltdyEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700476871; c=relaxed/simple; bh=jiHrZaZjfOdKNfWqSqC9ptSSQBu/1pGy9mWbYo1CZBI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=F5gbmq8o4YvtgRZfHZhfuqKxTD3fcUZp1Wpa94imJ6dG27T5g10GaZftcQKeUbFI74xzU+/aaGHQhfiMPxNxMgtR4FahtCYIk6wYNdjrCcOqO9qp4RkgPBsQDhobcRgL2pzJcb/H+tjooHCm9oD4o+7OgRarhUAvbFa4NV+XVxk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5437d60fb7aso6109550a12.3 for ; Mon, 20 Nov 2023 02:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700476869; x=1701081669; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Tf9Am6YhmnlMj3xtahiAize9vZYzWJ1ggSllzFxjPsA=; b=K2xvBkk3m9u3vwYH0+s/PxI98RPrEvt2qR7QD9RZ9lKfIw8XyNGW8JU+oSw+nsWgNu VQqRQfPqPVKvbrLHY70vSC2h+X4l3ZRAYkT0QHW2MJNfCQWfQIuf81YCUo/JSOiIETnN rTwocE7+AUm6CSs1QJdT54O3mb5H6/MDyGlS7EluL8S06eokAOewZozxSJlKsWbtweBk YebVphyQklEsNhSLHWYRPbYl6Q8iySFzz477Igwdp3dEqZ+STpFw8e7EdBn8Z4htuMVn fHkRGHJ47WHUP09ZEjcmhf+0y5fl1CSy3GGm9cj6q/KlsqxeNRovjjMl8eOR2CO1DGNP dKPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700476869; x=1701081669; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tf9Am6YhmnlMj3xtahiAize9vZYzWJ1ggSllzFxjPsA=; b=LxOqAoefNrsTB2XaNcgsqDRBiJVThzo7lZICphRpQb+YzIZFU8dXr13D/6q6iec77m FLl/2oJjkRxVLNY4qWG2up9VFZfGOiASpqHwDW8ZhCCWigMY8LAvETZ7oUs3GR9N2gr9 wnN7D++wN/SijsxGCDOclz9JRyE2IYEYdiSVBox4bz2gNJstH5mGxxmSv91RCeZ3f0qP cpY+bIIvnLMgyNvUv0kD+9OgIrCWRzBEEG7lvuA4spSuZ7zwebZlWCin7QrZ3a1zbf24 lJqrlIC/GhhmfhjR2P+D53s7hw9cwyYfSb4UBJVvN9/v8NVb8CbyvLvKE9ASuyA+M3wI Ovtg== X-Gm-Message-State: AOJu0YwFQhxGRcu7WEpLOCwxVZqyYjpipKwdJpDEU5PhN2u0614BbYUf +2v62bF6m76C+nRh7Y9iTspBuzQ3GbBDOibV3YYqd86cV+ztEGlKve3rBQ== X-Google-Smtp-Source: AGHT+IElXu9CbPBcehmjy8NpNZCgg73agNeTUDEiAfzKzmCNyMcNbowJuFidW3XCEaqzA3AiJY9fr8IkNMt7aBXuWm4= X-Received: by 2002:a17:906:257:b0:9fa:ca0c:ac42 with SMTP id 23-20020a170906025700b009faca0cac42mr5076036ejl.64.1700476868965; Mon, 20 Nov 2023 02:41:08 -0800 (PST) MIME-Version: 1.0 References: <20231113142658.69039-1-rearnsha@arm.com> <20231113142658.69039-3-rearnsha@arm.com> In-Reply-To: <20231113142658.69039-3-rearnsha@arm.com> From: Christophe Lyon Date: Mon, 20 Nov 2023 11:41:07 +0100 Message-ID: Subject: Re: [committed 02/22] arm: testsuite: correctly detect hard_float To: Richard Earnshaw Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, On Mon, 13 Nov 2023 at 15:27, Richard Earnshaw wrote: > > > Add an arm-specific test to check_effective_target_hard_float for > Arm to handle cases where we only have single-precision FP in hardware. > > gcc/testsuite: > > * lib/target-supports.exp (check_effective_target_hard_float): Add > arm-specific test. > --- > gcc/testsuite/lib/target-supports.exp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Our CI has detected a problem when testing this patch for cortex-m33: with -mthumb/-march=armv8-m.main+dsp+fp/-mtune=cortex-m33/-mfloat-abi=hard/-mfpu=auto and GCC configured with --disable-multilib --with-mode=thumb --with-cpu=cortex-m33 --with-float=hard FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O0 execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O1 execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O2 execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -O3 -g execution test FAIL: gcc:gcc.dg/torture/dg-torture.exp=gcc.dg/torture/fp-double-convert-float-1.c -Os execution test We use qemu for testing. Do these tests pass in your configuration? Thanks, Christophe