From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 469DE3858D35 for ; Mon, 20 Nov 2023 10:12:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 469DE3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 469DE3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700475176; cv=none; b=Yi+SPwAUzdw7tzVHkIEdbwE5JO7VDhdOqf4DwzR69qWd5eW+TI8DzCRP5el4SeT+V4EhE8kh9tyuSn3tEk1tpuDZqFphxlp++fKoJKllhopxlHMTYSkTCJzca1y2XSpV+jGOV4r8QEgjYcUtNWQpIK4uuX5ZHOd/rtO5wxB4guY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700475176; c=relaxed/simple; bh=RDNQT8ZE0ZONvsa0ZL9VB8YTgpG8/S9pNi63ckndwbI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ggVYVvesUEJRL8PwKnBPUiwG9tejsa6h6YH6F/tJO6b1vTHY+USLOnwwm7jn19rOHCcOBqZjNgtyNaEwReuoXxkadvbgOTc1be2c5+kD7XI9FPH+AGasaeQ4HnRQuQbco7t8+mAuB1fuKjFiJLKX3jqvN4MCKvP3twC1bb0GgpA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9d10972e63eso562010366b.2 for ; Mon, 20 Nov 2023 02:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700475173; x=1701079973; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bUc62S5ygyLXWJRtwZnX+JyNnac1BHaTLM6Xuq3/qoo=; b=IVYQpJNB+9E+sEgmTDvd3UtqNlYbeMZfp9nsxPYZaoDkdDL2H6xT7A3oxWBJ/xg9/W cT/NbYRoYdc2sItHiQC47qY41QkALdjbjZWbRwfPwpp3X0TtucaUM+hJz3//8SisuE7t Xpvx4Bn+VfKMUSyGVHkWYQfluQyHoP2+A5YuunE+8oVCABX7LzY+aDQFor3L7MtgdrL4 TpgWx5GALVuzpypGC5zXCVTUmqy3oXPr8Vqq1OjTkhwJ8wUWWMgWKW5BUqpnXXJvkQaS bgXTJD3WNnwo2KHsVUsjy7LpL80wE3AxERIWP6Xt4ylCXPcMhTb8CNl62p94af8a2fsV Wm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700475173; x=1701079973; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bUc62S5ygyLXWJRtwZnX+JyNnac1BHaTLM6Xuq3/qoo=; b=T91fd8iu5Kh9hQayo3Z8VkJN5l7ulzMCJpYX8ExBcqqeF3sIxzW/Owu9EBCsfIhHoa O+HRd64Ht7vOzo9ziMUfaxZDkQHizCca+l+1XgMhcm5nP2D/zNHzrfLTLHDX1AF7byf+ 9vbhXwBED0dweqUBB+h243f5k2Z8MQOEyYJteDqga4h87mqV88FuYiQpCe/THO1107v1 dP8CZvey4Tjdht+6bIHjzkollorFcV2rifShY5mO98BEdshu0w4PDqby/qHcEC1PhFeB D3VddJlAqBk+rCIoy0cvHXA9xR5/oyu2C8MD8QEJhzkV0LSfn3c2UTFKLAjCWzCLq6BR X7eQ== X-Gm-Message-State: AOJu0Yw1HCe+3ilwf2pvSHdAiDN6q2ekTs6rjcU0+ojyRdtj4I1GQVqS 2bJPZtZmO1ePJdqP2TllezSoxTFieRuu9tMefd/D5A== X-Google-Smtp-Source: AGHT+IFRoacY79qHek4mMF4rZYOE0RgpNkCnxF5jLLcMpo2ee5ULDRQHiKD34zMnoKLsWfGvaKgXx/O3RwaAZPsqQI4= X-Received: by 2002:a17:906:fd58:b0:9ff:6625:b0d8 with SMTP id wi24-20020a170906fd5800b009ff6625b0d8mr872669ejb.26.1700475172880; Mon, 20 Nov 2023 02:12:52 -0800 (PST) MIME-Version: 1.0 References: <6522a7d2-63a9-477a-a4b3-6069d83de0c0@arm.com> In-Reply-To: From: Christophe Lyon Date: Mon, 20 Nov 2023 11:12:51 +0100 Message-ID: Subject: Re: [PATCH] Add a REG_P check for inc and dec for Arm MVE To: Saurabh Jha Cc: "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford , Kyrylo Tkachov Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Saurabh, On Tue, 14 Nov 2023 at 15:51, Kyrylo Tkachov wrote: > > Hi Saurabh, > > > -----Original Message----- > > From: Saurabh Jha > > Sent: Thursday, November 9, 2023 10:12 AM > > To: gcc-patches@gcc.gnu.org; Richard Earnshaw > > ; Richard Sandiford > > > > Subject: [PATCH] Add a REG_P check for inc and dec for Arm MVE > > > > Hey, > > > > This patch tightens mve_vector_mem_operand to reject non-register > > operands inside {PRE,POST}_{INC,DEC} addresses by introducing a REG_P > > check. > > > > This patch fixes this ICE:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337 > > > > Okay for trunk? I don't have trunk access so could someone please commit > > on my behalf? > > Ok. > > > > > Regards, > > Saurabh > > > > gcc/ChangeLog: > > > > PR target/112337 > > * config/arm/arm.cc (mve_vector_mem_operand): Add a REG_P > > check for INC > > and DEC operations > > > > gcc/testsuite/ChangeLog: > > > > PR target/112337 > > * gcc.target/arm/mve/pr112337.c: Test for REG_P check for INC and > > DEC > > operations > This new test fails in our CI (various flavours of target arm-eabi), with the following: /gcc.target/arm/mve/pr112337.c:11:18: warning: passing argument 1 of '__arm_vldrwq_s32' from incompatible pointer type [-Wincompatible-pointer-types] In file included from /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.target/arm/mve/pr112337.c:5: /arm-eabi/14.0.0/include/arm_mve.h:1752:35: note: expected 'const int32_t *' {aka 'const long int *'} but argument is of type 'int *' I think you should make p a int32_t pointer rather than int, but I am wondering why you didn't see this problem in your testing? Can you check? Thanks, Christophe > ChangeLog entries should end with a full stop (the git commit hooks enforce it). > I've adjusted the ChangeLog and pushed this patch for you. > Thank you for the patch! > Kyrill >