From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 2B2D73858D35 for ; Wed, 22 Nov 2023 10:51:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B2D73858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B2D73858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700650268; cv=none; b=t/LWsFIx4dD4ukDP+kHSqq1OJEnVfC9IeAvOv473BmUVBXc8zYiK8731X71jkjKEh/PkR0mRRc4bhKmOxrph/edEXemzIekMJe04iIecR5Fw2r0VgoyR7VggcFH29ONrv6A0CTmPceMmDpyYbq9n45lpdxHjglvQ7cExgAzBVQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700650268; c=relaxed/simple; bh=BDcZ+9463b/ZEFT1F4XYRHwCMUxMAriVC5BPefdVjz0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=l2KByH3OWCM94jWIciQsuYoobVaVxylTiSFJtkXQb01siBIT19xeXtj/YvKoIQgH6GebMm7eetcjgGb4weI4fCHXEJJLaj5zWHQhk7W+kKCK6yTGnJQUSjyzp3kyFcsXmfdrjf0tCkNYeUHv0OyN0Fgo5l/wGvxTXudQHihwuuM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-548d311ea5fso3901005a12.1 for ; Wed, 22 Nov 2023 02:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700650264; x=1701255064; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I5QaRepA0QCOMaobOwYz01+mD4bVVd7Idzlq7bT+uOU=; b=dTTwHOLN+fcgZQSvFofYLJyMgvGSZW9sjteSTlTaCgcI6hLfzZ/kr3SgRFTceRaW1i 20ofQkXz8dok7ebPk4OdwpSCVia8vnbBY4ZHUqScFZ7GJzLsc5igSDqVmyrA4bPorxPM vtyTlh5vhnAKzvx2br29kQ9yYmrkbVfneOYqXN1zxsQUe9BGHscOLPaPLNlLu01KFW3X cDcvk0qwieObp0aNvOfQnv3Xb3Va/9e3IbbnwBfnrC7W+KEU0/JZ57m/nf8jkLqj9tHo c2O774onX7axDtfcVvgRIxRibBDbevhOEb2cezKJk4bW+6lbjqrVF1rYHVL4XU0mLl9w RJdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700650264; x=1701255064; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I5QaRepA0QCOMaobOwYz01+mD4bVVd7Idzlq7bT+uOU=; b=vwgScG2B+02nWhYo+Vcc7jyi1wrdoXVxde9IdvwLoDTpqHmYYQk4LumKFB+3cnzfN0 VOfmZPLSlNRlBNv8kui2gATGEUF5I50vZfN3nhPxAwgD9LLXHKQ7yFg0fdWc4pLK1IpH auiWeMpkiKY9Y65BI6LBXzh/MXl+46DsYhgFdtXlfy6GoITnKYNaC0DLUcL6BJ/LXOs4 /DMAkLs6p9I5/rgV1p0EeBekaCBmzFAAu38NIfu68PskrAlXqVjYl4zxXcK4I7ckaS5I cPwNJiMg94l6lqUyBKzkZSkWAcJyoNNYMu+AOJOtZ7H8V+yXmZwMOsKAJmu7vK8PdPHP UYcg== X-Gm-Message-State: AOJu0Yynu1ujz+JDcejL2I+/7T9oxqrYCOF+GdHcqbEck7GO72i1Sx+2 NEESq5bGtVG5LyhU9lJsNIWeSfC5sCHEsN3h4sqzZg== X-Google-Smtp-Source: AGHT+IFpWkyr1T8Uvw+bp2i6B7WyvCtud3l0HHAuIYVPPbMMXv9qEbDQW6REWglposYuEWPo1Ii4Mae1HDcR6aIZ31w= X-Received: by 2002:a17:906:f295:b0:9fc:346c:a5fa with SMTP id gu21-20020a170906f29500b009fc346ca5famr1250249ejb.46.1700650263807; Wed, 22 Nov 2023 02:51:03 -0800 (PST) MIME-Version: 1.0 References: <871qcmkmgd.fsf@gentoo.org> <87r0kiu7f3.fsf@euler.schwinge.homeip.net> In-Reply-To: <87r0kiu7f3.fsf@euler.schwinge.homeip.net> From: Christophe Lyon Date: Wed, 22 Nov 2023 11:51:02 +0100 Message-ID: Subject: Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values) To: Thomas Schwinge Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Tue, 21 Nov 2023 at 22:24, Thomas Schwinge wro= te: > > Hi! > > On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > > Pushed to master branch commit a0240662b22312ffb3e3fefb85f258ab0e7010f4 > "Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to > 'unsigned'", see attached. On powerpc64le-linux-gnu ('char' defaulting > to 'unsigned') I still saw: > > /tmp/ccd1xwD7.o: In function `test': > return-value-range-1.c:(.text+0x50): undefined reference to `link_err= or' > We do see the same error in our CI (Thomas, normally you have received a notification because your patch turned ERROR in FAIL) Thomas, you said in another email that adding -O2 avoids the linker error with missing link_error(), but I don't see how that would be possible? (and hence I expect the error you quoted above to happen) So should we use dg-compile instead of dg-link? Not sure what the original intention was? Thanks, Christophe > > Gr=C3=BC=C3=9Fe > Thomas > > > > @@ -0,0 +1,22 @@ > > +/* { dg-do ling } */ > > +/* { dg-options "-O1 -dump-tree-evrp-details" } */ > > +__attribute__ ((__noinline__)) > > +int a(char c) > > +{ > > + return c; > > +} > > +void link_error (); > > + > > +void > > +test(int d) > > +{ > > + if (a(d) > 200) > > + link_error (); > > +} > > +int > > +main(int argc, char **argv) > > +{ > > + test(argc); > > + return 0; > > +} > > +/* { dg-final { scan-tree-dump-times "Recording return range" 2 "evrp"= } } */ > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955