From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id E086F3858D32 for ; Thu, 26 Oct 2023 16:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E086F3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E086F3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698338929; cv=none; b=MTHalUn8MbVZyelI0v9oq4RjoXQ1NNSogL1KYd/NYIFCDLdkXki8luiCP3nQAn6sD4wH+qxWatyEikwBznK0d8z+QM5pdd+UlQmSwTlB+snMLvLOCOx0c0idnEiGasVxnZL/vFecp/KpN7VHsAn5/v0iva4PTNqYhNh6sureQ1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698338929; c=relaxed/simple; bh=N23q7eDBsnfK5xJvmEPGcsEZnqudLU06Ce1sTq3dUG0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=pJ6c2C9JQTbOF0FEDhcOli9Qqkmy/BsCoilicGOTJ9aOLRyegjp284m8o5zyUxY4m3cnwtYvdKwVHdfn+rkSJbhRDHZAZMD/rtDbP/O4k6EzwYF6AhxjjXf3sacgCPmilXzQIBCnsCAEwinbtbLcTYBb0LsFXVCVSy/eRhUo7RE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo1793226a12.3 for ; Thu, 26 Oct 2023 09:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698338925; x=1698943725; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N23q7eDBsnfK5xJvmEPGcsEZnqudLU06Ce1sTq3dUG0=; b=YPTmOWpLP/sFKNZxhCKytHsqvHx907cY5t6mcQfcXEgINdU2nh9S0H3kv1X9pZY6wv G7F981U45MPUVbvS3nDrmuxFYLmIY83Fcp7W8/OlU149JuuSJWPXtgHx+SN/ajGedeL3 fyE5yQiDWAFGEiE4C39cq2ca33G5xqGahpngpAV9VHlRCEzG6clZoEEyv91lvHsvX9z6 RgIFxkpRWM8KekdjGTw32KwRJVmzcfeZAy0flhpaRx/39NU+d0jz0dKykdIwv6L50OwN ZWI7PxwSAFKgMW41RDCiev3QI+zGVuPRSoZOyZJMT5/Xmvsu1vvv8ciHAmu2EsVGaf9T A9HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698338925; x=1698943725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N23q7eDBsnfK5xJvmEPGcsEZnqudLU06Ce1sTq3dUG0=; b=n93MPrTxu0bTxoTOyl3RDVauhfRtHja2IP+P+tsUpcH96aBov3q4jSl0laYM90HmK9 FpHQCZxPCIgrM8frSNUrsCiaKRIiabiXKkD8Wx7sAAe7wkl7lVm4o8IIXSfQaZlurMe3 hrFPQxYisU44u1LV4IY6kmMyAz4ulEAFXdnAXvS9Bf6zdZTn/Vs19ogzprd4go+RQl6I q/qPY7p74lL0G5ohXVmtI+ZJ8ByN6RYAZAi8bv9o3YMOAW3hGIzsHuxikeN0LoO3C1He Ur1w83I0yolTCcEFqVAQqoA8T1Am8RwghggM0IIX99rLCYMDPV4ariyRpQgzwB0jEhqa GwjA== X-Gm-Message-State: AOJu0Yx2HuKBxhGGo+qQbUuQd6ISbbtTaU8U65Od07kbhAXspx6EkqPD Kotuc9cbKyydzZsDN4POmeep0Ou0mbCta6SeZ2HQ/DeIomx4i8Q4O00= X-Google-Smtp-Source: AGHT+IEAnU7RYEg8tD7o+PY6Ccw8fZTJkVF/rG+T20h2PgKRdQsGvKCgUdBITmuNIiI7D6JKthYrvvQjBBeBUA1yG/c= X-Received: by 2002:aa7:c454:0:b0:53e:1741:d76b with SMTP id n20-20020aa7c454000000b0053e1741d76bmr299207edr.39.1698338925519; Thu, 26 Oct 2023 09:48:45 -0700 (PDT) MIME-Version: 1.0 References: <20230920041202.4099349-1-lhyatt@gmail.com> In-Reply-To: From: Christophe Lyon Date: Thu, 26 Oct 2023 18:48:36 +0200 Message-ID: Subject: Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887] To: Lewis Hyatt Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > On Thu, Oct 26, 2023 at 4:49=E2=80=AFAM Christophe Lyon > wrote: > > We have noticed that the new tests fail on aarch64 with: > > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start'= : > > .../sysdeps/aarch64/start.S:110:(.text+0x38): undefined reference to `m= ain' > > > > Looking at the test, I'd say it lacks a dg-do compile (to avoid > > linking), but how does it work on other targets? > > Thanks for pointing it out. I am definitely under the impression that > { dg-do compile } is the default and doesn't need to be specified, I > have never seen it not be the case before... Is that just not correct? > I tried it out on the cfarm (gcc185) for aarch64-redhat-linux and it > works for me there too, I tried the test individually and also as part > of the whole check-gcc-c++ target. > > I do see that there are target-dependent functions in > testsuite/lib/*.exp that will change dg-do-what-default under some > circumstances... but I also see in dg-pch.exp (which is the one > relevant for this test g++.dg/pch/pr36887.C) that dg-do-what-default > is set to compile explicitly. Indeed, thanks for checking. > Note sure what the best next step is, should I just add { dg-do > compile } since it's harmless in any case, or is there something else > worth looking into here? I'm not sure why I couldn't reproduce the > issue on the compile farm machine either, maybe you wouldn't mind > please check if adding this line fixes it for you anyway? Thanks... Can you share the compile line for this test in g++.log? Actually I'm seeing several similar errors in our g++.log, not reported before because they were "pre-existing" failures. So something is confusing the testsuite and puts it into link mode. I am currently building from scratch, without our CI scripts to get some additional logs in a setup that probably matches yours. Then I should be able to add more traces a dejagnu level to understand what's happening. Thanks, Christophe