Re: [PATCH] i386: Remove declaration of unused functions

[Christophe Lyon <christophe.lyon@linaro.org>]

On Wed, 26 Jun 2024 at 01:27, Iain Sandoe <idsandoe@googlemail.com> wrote:
>
>
>
> > On 25 Jun 2024, at 22:59, Evgeny Karpov <Evgeny.Karpov@microsoft.com> wrote:
> >
> > The patch fixes the issue introduced in
> > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=63512c72df09b43d56ac7680cdfd57a66d40c636
> > and reported at
> > https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655599.html .
>
> Trivial patches like this that fix bootstrap on multiple targets can be applied without extra approval,
> this fixes bootstrap for x86 Darwin, so OK
> Iain
>
I've just pushed the patch on Evgeny's behalf.

Thanks,

Christophe

> >
> > Regards,
> > Evgeny
> >
> >
> > The patch fixes the issue with compilation on x86_64-gnu-linux
> > when warnings for unused functions are treated as errors.
> >
> > gcc/ChangeLog:
> >
> >       * config/i386/i386.cc (legitimize_dllimport_symbol): Remove unused
> >       functions.
> >       (legitimize_pe_coff_extern_decl): Likewise.
> > ---
> > gcc/config/i386/i386.cc | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> > index aee88b08ae9..6d6a478f6f5 100644
> > --- a/gcc/config/i386/i386.cc
> > +++ b/gcc/config/i386/i386.cc
> > @@ -104,8 +104,6 @@ along with GCC; see the file COPYING3.  If not see
> > /* This file should be included last.  */
> > #include "target-def.h"
> >
> > -static rtx legitimize_dllimport_symbol (rtx, bool);
> > -static rtx legitimize_pe_coff_extern_decl (rtx, bool);
> > static void ix86_print_operand_address_as (FILE *, rtx, addr_space_t, bool);
> > static void ix86_emit_restore_reg_using_pop (rtx, bool = false);
> >
> > --
> > 2.25.1
> >
>