From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 69B0D3858C2D for ; Mon, 20 Nov 2023 13:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69B0D3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 69B0D3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700487417; cv=none; b=q6reWTlW6zcNOAWQsSsTjezbGDz9FcQsXaOvgpLvBIz7L/yjCoMEuoWMNZikN6r6VgtwkZiSejy6u2HumFMyCe+DMJAACEN22xhrbHx+vx7VbSMWzx9G4M8q362xPGgzWmfIbOP09YuUP6rErlUTJ/rI4uIK0O3ArYca0WDqqPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700487417; c=relaxed/simple; bh=252cvRSnFN90V3GxYnSqWpHZCXy63CLHc/oATH2fycA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=QgkBZmG4A6C9cNVl4lMvL9RPIm5yowhGVJCBZeDYR2VXdKNwsnnssHuQ3saD5JrRuQM19bcV9xABbgGqJwO88YIwkycNhGFU3rHs+qD3yihX6+S9zcQlzl8N+z9A0fcY+Jz9Z+AJtXE8vP0qb8Fo0E4VD7NhcdiDyKxskEJWVKA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-548d1f8b38bso998174a12.3 for ; Mon, 20 Nov 2023 05:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700487414; x=1701092214; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LSR9fithdHHLMBEQzuxaV2/ltJgRCDSMYDDje1K6ztM=; b=IZ5siyyRmfdoeRTKN2JEsUTrht7IXgMa/Mt4U3pZNaSxq1biUb1GWRnqW9n2mg4U2K dKkiQJvW0NcUPdwh1gKE44/++8a78OoJciYHoe4clPNCYwGedy4hRE+YKc4SpAZWszoS QfUSSnN9LVSsn8Y93IpowQDGBL1bfNRhRUl03u7OeZVFyJ4vxfw0gRJy5OcOBNs2wWAY wDaMA5C28q1tACDgYRMqYjucqpeyrrGV7fGDBIUDvD8W/x8h4CE9XGIrYaGUtdsBA0mg Nb1Ap+tmKtLrVLx+orOBi+ps/XBdbfkjbzpp5Womt2snwU16Wm98If8OppugJ8JU4E18 pZAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700487414; x=1701092214; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LSR9fithdHHLMBEQzuxaV2/ltJgRCDSMYDDje1K6ztM=; b=blp4r69jHAlyu6RyVN4WAlzB4pat1p311g/pUDG6qWRkxfSYBV0VRmZfDrt+S1dWHm hi67MiiwNcEBtP1nzSAdLmHSg7HNMHMKzlyENKuvWASb2dy70A7/HCsmoYYuZ0mvwxS0 J5HBNoQvdQ93kvOB+3hxtrb4G5EA/QHHUyTEfmxOdRD3DUZ2XcOidkGFGkxtHAIf4B5/ vwss1sydqloxazoHxZMkoAXaYth5ZBJLCtGQKzhUXkc7EsF1u/0y78Sbi3b38rc3kzXi svIIkdFHFzhI560a52vAsSgT1Fnl/AX7PDirzzBisVnxHJvyWkOnHMq1edh9g5y4HQci RimA== X-Gm-Message-State: AOJu0Yys5dQwtndM2zY+wYfcKJeWffWmQvfCtO5bjv9dnHp9M13P9iGg OUYeBYQ2dTaTLQ39ibxZMvMY4gwGwJ71vqYl8mspjQ== X-Google-Smtp-Source: AGHT+IEkJqkqc35o+lMcSduVSK7Yt7FCIY+SuBrVfBXlb6TLoLJWquEtIr5Q+LD287cijYUMwTGtKSzO+7xeo9W/6v4= X-Received: by 2002:a17:906:73c9:b0:9e7:c1cd:a4dd with SMTP id n9-20020a17090673c900b009e7c1cda4ddmr5647915ejl.3.1700487414026; Mon, 20 Nov 2023 05:36:54 -0800 (PST) MIME-Version: 1.0 References: <20231113142658.69039-1-rearnsha@arm.com> <20231113142658.69039-4-rearnsha@arm.com> In-Reply-To: From: Christophe Lyon Date: Mon, 20 Nov 2023 14:36:52 +0100 Message-ID: Subject: Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march To: Richard Earnshaw Cc: Richard Earnshaw , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 20 Nov 2023 at 13:44, Richard Earnshaw wrote: > > > > On 20/11/2023 10:23, Christophe Lyon wrote: > > Hi Richard, > > > > On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > >> > >> > >> A number of tests in the gcc testsuite, especially for arm-specific > >> targets, add various flags to control the architecture. These run > >> into problems when the compiler is configured with -mfpu=auto if the > >> new architecture lacks an architectural feature that implies we have > >> floating-point instructions. > >> > >> The testsuite makes this worse as it falls foul of this requirement in > >> the base architecture strings provided by target-supports.exp. > >> > >> To fix this we add "+fp", or something equivalent to this, to all the > >> base architecture specifications. The feature will be ignored if the > >> float ABI is set to soft. > >> > >> gcc/testsuite: > >> > >> * lib/target-supports.exp (check_effective_target_arm_arch_FUNC_ok): > >> Add base FPU specifications to all architectures that can support > >> one. > >> --- > >> gcc/testsuite/lib/target-supports.exp | 50 +++++++++++++-------------- > >> 1 file changed, 25 insertions(+), 25 deletions(-) > >> > > > > Our CI has detected some regressions with this patch, in particular > > when testing for cortex-m55: > > > > with > > -mthumb/-march=armv8.1-m.main+mve.fp+fp.dp/-mtune=cortex-m55/-mfloat-abi=hard/-mfpu=auto > > and GCC configured with --disable-multilib --with-mode=thumb > > --with-arch=armv8.1-m.main+mve.fp+fp.dp --with-float=hard > > > > you can see our logs here: > > https://ci.linaro.org/job/tcwg_gnu_embed_check_gcc--master-thumb_m55_hard_eabi-build/209/artifact/artifacts/00-sumfiles/ > > > > Thanks, > > > > Christophe > > What exactly am I supposed to be looking at here? I see no description > of what those logs represent. If they are supposed to be before and > after, then why does the after only run a tiny fraction of the testsuite > (Running gcc.git~master/gcc/testsuite/gcc.target/arm/arm.exp ... > Running gcc.git~master/gcc/testsuite/gcc.target/arm/cmse/cmse.exp ... > Running gcc.git~master/gcc/testsuite/gcc.target/arm/lto/lto.exp ...) > > The logs give no clue as to why the reminder of the testsuite wasn't run. > > Please don't make me guess. > Here is a summary with the list of regressions: https://ci.linaro.org/job/tcwg_gnu_embed_check_gcc--master-thumb_m55_hard_eabi-build/209/artifact/artifacts/notify/regressions.sum/*view*/ I thought you'd be able to find your way in the logs above, the .0 files contain the logs of the initial full testsuite run, and .1 ones contain the logs of the second run of the testsuite, restricted to the .exp files where we detected regressions. So looking at gcc.log.1.xz will give you details of the regressions shown in the link above. Christophe > R.