From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id E732B3858D35 for ; Mon, 20 Nov 2023 10:23:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E732B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E732B3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700475819; cv=none; b=E/t7/niwzo48AYlI7+8i3A1XqphoRB8JIFSfG/zNXp5CnhalLgpebs4VYDfP24NBA2Cmj+t0UlRZRMi7PZH7Nxt1/tKeS/YxVLzdeSM5i85ecN45xyu5CQD3/9uyRRqBgTr3QhowPLxpyTA+za8IapOFvn+ZA57TyRKy660Ff4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700475819; c=relaxed/simple; bh=RFree43UWm+KdzYUoKInQTNageeDNKiIO2s868r/zng=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=WxMka94+ZO/DwaSb3jzuZ3GBbN1PkL/TDZActoH20+kRqz3E7vFE8GEzBi5+j1d0/yvuTw1LA90qmr42hE1gyF2S1wYcA7Y00NVJdovlWfxRlmJdibYEAjlAAKUBMWa8IfqNd/K8qVh2bnjIqlpF1KZLHUDsk2m/yQZFjKNt7EU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9f26ee4a6e5so567697366b.2 for ; Mon, 20 Nov 2023 02:23:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700475814; x=1701080614; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UUB7hFJk/P7wCcfu6FXTd3RHcfjgyFbwffC1ZlpVGDY=; b=UB4Q9hg6agpUNV2DvM/yctdokNPK7NFZYVY6w2nlq1YlFVcrFdmowbGbB8lMAQdTKH ZKMQon7YhU+xJSQvmMoAMqdVyv1JvdEwEgJI+IKe/uWCAAQRNVOzoG8aAp2o7kUR7bEU mEzPjViSUINOI7Rz5z6hhWMYAa7AbtKwXbyqELI5+Vf+ODOkdiurQgex9u6+kSw4yfxA o+XMmusrBqHjaH5A1SeUJvY+O4FS9pb44DDxlzygsMyTk4W3t/jE44d0IZ6oerqumlhe 4IH13lq+llB54w40SrE3i9XXgM1H2ELdJOs77fKvLMOJf5y/YiF3iiiyXNoD6EZPiZXo 1WFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700475814; x=1701080614; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UUB7hFJk/P7wCcfu6FXTd3RHcfjgyFbwffC1ZlpVGDY=; b=P/1fSl9zEieuSLp5crZSeaF+tfdjFmwaUa+aVYmRVlAeyviVQ3han7VzCvCdvluVbq XlKdJgphqEscU4EZMJIkjWoRl1AU6J28QtzY5lUMZe8+JtWsOHBC0A4LCWMKz/z3jXzG gjQTbKU83J6ISr3nazournX1nOP/5RgMyStNyg7wCboYlWS51JQWLl4Rwiiy6diLZh0u JE76zCG5cM5Qp0rrvt0pdlVV/72ZaGsXm3//LYXv8kT+5lPGEbgNFxt3nnk/m2n2EBnB MMiL3duboLBenda0765g7hl8BJM05mtqATRKFF4h1CVZ/ko2r6yrqD8mG8bx66cGFO/n DQOg== X-Gm-Message-State: AOJu0YzUND04QpKgvHL6GD45W3YjTNDo9ahl6esnqWCgIJY5bLVjYinC hkWejtR3tB7N5E1PyoRFLdtNtwX8M8gOdYqxHUhwdM8yTc/640Y9WAJYOQ== X-Google-Smtp-Source: AGHT+IFc0yeSGdjrV5lRYbpqIQGJUEu6GSz2Kicv7ooz0U2yFB46a5Oha6CC/QuvtHoP6tsnVV7FGmR76wF7y8iUIts= X-Received: by 2002:a17:906:3559:b0:9a1:f21e:cdff with SMTP id s25-20020a170906355900b009a1f21ecdffmr4273022eja.23.1700475814545; Mon, 20 Nov 2023 02:23:34 -0800 (PST) MIME-Version: 1.0 References: <20231113142658.69039-1-rearnsha@arm.com> <20231113142658.69039-4-rearnsha@arm.com> In-Reply-To: <20231113142658.69039-4-rearnsha@arm.com> From: Christophe Lyon Date: Mon, 20 Nov 2023 11:23:33 +0100 Message-ID: Subject: Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march To: Richard Earnshaw Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > > > A number of tests in the gcc testsuite, especially for arm-specific > targets, add various flags to control the architecture. These run > into problems when the compiler is configured with -mfpu=auto if the > new architecture lacks an architectural feature that implies we have > floating-point instructions. > > The testsuite makes this worse as it falls foul of this requirement in > the base architecture strings provided by target-supports.exp. > > To fix this we add "+fp", or something equivalent to this, to all the > base architecture specifications. The feature will be ignored if the > float ABI is set to soft. > > gcc/testsuite: > > * lib/target-supports.exp (check_effective_target_arm_arch_FUNC_ok): > Add base FPU specifications to all architectures that can support > one. > --- > gcc/testsuite/lib/target-supports.exp | 50 +++++++++++++-------------- > 1 file changed, 25 insertions(+), 25 deletions(-) > Our CI has detected some regressions with this patch, in particular when testing for cortex-m55: with -mthumb/-march=armv8.1-m.main+mve.fp+fp.dp/-mtune=cortex-m55/-mfloat-abi=hard/-mfpu=auto and GCC configured with --disable-multilib --with-mode=thumb --with-arch=armv8.1-m.main+mve.fp+fp.dp --with-float=hard you can see our logs here: https://ci.linaro.org/job/tcwg_gnu_embed_check_gcc--master-thumb_m55_hard_eabi-build/209/artifact/artifacts/00-sumfiles/ Thanks, Christophe