From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 3D06E3858D20 for ; Thu, 2 May 2024 13:36:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D06E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D06E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714656978; cv=none; b=baIRHfH6LxABW2gKOi/wrXrcfxlPysqx5Qb2Q4FXLCO9RVPmoSC5GBdGmoYtoux3PJNSuyywWviT9E2ub9jTD0B0tr4T5+gKC4VTMdLkydzoYrSh3MH4hduBrKXJ3TRh6d2cwtsY3NFo0S97Ewv6GVf4A9AbJfrBztwsEjJsKok= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714656978; c=relaxed/simple; bh=mmtJoPs//4f8ucRof54ONRMeyKrn+lmW+lxmphWZjuM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OBH6aqGlwLeu1uViy2zV6zm9IRn9IDhguVYTUHHWuPdnte+MpUv+bLAVQ4qqBH9SUh+XWffoVxVlWEShZAwLrXZuAZ7KFl2jMyrVRDalOffCWPVFbWoca8JYcHgHbip1uXCpa18DZXuyEPB2XvuHSwoCcdm4nQ3LBlpDZ0kr5UI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a596cb8a7dbso121765666b.1 for ; Thu, 02 May 2024 06:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714656975; x=1715261775; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z7bI1hC8fgqY0V1aya3I9r21WzqWuAJPE4s+ovDcJ+g=; b=rVB88d+XAjJYFAB9aQKAEp1bk3egOuUVhOTa4HXVO1rEwYoy6kFqvQnTAurEGk1RPq EUON7cWumqC8TCmX0+qRxF4Xmt04val+sCtlvX7pHMADEhQhvTQGhRjrumWDhultxfJc Idfvx0x/V+bIZRy7P9s0+y49H6CY8c41zQBb0Ld12WWNDWDKwO7Wu1fCEjy4qMRT4f/J AbLA3nmKe94xQgCVyfRkXpNy01FYIuTcjANsK6uyk3qIohVWRM2BHpB/qVNW1vlf7upI Etxfvf8RHlzOs+DV/PFNipq2fIQ1pHIkHLwdWSdV5v9CkK4wKSJVoWrf+G8Mpsk6MqD2 mMaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714656975; x=1715261775; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z7bI1hC8fgqY0V1aya3I9r21WzqWuAJPE4s+ovDcJ+g=; b=xMFrj5U9eTJXDrkllZx9PbgEcRZlLx1LszgWuoL+6RUUWcvQ+HzCdb8rTf1yWqZ9bV be+uKiTIypUTmk0qKJaPX66RWOvaRHc2lW5yuZ1GPLNp5bpWO+wnGRnUHqRS41ZxaEmr NQYAlZvaFJ0dZEg1xz0q5fc3udl3+cu7KoxEGd31lEi2PsgYP8CWVpigUjj3hhsm6iYf qKNTyKbWD8drZVl4sJLqXXuZAEpsKozHi90HjG9gI0H0xkTnuGtayRtXphAFx8eja4Vv Godh/R+dcQoavEiuwUWfQnOza6av30dy5IyCEZ4mqjx24A2QfaQZOuN+pu1FZVBBWFON c0Dg== X-Gm-Message-State: AOJu0YxxERJ47DKonRJ4PZ1iUJYkI3glRBdmxv5QQYYvOV5j4CUNh31g vX66HqeDfCvHoDkvpumR1xpIebZ52wZ1gkyD0fiillxGGiMs7BQZxQqW0lMR/VNuwS2VREHU6KL Fl/qiPyNoiLd4jXIYx8xWx3vedYRA1wGM5lm7xg== X-Google-Smtp-Source: AGHT+IEt5l1oVHAWH+Gk9nqu6/V+MGl1xipOuY8ITAs5B4fI/2IxWdEIfylYIXIrj8JLVqMjVH57TBU6WuZ7bGkqAgI= X-Received: by 2002:a17:906:6b90:b0:a58:7e00:255e with SMTP id l16-20020a1709066b9000b00a587e00255emr3633801ejr.30.1714656974742; Thu, 02 May 2024 06:36:14 -0700 (PDT) MIME-Version: 1.0 References: <20240430022420.114397-1-simon.marchi@polymtl.ca> In-Reply-To: From: Christophe Lyon Date: Thu, 2 May 2024 15:36:03 +0200 Message-ID: Subject: Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac To: Simon Marchi Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Apr 2024 at 17:47, Simon Marchi wrote: > > On 4/30/24 4:54 AM, Christophe Lyon wrote: > > On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: > >> > >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same > >> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. > >> > >> This makes it possible to re-generate aclocal.m4 using "autoreconf". > > > > Thanks, this LGTM, although like in your other patch, we need a > > ChangeLog entry in the commit message. > > > > Christophe > > Here is the ChangeLog entry: > > fixincludes/ChangeLog: > > * configure.ac: Add AC_CONFIG_MACRO_DIRS. > * configure: Re-generate. > > I don't have access to the gcc repo, so if/when this patch gets > approved, can you push it on my behalf? Sure! > > Thanks, > > Simon