From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 1B9053858CDA for ; Mon, 10 Jul 2023 13:58:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B9053858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51d91e9b533so5770857a12.3 for ; Mon, 10 Jul 2023 06:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688997534; x=1691589534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1LenscXh9zaYquM3t9qeffeE8ubuj1xHs/p3d7ol/nk=; b=LaCk6pAdO6hWM2VGtsxANnAGylLUesURv6jye8TuRdCZ73QDhA0Y6wwcuPq81N6ibA gb8ulAgaP6kt6JHSFn2zMqjbr/eREmctLWg7AadziEyjvkluAERqN/SIvix9X0QeYYUn D+dCiHf9XXdcW2wf0PCG3WTsKWp7ufTQDoWJ+6VdjUQaVtp3XrOD1CRwUl9RYzIbReMd uM+4et9Pq7n3OdTMkEUqkYdln8f/qhEsJGOn45q3yezWG/Yscs08/F+M8tkbpNBUoA4I 8u2g8KOuxM9V1cA8dEUrUL3Mti2eg9nSYiX8SGZ+i0jmQcJlQg+dBnMyNo0n87aHAiA/ A+nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688997534; x=1691589534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1LenscXh9zaYquM3t9qeffeE8ubuj1xHs/p3d7ol/nk=; b=Q6OuyxlTbiJOcwfgDfIi3v4l6QfnjTsJpKhUZheoiRAwuHgEqkxZV4fHtEuiJFz4Il fBYOTa3yTqOBcf4F850AzMXtPp3kli3yxIqcKHWjo00hpIH4hmgPZADvtiP1vjCAmN29 Bbhi9Yi5YQWJNmIIl9Ze4oFv3q6iS5aa+8RIDtNwKi1NbvS0mDI9aDqXE5aHHbyPl0vO 263dVK0xVlQ/A8JZs5Q4BhGbSULhs2Dt/tRPrKfckqx+IMntLfVznoh0hHfzXGu2qNY6 tbCsIYpN6uj0Gn9KKonIGpii6lSv4zMBVrPGx2et0B6kXVj+jO6sd658cfOtZ78o1yr3 jRoA== X-Gm-Message-State: ABy/qLawrFTK7pgdJOMMKdr/NFwDdJSisg2x6Oz/Cmnc8tXbV57d4S2d fw8ragWOMIqRm+ZeNEkLdP2BZFZV8ihiRnjxJVxNww== X-Google-Smtp-Source: APBJJlGe6UWHW3UdqnQU/+Yo4KJbHtaXueslHIWAjlLDRiv/f8Tpbn3U3dZqJhMXsTrIRrNYkfcX+oSDfOchX8Td0A4= X-Received: by 2002:aa7:c75a:0:b0:51e:2921:28b with SMTP id c26-20020aa7c75a000000b0051e2921028bmr12757107eds.21.1688997533725; Mon, 10 Jul 2023 06:58:53 -0700 (PDT) MIME-Version: 1.0 References: <20230707075145.2929681-1-christophe.lyon@linaro.org> <20230707075145.2929681-2-christophe.lyon@linaro.org> In-Reply-To: From: Christophe Lyon Date: Mon, 10 Jul 2023 15:58:42 +0200 Message-ID: Subject: Re: [PATCH] testsuite: Add _link flavor for several arm_arch* and arm* effective-targets To: Kyrylo Tkachov Cc: "gcc-patches@gcc.gnu.org" , Richard Earnshaw Content-Type: multipart/alternative; boundary="000000000000064e41060022622c" X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000064e41060022622c Content-Type: text/plain; charset="UTF-8" On Mon, 10 Jul 2023 at 15:46, Kyrylo Tkachov wrote: > > > > -----Original Message----- > > From: Christophe Lyon > > Sent: Friday, July 7, 2023 8:52 AM > > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > > Richard Earnshaw > > Cc: Christophe Lyon > > Subject: [PATCH] testsuite: Add _link flavor for several arm_arch* and > arm* > > effective-targets > > > > For arm targets, we generate many effective-targets with > > check_effective_target_FUNC_multilib and > > check_effective_target_arm_arch_FUNC_multilib which check if we can > > link and execute a simple program with a given set of flags/multilibs. > > > > In some cases however, it's possible to link but not to execute a > > program, so this patch adds similar _link effective-targets which only > > check if link succeeds. > > > > The patch does not uupdate the documentation as it already lacks the > > numerous existing related effective-targets. > > I think this looks ok but... > > > > > 2023-07-07 Christophe Lyon > > > > gcc/testsuite/ > > * lib/target-supports.exp (arm_*FUNC_link): New effective-targets. > > --- > > gcc/testsuite/lib/target-supports.exp | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/gcc/testsuite/lib/target-supports.exp > b/gcc/testsuite/lib/target- > > supports.exp > > index c04db2be7f9..d33bc077418 100644 > > --- a/gcc/testsuite/lib/target-supports.exp > > +++ b/gcc/testsuite/lib/target-supports.exp > > @@ -5129,6 +5129,14 @@ foreach { armfunc armflag armdefs } { > > return "$flags FLAG" > > } > > > > + proc check_effective_target_arm_arch_FUNC_link { } { > > + return [check_no_compiler_messages arm_arch_FUNC_link > > executable { > > + #include > > + int dummy; > > + int main (void) { return 0; } > > + } [add_options_for_arm_arch_FUNC ""]] > > + } > > + > > proc check_effective_target_arm_arch_FUNC_multilib { } { > > return [check_runtime arm_arch_FUNC_multilib { > > int > > @@ -5906,6 +5914,7 @@ proc add_options_for_arm_v8_2a_bf16_neon { > > flags } { > > # arm_v8m_main_cde: Armv8-m CDE (Custom Datapath Extension). > > # arm_v8m_main_cde_fp: Armv8-m CDE with FP registers. > > # arm_v8_1m_main_cde_mve: Armv8.1-m CDE with MVE. > > +# arm_v8_1m_main_cde_mve_fp: Armv8.1-m CDE with MVE with FP > > support. > > # Usage: > > # /* { dg-require-effective-target arm_v8m_main_cde_ok } */ > > # /* { dg-add-options arm_v8m_main_cde } */ > > @@ -5965,6 +5974,24 @@ foreach { armfunc armflag armdef arminc } { > > return "$flags $et_FUNC_flags" > > } > > > > + proc check_effective_target_FUNC_link { } { > > + if { ! [check_effective_target_FUNC_ok] } { > > + return 0; > > + } > > + return [check_no_compiler_messages FUNC_link executable { > > + #if !(DEF) > > + #error "DEF failed" > > + #endif > > + #include > > ... why is arm_cde.h included here? > > It's the very same code as check_effective_target_FUNC_multilib below. I think it's needed in case the toolchain's default configuration is not able to support CDE. I believe these tests would fail if the toolchain defaults to -mfloat-abi=soft (the gnu/stubs-{soft|hard}.h "usual" error) I added this chunk for consistency with the other one, it's not needed at the moment. Christophe > + INC > > + int > > + main (void) > > + { > > + return 0; > > + } > > + } [add_options_for_FUNC ""]] > > + } > > + > > proc check_effective_target_FUNC_multilib { } { > > if { ! [check_effective_target_FUNC_ok] } { > > return 0; > > -- > > 2.34.1 > > --000000000000064e41060022622c--