From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18210 invoked by alias); 23 Aug 2011 14:47:05 -0000 Received: (qmail 18201 invoked by uid 22791); 23 Aug 2011 14:47:04 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 14:46:48 +0000 Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7]) by smtp-out.google.com with ESMTP id p7NEkkIk020889 for ; Tue, 23 Aug 2011 07:46:46 -0700 Received: from pzk36 (pzk36.prod.google.com [10.243.19.164]) by hpaq7.eem.corp.google.com with ESMTP id p7NEkNF1010061 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 23 Aug 2011 07:46:45 -0700 Received: by pzk36 with SMTP id 36so270350pzk.3 for ; Tue, 23 Aug 2011 07:46:44 -0700 (PDT) Received: by 10.142.239.3 with SMTP id m3mr488044wfh.230.1314110804769; Tue, 23 Aug 2011 07:46:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.239.3 with SMTP id m3mr488037wfh.230.1314110804606; Tue, 23 Aug 2011 07:46:44 -0700 (PDT) Received: by 10.142.50.21 with HTTP; Tue, 23 Aug 2011 07:46:44 -0700 (PDT) In-Reply-To: References: <20110823123633.DEAAF1DA1D3@topo.tor.corp.google.com> Date: Tue, 23 Aug 2011 15:17:00 -0000 Message-ID: Subject: Re: [google] Remove timestamped line from gengtype state file comment headers From: Simon Baldwin To: Michael Matz Cc: Richard Guenther , gcc-patches@gcc.gnu.org, dnovillo@google.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01896.txt.bz2 On 23 August 2011 15:34, Michael Matz wrote: > > Hi, > > On Tue, 23 Aug 2011, Richard Guenther wrote: > > > > This patch removes the comment line, to provide binary reproducibilit= y for > > > any generated gtype.state files. > > > > > > Tested for x86 and PowerPC, no bootstrap in both cases. > > > > > > OK for google/integration? =A0Also, OK for trunk? > > > > Ok for trunk. > > But perhaps with a different ChangeLog entry :) Heh! Thanks, yes. Plainly I'm out of practice with gcc patches. Corrected version below, for completeness. -- Remove the timestamped line from gengtype state file comment headers. Gcc builds after r177358 include a file .../plugin/gtype.state as part of their binary installation. The file contains a comment line that includes the current date and time. Variations in the file contents due to only changes in the timestamp can be an issue for build and packaging systems that prefer or insist on binary compatibility. This patch removes the comment line, to provide binary reproducibility for any generated gtype.state files. Tested for x86 and PowerPC, no bootstrap in both cases. OK for google/integration? Also, OK for trunk? gcc/ChangeLog: 2011-08-23 Simon Baldwin * gengtype-state.c (write_state): Remove timestamped header line. Index: gcc/gengtype-state.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/gengtype-state.c (revision 177984) +++ gcc/gengtype-state.c (working copy) @@ -1194,8 +1194,6 @@ write_state (const char *state_path) fprintf (state_file, ";;; This file should be parsed by the same %s which wrote it.\n", progname); - fprintf (state_file, ";;; file %s generated on %s\n", state_path, - ctime (&now)); /* The first non-comment significant line gives the version string. */ write_state_version (version_string); write_state_srcdir (); -- Google UK Limited | Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W 9TQ | Registered in England Number: 3977902