From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17972 invoked by alias); 23 Aug 2013 15:48:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17946 invoked by uid 89); 23 Aug 2013 15:48:03 -0000 X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 15:48:02 +0000 Received: by mail-oa0-f41.google.com with SMTP id j6so943289oag.14 for ; Fri, 23 Aug 2013 08:48:01 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.63.68 with SMTP id e4mr324711oes.23.1377272881181; Fri, 23 Aug 2013 08:48:01 -0700 (PDT) Received: by 10.182.184.112 with HTTP; Fri, 23 Aug 2013 08:48:01 -0700 (PDT) In-Reply-To: <521779CA.8020103@oracle.com> References: <5217398F.50202@oracle.com> <52177128.1040505@oracle.com> <521779CA.8020103@oracle.com> Date: Fri, 23 Aug 2013 15:48:00 -0000 Message-ID: Subject: Re: [Patch 2/2] Localization problem in regex From: Tim Shen To: Paolo Carlini , Jonathan Wakely Cc: "libstdc++" , gcc-patches Content-Type: multipart/mixed; boundary=001a11c257d4d779a404e49f549c X-Virus-Found: No X-SW-Source: 2013-08/txt/msg01375.txt.bz2 --001a11c257d4d779a404e49f549c Content-Type: text/plain; charset=ISO-8859-1 Content-length: 879 On Fri, Aug 23, 2013 at 11:03 PM, Paolo Carlini wrote: > The assign change is fine. But I would also put between round brackets > (class _Compiler<>) for the _M_traits change and use something like > (_DFSExecutor<>::_DFSExecutor): Adjust. for the last change (remember that > constructors are special member *functions* thus should be normally listed). I see. On Fri, Aug 23, 2013 at 10:57 PM, Jonathan Wakely wrote: > Yes, that makes it clear what part of the file is affected. That's > important when searching ChangeLogs to find what change last touched > e.g. basic_regex::assign. Why don't we `svn blame`? By the way, do we seariously need to keep ChangeLog in files? Is it more like a tradition than a solution? After all, we have SVN or Git now. I remember a mail metioned this but cannot find it >.< -- Tim Shen --001a11c257d4d779a404e49f549c Content-Type: application/octet-stream; name=changelog Content-Disposition: attachment; filename=changelog Content-Transfer-Encoding: base64 X-Attachment-Id: f_hkpkn2nh0 Content-length: 663 MjAxMy0wOC0yMyAgVGltIFNoZW4gIDx0aW1zaGVuOTFAZ21haWwuY29tPgoK CSogaW5jbHVkZS9iaXRzL3JlZ2V4LmggKGJhc2ljX3JlZ2V4PD46OmFzc2ln bik6IERvbid0IGxvc2UgX01fdHJhaXRzLgoJKiBpbmNsdWRlL2JpdHMvcmVn ZXhfY29tcGlsZXIuaDogU3RvcmUgX0NvbXBpbGVyOjpfTV90cmFpdHMgYnkg cmVmZXJlbmNlCgkgIGluc3RlYWQgb2YgYnkgdmFsdWUuCgkqIGluY2x1ZGUv Yml0cy9yZWdleF9leGVjdXRvci5oIChfREZTRXhlY3V0b3I8Pjo6X0RGU0V4 ZWN1dG9yKTogQWRkCgkgIF9NX3RyYWl0cyB0byBfREZTRXhlY3V0b3IuCgkq IGluY2x1ZGUvYml0cy9yZWdleF9leGVjdXRvci50Y2MgKF9fZ2V0X2V4ZWN1 dG9yPD4pOiBQYXNzIF9NX3RyYWl0cyB0bwoJICBfREZTRXhlY3V0b3IgdG9v LgoJKiB0ZXN0c3VpdGUvMjhfcmVnZXgvYWxnb3JpdGhtcy9yZWdleF9tYXRj aC9leHRlbmRlZC93c3RyaW5nX2xvY2FsZS5jYzoKCSAgTmV3Lgo= --001a11c257d4d779a404e49f549c--