From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id 456DA3882AC4 for ; Wed, 4 Oct 2023 17:00:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 456DA3882AC4 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-668ebbcc0b6so13821316d6.0 for ; Wed, 04 Oct 2023 10:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696438834; x=1697043634; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jSJO1627l9EgXrrtdfIlDls4feBZ6Q7qmSAGbr8C8ic=; b=WILFrNn0creFA9ak6p6uAtYIqTHMeSR2JXy4EcKjpV33uC8itfltxww4J8lZbB65x4 fsxApFHdFJ76Euo5wrRFPAtxcbnDD77CWOOHXjbBpCcYXpfI/3io96lLyrwopwsF/Kir QpE+SlOOMdEWOh4B377ErY4OZKw3mSvDMvJ1nzs/xVEiCDrE/alPkFok1lKW8rc3Fd7V kgmAUNUrIhdibaI1AzyJm7u7brjVgAW9qZ8u1+tVuiAl8BOabObdbXOAmHYqfl8i+hDK wuc3o1rnLi0JMLI8X+Cx56blJNTL9P5XEuCC2jfbZZZkdOtOIQZPuwYTli/14hxpBEhR pWgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696438834; x=1697043634; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSJO1627l9EgXrrtdfIlDls4feBZ6Q7qmSAGbr8C8ic=; b=m+X9Uz3EUAKgjCc2hdwO45FPKb9HKSpo5JeM350y/DAuOLSJnUqahHSud2GjvShAz+ Jog2wMijORcWETcXHTKhXOLhUzal3ryYHt74BTEWWxpaNzdWSt9gDC0fnOJ/S0MJxpQZ p8bXQW9sRAgeX0VLoN7pSka9DFTOlqrFt9kDNcFdZmnhkp6yTeYyANROBSMxXrpoDj34 bybJpAEn2XEkpuzpgio5oyyIE8OQVeAggKzkYpPB5jqW9Xt05DhFgyy51vpIqsRg7CEu 9Ct2ALgnyWwQPOhlf+2TLomhRit454a+be/OKHK7Mpf3fdIs0UX1IyiCg1erddwAaoMT 7knA== X-Gm-Message-State: AOJu0Yz1DB3t6UVMQdSd0hOL6upvILeoM/nh1jU2YCVDjChrcAI3rAzS Ra10AXlh/ePOpGH/hG3rfrCdeWZm2idcu3cwpfGaXQ== X-Google-Smtp-Source: AGHT+IGGGySG0GiA0oDyCkD5kFMu8G0mXVXoAqQDYukeAePUEhXVftBRNv6bGxa/1avISXeyulZ5xydNCkjP2Yhse04= X-Received: by 2002:a0c:f647:0:b0:65b:2ad1:14f8 with SMTP id s7-20020a0cf647000000b0065b2ad114f8mr2743015qvm.42.1696438834177; Wed, 04 Oct 2023 10:00:34 -0700 (PDT) MIME-Version: 1.0 References: <20230817203213.1131496-1-jwakely@redhat.com> <097e48f1-b915-4d6c-b68e-8ee282bc6de5@redhat.com> In-Reply-To: From: Pranav Kant Date: Wed, 4 Oct 2023 10:00:23 -0700 Message-ID: Subject: Re: [committed] libstdc++: Define std::numeric_limits<_FloatNN> before C++23 To: Jakub Jelinek Cc: Jonathan Wakely , Stephan Bergmann , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000189d930606e6f20c" X-Spam-Status: No, score=-17.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000189d930606e6f20c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I will revert the commit while I work on this. Thanks for the pointers. On Wed, Oct 4, 2023 at 9:57=E2=80=AFAM Jakub Jelinek wro= te: > On Wed, Oct 04, 2023 at 09:47:34AM -0700, Pranav Kant wrote: > > Thanks for bringing this to my attention. I am working on a fix. Will > keep > > this thread posted. > > > > Clang *does* define this macro only when float128 type is available. But > > the problem seems to be that clang doesn't define _Float128 alias type > > which is what's being used here. It only defines __float128 type. Should > be > > easy to fix. > > _Float128 (and other _FloatNN types) are standard C23 and C++23 types, > they certainly can't be simple aliases to __float128 or other similar > types. > In C++ they mangle differently, have significantly different behavior in > lots of different language details. > So, you need to implement the https://wg21.link/P1467R9 paper, rather than > doing quick hacks. > > Jakub > > --000000000000189d930606e6f20c--