From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id A8E073858D32 for ; Sat, 10 Sep 2022 16:03:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8E073858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2f.google.com with SMTP id n125so4708535vsc.5 for ; Sat, 10 Sep 2022 09:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=AVn/vjN9QluaKbDqRXAsXsi64r6DFaW+YVqSHEq7mUg=; b=VcSK+Nej1FrMu1ixgMmFU80Cv2Hre+jWOFxVtdcHKfHXs7J8FtLcPY9/RboKv/7PZD 0uVnwdjVMOfyYhGsIJDYU5NiB2KiK9KzwdRV1Uy76nGWZTMrRQ8lyzfOQRpGz5wdtAd8 N7h+IFCEJBDaf7XOL4tdiNSiZdPppSSpRlAPi8N70nb+Wuc/AKcaXR7OeZYF6j6D1mNA nHWbQPJ3YuGk9fh/4rsmFEMPT6iHvAtw0PIAYiLM6mcJITNam+vh2KkvRGt8hGnAtg4M FHc01Up+0l6UQUMpFqxdiXmweNwLaX6tUQuIeDn3r3hPkgDDD6sylHhdzCDufArpxE0R AmrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=AVn/vjN9QluaKbDqRXAsXsi64r6DFaW+YVqSHEq7mUg=; b=hoOfVyPHDKvrjdE59xnWG1wx0yapWJ62+OQ4H7G9JkBb1ud4JHYpzYT2uLjt0n5que YQJEd457oH1AGG+lMLVJC7icC2Yi41tBPegwQFTi/P1Toksc/rq3I2wlALJ9lxbfAWFj nPWA7/bBpGHxAD7HqiqeK5SK64ogTopTWMoZAHKaDDlXlBOxzhw7t4w/ec4LddKSSioT 70Obx6YIpr3u7U9X16UiRfjJmvNMpk3r3XA32AP2KJBNsM1PH6bi4DoTCInEuAKdTiYv 1Sxy/CZ7wtd/uGCbfB04xFohxmKfYeHDXUHGAPSz654GEiGPxJ/AZaLhhIgpmR0qttHa fSug== X-Gm-Message-State: ACgBeo1TY8+c5yaMAZgvtps+EXE2GxTlMDorWawRzQxZJvJxyZUzY3pZ rmImQJTt6cUnTv7PymhOoZAH0FOCdtaxObKOeax/fee+qnDQrw== X-Google-Smtp-Source: AA6agR75r3ohLpjRyrlNMD3AfYCc0DhAIVPy+BrkllecCmD28zz8CLwaz8/WTdzGSMJJMQMMvXNmabwBFNqg6pWMstk= X-Received: by 2002:a67:fdc3:0:b0:398:26c4:52f9 with SMTP id l3-20020a67fdc3000000b0039826c452f9mr6170507vsq.8.1662825790909; Sat, 10 Sep 2022 09:03:10 -0700 (PDT) MIME-Version: 1.0 References: <20220910152617.GU25951@gate.crashing.org> In-Reply-To: <20220910152617.GU25951@gate.crashing.org> From: Akari Takahashi Date: Sun, 11 Sep 2022 01:03:00 +0900 Message-ID: Subject: Re: [PATCH] : [gcc/config/rs600/rs6000.cc][Fix typo] Add parentheses for if statement To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, takahashiakari@member.fsf.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Segher! I'd like to thank you from the bottom of my heart ! I was happy to see my name listed in the github repository as well. This will motivate me to do my best to commit more to GCC.. :) Best Regards, Takahashi Akari https://github.com/takahashi-akari GPG Key: 9DD8 F529 83A0 3182 D318 6184 9309 E8D2 2FD4 4365 On Sun, Sep 11, 2022 at 12:28 AM Segher Boessenkool wrote: > > Hi! > > Please cc: the rs6000 maintainers on rs6000 patches. > > On Thu, Sep 08, 2022 at 08:20:07AM +0900, Akari Takahashi via Gcc-patches wrote: > > --- a/gcc/config/rs6000/rs6000.cc > > +++ b/gcc/config/rs6000/rs6000.cc > > @@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base, > > HOST_WIDE_INT *offset, > > HOST_WIDE_INT *size) > > { > > rtx addr_rtx; > > - if (MEM_SIZE_KNOWN_P (mem)) > > + if MEM_SIZE_KNOWN_P (mem) > > *size = MEM_SIZE (mem); > > else > > return false; > > This patch is generated backwards. > > I committed the following. Thanks! > > > Segher > > > Subject: [PATCH] rs6000: Make an "if" statement more regular > > As Akari noticed, we have an unusual "if" statement without parentheses > around the condition. The condition is a macro that expands to > something with parentheses in the right spot, but, let's make the code a > little less surprising :-) > > > 2022-09-10 Akari Takahashi > Segher Boessenkool > > * config/rs6000/rs6000.cc (get_memref_parts): Regularize some code. > --- > gcc/config/rs6000/rs6000.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc > index a656cb32a472..bcf634a146de 100644 > --- a/gcc/config/rs6000/rs6000.cc > +++ b/gcc/config/rs6000/rs6000.cc > @@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base, HOST_WIDE_INT *offset, > HOST_WIDE_INT *size) > { > rtx addr_rtx; > - if MEM_SIZE_KNOWN_P (mem) > + if (MEM_SIZE_KNOWN_P (mem)) > *size = MEM_SIZE (mem); > else > return false;