From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by sourceware.org (Postfix) with ESMTPS id 194DF3858C52 for ; Tue, 13 Jun 2023 19:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 194DF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-43dc0aa328dso929427137.1 for ; Tue, 13 Jun 2023 12:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686683635; x=1689275635; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=VPX78Lsg88t0CQuwhPKbS+ng80fiWDPISnx3WiVDUn4=; b=QsHnyXL2uK9HPOxThe3eNNSa40Ehm/zy/KYsZFoGJS6h0+cRx9vR6zkaqkgeclLOkc 9cLQMPlsDJLcBdeAEEA1/04tmU36VaUYLP8jmiHes57HNkF7+jlPmpzZGRVzCbwZE1xT XAxoVOKIo0t/C5dnhSf9G9/Xtj4ynH1QhDFmG2/G/T29gXWwLBEydeTF3PQYsGOA9tU5 hAgL6D+GkaCGAuj9bl4e+PMZjS29gB3Yuaur5HdpEbw4aO/hIGCm3CdLF+tIUUoKdRcF h75V3jGpAOg9tNs0llO6lCuZZ/UVlN/zblF3nZOr7+RAJLxCk/zV9WHH2DMK2Pqlgecm VH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686683635; x=1689275635; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VPX78Lsg88t0CQuwhPKbS+ng80fiWDPISnx3WiVDUn4=; b=Hmd8sltgHRGLN5FjTpY458aT0svp+OcZfdKSaUMzOWR+Yzw+p3mOn5SPhwiqZV/ILJ SutXFEWGEb1pClXbRYTmP7u4gmtg3ghg4jhaXp4fwzo52pQLxzGW4+UHFFYTXBk9DKqe YfQTbaMeSeNf/oq6CgyKi1D1qQmYUu5T1ETSXL/Kfu0k/ruCOi6mxRD7k3Njyv1hlTJ+ d2CG+dEA+eer3os+o/rAuDkENNGDY2hZNeJboexoVz1ugneMeXv3NA6HpRjJ8ajhsBIv 3vwHBOavQE7ZpnuTzIzJnCE7bzupeB3Ti8W3NusQitAx3jdlUpzPCBJyEFQxMOtBA7Ka zlxg== X-Gm-Message-State: AC+VfDySp5wWHb5Ugab+LUngONSgbM+h94NWzDUuMK7FixbZPiqnsHVT vZJ3NCs7tyalmqUUkLpi2NlIT5Toaft1O4n1di4= X-Google-Smtp-Source: ACHHUZ5D6UnkzFwz1ljXx3AAMu2Wtn0e/KyZTRRU9AhmsfTTbjJS2eEhiCZDw5Zhx9ff+9rX3jUCvwmerSnNzx+i+fY= X-Received: by 2002:a05:6102:291e:b0:43b:2c84:1fca with SMTP id cz30-20020a056102291e00b0043b2c841fcamr7978828vsb.5.1686683635206; Tue, 13 Jun 2023 12:13:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akari Takahashi Date: Wed, 14 Jun 2023 04:13:44 +0900 Message-ID: Subject: Re: [PATCH] Fix note_defect3 function To: Jeff Law , gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000eccf9e05fe07a22d" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000eccf9e05fe07a22d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jeff, Thank you for your response. Regarding the divtab.cc file, I actually came across it by accident while working on another task. I didn't have a specific reason for investigating the file, but I noticed the issue and thought it was worth bringing to your attention. Thank you for taking care of this issue. Best Regards, Takahashi Akari On Tue, Jun 13, 2023 at 10:50=E2=80=AFPM Jeff Law w= rote: > > > On 6/12/23 21:18, Akari Takahashi via Gcc-patches wrote: > > Hello, > > > > I've noticed an issue with the note_defect3 function and have prepared a > > patch to fix it. The function is missing a return statement, which is > > causing undefined behavior. This patch adds the missing return statemen= t, > > ensuring that the function returns the correct value. > > > > Please consider applying this patch to correct the issue. Thank you. > > > > Best regards, > > > > Takahashi Akari > Thanks. Reviewing that file it looks like it was just supposed to be > used for the sh5/sh5media processor. My recollection is those were > never actually produced and support for them was removed from GCC some > time ago. This file was missed during that removal. > > Rather than apply the patch, I think the better choice is to just remove > the divtab.cc file unless someone has a real use for it. > > Is there a particular reason you were investigating the divtab.cc file? > > jeff > --000000000000eccf9e05fe07a22d--