From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id C6210385B527 for ; Fri, 24 Feb 2023 10:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6210385B527 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wr1-x42e.google.com with SMTP id l1so13126746wry.10 for ; Fri, 24 Feb 2023 02:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Hgrs0IJhEUMkVyu6WflNixfrXCM//GZLqy2YFWle/E8=; b=TTN9zI9vlmKEYQFRdzaTO6VWqrBTLL+qn08EcPHCgHO2LSx8F3d4mE9SRsggJ/llDn cE0k4MCzHGFJLdbQQ03BL6XkC12FC6bC2z7cdj4HFQr+aT7zyfTt+B2Jsw6NEpgSrQjU pJzc/H17FpvmBPre7b+MyWOwI1Ko4FlOChoRDuGUQyUVvwmgc1oR/GBlYHuTrQLzQckh wmVZMUi943Uif6Js1ObLSZ+NDUvWu/Gdp4ownIxx3VQzUVqLZHhGAHkgkRuFPd6hiBT+ JU8wO9wt7GZDA1j80lI0CL64e60/mQvtrO00Bfrtvq9ACOBL9h8RU156Cy2fRvjpQtkM z4NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hgrs0IJhEUMkVyu6WflNixfrXCM//GZLqy2YFWle/E8=; b=uR69rrzN4ueZnM4EONETgmbluBBqk/qHOIWRk7w0jtPkFhoxDkKtirWo3mUJNtiMYx ffJzXXtHiRPZiWZo4/oH/DlyGqnvlMuwNczgUIg0XVy9FHyJGY8ukYkchZv+iF8AS3G2 66IBpjC7PpuZrhJYwV2lWXf9f6Kuxjl1ksDGC0d9QMIqSlxNx+OtW06SM7xXhuw9vOJ8 t8lOkUcmNg/CxGt3rX38/eMkgDAFabfNxHoW/iAP+bL0zwT9PAPII0xbimI/FFsJtEZQ RVr8DDL6gMzvZvP/gqFcLcHbeh/DwDqEM0XqWNOt7u/qEJd44AOmm9iYQ2avBqvzVV+J 7XFA== X-Gm-Message-State: AO0yUKUuIgiLgxm1HcEy+c9VSbnMemu2PXNC0oLDeSOPBrs7ma3TD5ZI dBUKQsS1PcQEV4MLYyWTEks= X-Google-Smtp-Source: AK7set/AXcuvzBY+DbAbHgQmlnhTYz/lOo577uh+qiivQ1K+2Opt63lmPAQJ92jw8PpegfY8j799Cw== X-Received: by 2002:a5d:5609:0:b0:2c4:71b1:3160 with SMTP id l9-20020a5d5609000000b002c471b13160mr14352211wrv.42.1677234640074; Fri, 24 Feb 2023 02:30:40 -0800 (PST) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id u9-20020a05600c210900b003e2243cfe15sm2289836wml.39.2023.02.24.02.30.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2023 02:30:39 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: C++ modules and AAPCS/ARM EABI clash on inline key methods From: Iain Sandoe In-Reply-To: Date: Fri, 24 Feb 2023 10:30:38 +0000 Cc: Alexandre Oliva , GCC Patches , Nathan Sidwell , nickc@redhat.com, richard.earnshaw@arm.com, ramana.gcc@gmail.com, kyrylo.tkachov@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <05cf53e4-af4d-7af1-da4b-3635345db9bf@foss.arm.com> <4f555382-6c59-4574-c2a2-d50608c70908@foss.arm.com> To: Richard Earnshaw X-Mailer: Apple Mail (2.3696.120.41.1.2) X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 24 Feb 2023, at 10:23, Richard Earnshaw via Gcc-patches = wrote: >=20 >=20 >=20 > On 23/02/2023 21:20, Alexandre Oliva wrote: >> On Feb 23, 2023, Alexandre Oliva wrote: >>> On Feb 23, 2023, Richard Earnshaw = wrote: >>>> On 22/02/2023 19:57, Alexandre Oliva wrote: >>>>> On Feb 21, 2023, Richard Earnshaw = wrote: >>>>>=20 >>>>>> Rather than scanning for the triplet, a better test would be >>>>>=20 >>>>>> { xfail { arm_eabi } } >>>>>=20 >>>>> Indeed, thanks. Here's the updated patch, retested. Ok to = install? >>>> Based on Nathan's comments, we should just skip the test on = arm_eabi, >>>> it's simply not applicable. >>> Like this, I suppose. Retested on x86_64-linux-gnu (trunk) and >>> arm-wrs-vxworks7 (gcc-12). Ok to install? >> Erhm, actually, that version still ran the assembler scans and = failed. >> This one skips the testset entirely. >=20 > Yeah, I tried something like that and it didn't appear to work. = Perhaps it's a bug in the way dg-do-module is implemented. I think if you suppress the dg-do run line (with the target selector) = then it will just do the default (which is to compile only?) Skip seems like the correct thing to do here .. Iain >=20 >> [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods >> From: Alexandre Oliva >> g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm = targets >> that use the AAPCS variant. ARM is the only target that overrides >> TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way >> the clash between AAPCS and C++ Modules design should be resolved, = but >> currently it favors AAPCS and thus the test fails, so skip it on >> arm_eabi. >> for gcc/testsuite/ChangeLog >> PR c++/105224 >> * g++.dg/modules/virt-2_a.C: Skip on arm_eabi. >> --- >> gcc/testsuite/g++.dg/modules/virt-2_a.C | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C = b/gcc/testsuite/g++.dg/modules/virt-2_a.C >> index 580552be5a0d8..ede711c3e83be 100644 >> --- a/gcc/testsuite/g++.dg/modules/virt-2_a.C >> +++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C >> @@ -1,3 +1,6 @@ >> +// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE, >> +// in a way that invalidates this test. >> +// { dg-skip-if "TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } } >=20 > Given the logic of this macro, the text should be = "!TARGET_CXX_METHOD_MAY_BE_INLINE". >=20 > OK with that change. >=20 > R. >=20 >> // { dg-module-do run } >> // { dg-additional-options -fmodules-ts } >> export module foo;