From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68941 invoked by alias); 8 Jun 2015 08:03:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68607 invoked by uid 89); 8 Jun 2015 08:03:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jun 2015 08:03:19 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Z1s1Z-0007Kh-QY from Iain_Sandoe@mentor.com ; Mon, 08 Jun 2015 01:03:14 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.224.2; Mon, 8 Jun 2015 09:03:12 +0100 Subject: Re: [patch] fix _OBJC_Module defined but not used warning MIME-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset="windows-1252" From: Iain Sandoe In-Reply-To: <55742CFB.2060209@redhat.com> Date: Mon, 08 Jun 2015 08:05:00 -0000 CC: Andreas Schwab , GCC Mailing List , Mike Stump , gcc-patches Content-Transfer-Encoding: quoted-printable Message-ID: References: <5571F319.205@redhat.com> <55742CFB.2060209@redhat.com> To: Aldy Hernandez X-SW-Source: 2015-06/txt/msg00534.txt.bz2 Hi Aldy, On 7 Jun 2015, at 12:37, Aldy Hernandez wrote: > On 06/07/2015 06:19 AM, Andreas Schwab wrote: >> Another fallout: >>=20 >> FAIL: obj-c++.dg/try-catch-5.mm -fgnu-runtime (test for excess errors) >> Excess errors: >> : warning: '_OBJC_Module' defined but not used [-Wunused-varia= ble] >=20 > check_global_declarations is called for more symbols now. All the define= d but not used errors I've seen in development have been legitimate. For t= ests, the tests should be fixed. For built-ins such as these, does the att= ached fix the problem? >=20 > It is up to the objc maintainers, we can either fix this with the attache= d patch, The current patch is OK. > or setting DECL_IN_SYSTEM_HEADER. This seems a better long-term idea; however, I would prefer to go through a= ll the cases where it would be applicable (including for the NeXT runtime) = and apply that change as a coherent patch. At the moment dealing with the = NeXT stuff is a bit hampered by pr66448. thanks, Iain