From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Improve combining of conditionals
Date: Fri, 15 Apr 2011 10:54:00 -0000 [thread overview]
Message-ID: <CDFA34D1-4297-4FA1-A470-0F29604B0F7F@codesourcery.com> (raw)
In-Reply-To: <BANLkTimUvcShsaKBC9zJnfHUr2-eLUTgzw@mail.gmail.com>
On Apr 15, 2011, at 2:38 PM, Steven Bosscher wrote:
> On Fri, Apr 15, 2011 at 11:04 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> @@ -4938,11 +4938,13 @@ find_split_point (rtx *loc, rtx insn, bool set_src)
>>
>> IN_DEST is nonzero if we are processing the SET_DEST of a SET.
>>
>> + IN_COND is nonzero if we are on top level of the condition.
>>
>> "...we are at the top level of a condition."
>
> And make IN_COND a bool instead of an int?
I think it's better to follow existing format of the function and make IN_COND to be of the same type as IN_DEST, i.e., an 'int'. I agree that 'bool' should be preferred when adding a new function or significantly rewriting an existing one.
--
Maxim Kuvyrkov
Mentor Graphics / CodeSourcery
next prev parent reply other threads:[~2011-04-15 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 7:59 Maxim Kuvyrkov
2011-04-15 9:27 ` Eric Botcazou
2011-04-15 10:49 ` Steven Bosscher
2011-04-15 10:54 ` Maxim Kuvyrkov [this message]
2011-04-15 11:14 ` Eric Botcazou
2011-04-15 16:55 ` Mike Stump
2011-04-15 17:52 ` Eric Botcazou
2011-04-15 18:16 ` Mike Stump
2011-04-15 12:31 ` Eric Botcazou
2011-04-15 12:41 ` Maxim Kuvyrkov
2011-04-25 15:32 ` Maxim Kuvyrkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CDFA34D1-4297-4FA1-A470-0F29604B0F7F@codesourcery.com \
--to=maxim@codesourcery.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).