From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11566 invoked by alias); 15 Apr 2011 10:44:06 -0000 Received: (qmail 11553 invoked by uid 22791); 15 Apr 2011 10:44:05 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 10:44:00 +0000 Received: (qmail 22300 invoked from network); 15 Apr 2011 10:43:59 -0000 Received: from unknown (HELO ?172.16.1.234?) (maxim@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Apr 2011 10:43:59 -0000 Subject: Re: [PATCH] Improve combining of conditionals Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Maxim Kuvyrkov In-Reply-To: Date: Fri, 15 Apr 2011 10:54:00 -0000 Cc: Eric Botcazou , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <33F4E740-6ED2-4694-B63C-E43ED3B91461@codesourcery.com> <201104151104.44739.ebotcazou@adacore.com> To: Steven Bosscher X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01164.txt.bz2 On Apr 15, 2011, at 2:38 PM, Steven Bosscher wrote: > On Fri, Apr 15, 2011 at 11:04 AM, Eric Botcazou w= rote: >> @@ -4938,11 +4938,13 @@ find_split_point (rtx *loc, rtx insn, bool set_s= rc) >>=20 >> IN_DEST is nonzero if we are processing the SET_DEST of a SET. >>=20 >> + IN_COND is nonzero if we are on top level of the condition. >>=20 >> "...we are at the top level of a condition." >=20 > And make IN_COND a bool instead of an int? I think it's better to follow existing format of the function and make IN_C= OND to be of the same type as IN_DEST, i.e., an 'int'. I agree that 'bool= ' should be preferred when adding a new function or significantly rewriting= an existing one. -- Maxim Kuvyrkov Mentor Graphics / CodeSourcery